External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: build script venv handling and lint fixes

Browse Source 
- Use /opt/venv directly when --entrypoint bash bypasses entrypoint.sh
- Use sys.executable for all pip calls (not bare pip)
- Override entrypoint in CI workflow to avoid startup banner
- Fix Biome formatting (template literals, try/catch blocks)
This commit is contained in:
SnapOtter
2026-06-13 20:48:27 +08:00
parent d0732d4a58
commit b1e94bd988
4 changed files with 69 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/features/install-feature-prebuilt.test.ts
+32 -46
View File
@@ -1,13 +1,6 @@
import { spawnSync, execFileSync } from "node:child_process";
import {
existsSync,
mkdirSync,
mkdtempSync,
readFileSync,
rmSync,
writeFileSync,
} from "node:fs";
import { execFileSync, spawnSync } from "node:child_process";
import { createHash } from "node:crypto";
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { afterEach, beforeEach, describe, expect, it } from "vitest";
@@ -93,19 +86,15 @@ describe("install_feature.py prebuilt mode", () => {
const { tarPath, sha256 } = createTestTar("face-detection");
writeManifest("face-detection", tarPath, sha256);
const result = spawnSync(
"python3",
[scriptPath, "face-detection", manifestPath, modelsDir],
{
env: {
...process.env,
DATA_DIR: tempDir,
PYTHON_VENV_PATH: venvDir,
SNAPOTTER_BUNDLE_LOCAL_PATH: tarPath,
},
timeout: 30_000,
const result = spawnSync("python3", [scriptPath, "face-detection", manifestPath, modelsDir], {
env: {
...process.env,
DATA_DIR: tempDir,
PYTHON_VENV_PATH: venvDir,
SNAPOTTER_BUNDLE_LOCAL_PATH: tarPath,
},
);
timeout: 30_000,
});
expect(result.status, `stderr: ${result.stderr?.toString()}`).toBe(0);
expect(existsSync(join(modelsDir, "testmodel", "weights.bin"))).toBe(true);
@@ -120,19 +109,15 @@ describe("install_feature.py prebuilt mode", () => {
const { tarPath } = createTestTar("face-detection");
writeManifest("face-detection", tarPath, "badhash".padEnd(64, "0"));
const result = spawnSync(
"python3",
[scriptPath, "face-detection", manifestPath, modelsDir],
{
env: {
...process.env,
DATA_DIR: tempDir,
PYTHON_VENV_PATH: venvDir,
SNAPOTTER_BUNDLE_LOCAL_PATH: tarPath,
},
timeout: 30_000,
const result = spawnSync("python3", [scriptPath, "face-detection", manifestPath, modelsDir], {
env: {
...process.env,
DATA_DIR: tempDir,
PYTHON_VENV_PATH: venvDir,
SNAPOTTER_BUNDLE_LOCAL_PATH: tarPath,
},
);
timeout: 30_000,
});
expect(result.status).not.toBe(0);
});
@@ -141,23 +126,24 @@ describe("install_feature.py prebuilt mode", () => {
const { tarPath, sha256 } = createTestTar("face-detection");
writeManifest("face-detection", tarPath, sha256);
const result = spawnSync(
"python3",
[scriptPath, "face-detection", manifestPath, modelsDir],
{
env: {
...process.env,
DATA_DIR: tempDir,
PYTHON_VENV_PATH: venvDir,
SNAPOTTER_BUNDLE_LOCAL_PATH: tarPath,
},
timeout: 30_000,
const result = spawnSync("python3", [scriptPath, "face-detection", manifestPath, modelsDir], {
env: {
...process.env,
DATA_DIR: tempDir,
PYTHON_VENV_PATH: venvDir,
SNAPOTTER_BUNDLE_LOCAL_PATH: tarPath,
},
);
timeout: 30_000,
});
const stderr = result.stderr?.toString() ?? "";
const progressLines = stderr.split("\n").filter((l) => {
try { const p = JSON.parse(l); return typeof p.progress === "number"; } catch { return false; }
try {
const p = JSON.parse(l);
return typeof p.progress === "number";
} catch {
return false;
}
});
expect(progressLines.length).toBeGreaterThan(0);