External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: error-only Sentry telemetry, storm-proof capture, and crash fixes (#476)

Browse Source 
Removes Sentry tracing entirely (BullMQ idle polling burned 4.8M transactions in 2 days at the baked 0.1 rate), decouples PostHog sampling, and replaces the type-only error scrub with a vetted-field sanitizer plus SafeError/ToolInputError contracts. One classified capture path with per-signature throttles and a per-process ceiling makes storms impossible (NODE-1E was 4,541 events from one 30s loop). Browser errors move to a dedicated web Sentry project with their own source maps. Adds the SNAPOTTER_TELEMETRY runtime kill switch and silences test fleets.

Crash fixes: remote 204/304 SSRF process kill (NODE-20), conversion-preset boot crash loop (NODE-21), Redis version preflight + unhandled subscribe rejection (NODE-1T), Sign PDF on plain-http origins (NODE-1K/1M), wavesurfer/pdf.js teardown rejections (NODE-1P/1N), bundle-import ZlibError to 400 (NODE-1Z), chart-maker input errors declassified (NODE-1H/1J), asset requests skip the session DB lookup (NODE-1D).
This commit is contained in:
SnapOtter
2026-07-10 21:41:49 +08:00
committed by GitHub
parent 3d1744aec8
commit ae6a4c8b7c
75 changed files with 2198 additions and 260 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e-docker/embedded-mode.mjs
+40 -6
View File
@@ -75,8 +75,22 @@ async function main() {
cleanup();
// 1. Bare `docker run` with no DB env boots and becomes healthy.
// Prod images bake real telemetry keys, so every container start in this
// harness sets SNAPOTTER_TELEMETRY=0 to keep test-fleet boots silent.
console.log("\n[1] bare docker run boots healthy");
docker(["run", "-d", "--name", NAME, "-p", `${PORT}:1349`, "-v", `${VOL}:/data`, IMAGE]);
docker([
"run",
"-d",
"--name",
NAME,
"-p",
`${PORT}:1349`,
"-v",
`${VOL}:/data`,
"-e",
"SNAPOTTER_TELEMETRY=0",
IMAGE,
]);
const healthy = await waitHealthy(300000);
healthy
? ok("embedded container reached healthy")
@@ -111,15 +125,23 @@ async function main() {
// 4. Non-root fails fast.
console.log("\n[4] non-root fail-fast");
combined(["run", "--rm", "--user", "1000:1000", IMAGE]).includes("embedded mode needs root")
combined(["run", "--rm", "--user", "1000:1000", "-e", "SNAPOTTER_TELEMETRY=0", IMAGE]).includes(
"embedded mode needs root",
)
? ok("non-root rejected with guidance")
: bad("non-root not rejected");
// 5. Partial config fails fast.
console.log("\n[5] partial-config fail-fast");
combined(["run", "--rm", "-e", "REDIS_URL=redis://x:6379", IMAGE]).includes(
"set BOTH DATABASE_URL and REDIS_URL",
)
combined([
"run",
"--rm",
"-e",
"REDIS_URL=redis://x:6379",
"-e",
"SNAPOTTER_TELEMETRY=0",
IMAGE,
]).includes("set BOTH DATABASE_URL and REDIS_URL")
? ok("partial config rejected")
: bad("partial config not rejected");
@@ -152,7 +174,19 @@ async function main() {
"-c",
`apk add --no-cache sqlite >/dev/null 2>&1 && sqlite3 /data/snapotter.db "${seedSql}"`,
]);
docker(["run", "-d", "--name", NAME, "-p", `${PORT}:1349`, "-v", `${VOL}:/data`, IMAGE]);
docker([
"run",
"-d",
"--name",
NAME,
"-p",
`${PORT}:1349`,
"-v",
`${VOL}:/data`,
"-e",
"SNAPOTTER_TELEMETRY=0",
IMAGE,
]);
(await waitHealthy(300000))
? ok("healthy after upgrade boot")
: bad("unhealthy after upgrade boot");