fix: resolve multiple API and e2e test bugs

- Health endpoint returns "healthy" instead of "ok" for consistency
- MAX_USERS now configurable via env var (default 5)
- People API returns team names instead of UUIDs in register/list
- PUT user update accepts team names (name-first lookup, fallback to ID)
- Login rate limit follows global rate limit when RATE_LIMIT_PER_MIN > 1000
- Strip-metadata preserves original format encoding instead of always PNG
- Fix e2e tests: rotate/crop/border button selectors match actual UI
- Fix e2e tests: create Engineering/Design teams in people test setup
- Fix e2e tests: people UI uses select for team field, not text input
- Update visual regression baseline for tablet home page
This commit is contained in:
Siddharth Kumar Sah
2026-04-04 17:44:51 +08:00
parent 9f0354388f
commit 9d621734c3
11 changed files with 110 additions and 48 deletions
+18 -1
View File
@@ -39,11 +39,27 @@ async function cleanupTestUsers(token: string) {
}
}
/** Ensure a team exists by name (create if missing). */
async function ensureTeam(token: string, name: string) {
const res = await fetch(`${API}/api/v1/teams`, {
method: "POST",
headers: authJson(token),
body: JSON.stringify({ name }),
});
// 201 = created, 409 = already exists — both are fine
if (res.status !== 201 && res.status !== 409) {
throw new Error(`Failed to ensure team "${name}": ${res.status}`);
}
}
base.describe("People Management — API", () => {
let token: string;
base.beforeAll(async () => {
token = await getAuthToken();
// Create teams used by the tests
await ensureTeam(token, "Engineering");
await ensureTeam(token, "Design");
});
base.beforeEach(async () => {
@@ -369,7 +385,8 @@ uiTest.describe("People Management — UI", () => {
await addBtn.click();
await expect(page.getByPlaceholder("Username")).toBeVisible();
await expect(page.getByPlaceholder("Password")).toBeVisible();
await expect(page.getByPlaceholder("Team")).toBeVisible();
// Team is a <select> dropdown, not a text input with placeholder
await expect(page.locator("select").first()).toBeVisible();
await expect(page.getByRole("button", { name: /create/i })).toBeVisible();
await expect(page.getByRole("button", { name: /cancel/i })).toBeVisible();
}