External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: make OCR portable and reliable across AMD64 and ARM64 (#519)

Browse Source 
* fix: make OCR portable and reliable

* fix: harden OCR installation portability

* fix: pin OCR partials across downloads

* fix: make OCR execution reliably asynchronous

* fix: harden OCR portability and docs routes

* fix: preserve decoder and docs safeguards
This commit is contained in:
SnapOtter
2026-07-15 03:34:24 +08:00
committed by GitHub
parent 58121f205f
commit 991c981529
409 changed files with 67151 additions and 8076 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/api/heic-converter.test.ts
+48 -1
View File
@@ -1,4 +1,3 @@
import { readFile } from "node:fs/promises";
import sharp from "sharp";
import { describe, expect, it } from "vitest";
import { decodeHeic, ensureSharpCompat } from "../../../apps/api/src/lib/heic-converter.js";
@@ -16,7 +15,55 @@ function makeHeicHeader(brand: string): Buffer {
return buf;
}
function makeIspeBox(width: number, height: number): Buffer {
const box = Buffer.alloc(20);
box.writeUInt32BE(20, 0);
box.write("ispe", 4, 4, "ascii");
box.writeUInt32BE(width, 12);
box.writeUInt32BE(height, 16);
return box;
}
describe("decodeHeic", () => {
it("rejects source dimensions over a caller-supplied pixel cap", async () => {
const heicBuf = readFixture(fixtures.image.formats("heic"));
await expect(decodeHeic(heicBuf, { maxPixels: 1 })).rejects.toThrow(/pixel safety limit/i);
});
it("checks every image extent instead of trusting a small first thumbnail", async () => {
const multiImage = Buffer.concat([
makeHeicHeader("heic"),
makeIspeBox(1, 1),
makeIspeBox(10_000, 10_000),
]);
await expect(decodeHeic(multiImage, { maxPixels: 40_000_000 })).rejects.toThrow(
/pixel safety limit/i,
);
});
it("rejects an extreme image side from encoded metadata before starting a decoder", async () => {
const extremeImage = Buffer.concat([
makeHeicHeader("heic"),
makeIspeBox(1_000, 1_000),
makeIspeBox(40_001, 1),
]);
await expect(
decodeHeic(extremeImage, { maxDimension: 40_000, maxPixels: 40_000_000 }),
).rejects.toThrow(/dimension safety limit.*40,001x1/i);
});
it("honors an already-aborted request", async () => {
const controller = new AbortController();
controller.abort();
await expect(
decodeHeic(readFixture(fixtures.image.formats("heic")), { signal: controller.signal }),
).rejects.toMatchObject({ name: "AbortError" });
});
it("decodes sample.heic to a valid PNG buffer", async () => {
const heicBuf = readFixture(fixtures.image.formats("heic"));
const result = await decodeHeic(heicBuf);