mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
feat(analytics): inject Sentry DSN + PostHog key from build env (#367)
* fix(analytics): bake real Sentry DSN and lower trace sampling The bake script emitted a placeholder Sentry DSN even in on mode, so every published image initialized Sentry against a dead endpoint and no events ever reached the project. Point it at the real snapotter project DSN. Also drop tracesSampleRate from 1 to 0.1. It governs only performance transactions (errors are always captured), so 100% fleet-wide tracing would drain Sentry quota for no benefit. * fix(analytics): point baked Sentry DSN at the snapotter org * refactor(analytics): inject Sentry DSN + PostHog key from build env #336 replaced the analytics creds with placeholders but never added a way to put real values back at build time, so any image built from the repo since then ships dead analytics (the live fleet only still reports because publishing is paused and it runs a pre-placeholder image). Restore the pipeline the clean way: bake-analytics.mjs reads SNAPOTTER_SENTRY_DSN and SNAPOTTER_POSTHOG_KEY from the environment; the official image's CI supplies them from repo secrets via build args. A build with neither stays disabled, so building from source never phones home. Both values are public (they ship in the browser bundle), so this is about not making source builds report, not secrecy. Supersedes the hardcoded DSN: real creds are no longer committed to the repo.
This commit is contained in:
@@ -239,6 +239,8 @@ jobs:
|
||||
platforms: ${{ matrix.platform }}
|
||||
build-args: |
|
||||
SNAPOTTER_ANALYTICS=on
|
||||
SNAPOTTER_POSTHOG_KEY=${{ secrets.SNAPOTTER_POSTHOG_KEY }}
|
||||
SNAPOTTER_SENTRY_DSN=${{ secrets.SNAPOTTER_SENTRY_DSN }}
|
||||
labels: ${{ steps.meta.outputs.labels }}
|
||||
outputs: type=image,"name=snapotter/snapotter,ghcr.io/snapotter-hq/snapotter",push-by-digest=true,name-canonical=true,push=true
|
||||
cache-from: type=registry,ref=ghcr.io/snapotter-hq/snapotter:cache-${{ env.PLATFORM_PAIR }}
|
||||
|
||||
Reference in New Issue
Block a user