mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
chore: remove dead code, add test infrastructure, update docs
- Delete 3 dead files: use-batch-processor.ts, use-i18n.ts, smart-crop.ts (AI package) - Remove dead getJobProgress function and unused runPythonScript wrapper - Remove 6 unused imports across API and web apps - Remove unused shared types (ImageFormat, AppConfig, ApiError, HealthResponse, JobProgress) and constants (SUPPORTED_INPUT_FORMATS/OUTPUT_FORMATS, DEFAULT_OUTPUT_FORMAT) - Remove unused store method (setOriginalBlobUrl) and clean AI package re-exports - Add test infrastructure: vitest config, unit/integration/e2e tests, fixtures, screenshots - Add Docker test infrastructure: Dockerfile.test, docker-compose.test.yml - Add download_models.py for pre-baking AI model weights in Docker - Add filename sanitization utility (apps/api/src/lib/filename.ts) - Update .gitignore to exclude coverage/, *.tsbuildinfo, .superpowers/, test artifacts - Update .dockerignore to exclude test/coverage/IDE artifacts from builds - Update docs: remove smart crop from AI docs (uses Sharp directly), update bridge docs
This commit is contained in:
@@ -0,0 +1,275 @@
|
||||
import { test, expect, uploadTestImage, waitForProcessing } from "./helpers";
|
||||
import path from "node:path";
|
||||
import fs from "node:fs";
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Full user session: simulates a real user uploading images, applying
|
||||
// different tools in sequence, and downloading results.
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
test.describe("Full user session", () => {
|
||||
test("upload -> resize -> download cycle", async ({ loggedInPage: page }) => {
|
||||
// Navigate to resize tool
|
||||
await page.goto("/resize");
|
||||
await expect(page.getByText("Resize").first()).toBeVisible();
|
||||
|
||||
// Upload test image
|
||||
await uploadTestImage(page);
|
||||
|
||||
// Verify the upload was accepted (dropzone is replaced by the viewer)
|
||||
await expect(page.getByText("Upload from computer")).not.toBeVisible();
|
||||
|
||||
// Set width to 200
|
||||
await page.locator("input[placeholder='Auto']").first().fill("200");
|
||||
|
||||
// Set height to 200
|
||||
await page.locator("input[placeholder='Auto']").nth(1).fill("200");
|
||||
|
||||
// Click resize button
|
||||
await page.getByRole("button", { name: "Resize" }).click();
|
||||
await waitForProcessing(page);
|
||||
|
||||
// Verify download button appears
|
||||
const downloadBtn = page
|
||||
.getByRole("link", { name: /download/i })
|
||||
.first();
|
||||
await expect(downloadBtn).toBeVisible({ timeout: 15_000 });
|
||||
|
||||
// Click download and verify a file is received
|
||||
const downloadPromise = page.waitForEvent("download");
|
||||
await downloadBtn.click();
|
||||
const download = await downloadPromise;
|
||||
|
||||
// Verify the download has a filename
|
||||
expect(download.suggestedFilename()).toBeTruthy();
|
||||
|
||||
// Save to disk and verify it is a non-empty file
|
||||
const downloadPath = path.join(
|
||||
process.cwd(),
|
||||
"test-results",
|
||||
"download-resize-result",
|
||||
);
|
||||
await download.saveAs(downloadPath);
|
||||
const stat = fs.statSync(downloadPath);
|
||||
expect(stat.size).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
test("upload -> rotate 90 -> download cycle", async ({
|
||||
loggedInPage: page,
|
||||
}) => {
|
||||
await page.goto("/rotate");
|
||||
await expect(page.getByText("Rotate").first()).toBeVisible();
|
||||
|
||||
await uploadTestImage(page);
|
||||
await expect(page.getByText("Upload from computer")).not.toBeVisible();
|
||||
|
||||
// Click 90-degree right rotation preset (the CW icon button)
|
||||
await page
|
||||
.locator("button")
|
||||
.filter({ hasText: /90.*right|right.*90|cw/i })
|
||||
.first()
|
||||
.click()
|
||||
.catch(async () => {
|
||||
// Fallback: click the second quick-rotate button (CW)
|
||||
await page.locator("aside button, [class*='panel'] button").nth(1).click();
|
||||
});
|
||||
|
||||
// Click the process button (button text is "Rotate")
|
||||
await page.getByRole("button", { name: "Rotate" }).click();
|
||||
await waitForProcessing(page);
|
||||
|
||||
// Verify result
|
||||
const downloadBtn = page
|
||||
.getByRole("link", { name: /download/i })
|
||||
.first();
|
||||
await expect(downloadBtn).toBeVisible({ timeout: 15_000 });
|
||||
|
||||
const downloadPromise = page.waitForEvent("download");
|
||||
await downloadBtn.click();
|
||||
const download = await downloadPromise;
|
||||
expect(download.suggestedFilename()).toBeTruthy();
|
||||
});
|
||||
|
||||
test("upload -> convert to JPEG -> download cycle", async ({
|
||||
loggedInPage: page,
|
||||
}) => {
|
||||
await page.goto("/convert");
|
||||
await expect(page.getByText("Convert").first()).toBeVisible();
|
||||
|
||||
await uploadTestImage(page);
|
||||
await expect(page.getByText("Upload from computer")).not.toBeVisible();
|
||||
|
||||
// The convert tool has a format selector - look for JPEG option
|
||||
// Try selecting JPEG from the format options
|
||||
const jpegOption = page.getByRole("button", { name: /jpeg|jpg/i }).first();
|
||||
if (await jpegOption.isVisible({ timeout: 2000 }).catch(() => false)) {
|
||||
await jpegOption.click();
|
||||
}
|
||||
// Otherwise the default format selection is fine
|
||||
|
||||
// Click convert button
|
||||
await page.getByRole("button", { name: /convert/i }).click();
|
||||
await waitForProcessing(page);
|
||||
|
||||
// Verify download
|
||||
const downloadBtn = page
|
||||
.getByRole("link", { name: /download/i })
|
||||
.first();
|
||||
await expect(downloadBtn).toBeVisible({ timeout: 15_000 });
|
||||
|
||||
const downloadPromise = page.waitForEvent("download");
|
||||
await downloadBtn.click();
|
||||
const download = await downloadPromise;
|
||||
expect(download.suggestedFilename()).toBeTruthy();
|
||||
});
|
||||
|
||||
test("upload -> crop -> download cycle", async ({ loggedInPage: page }) => {
|
||||
await page.goto("/crop");
|
||||
await expect(page.getByText("Crop").first()).toBeVisible();
|
||||
|
||||
await uploadTestImage(page);
|
||||
await expect(page.getByText("Upload from computer")).not.toBeVisible();
|
||||
|
||||
// Set crop dimensions via number inputs
|
||||
// Crop component has: left, top, width, height inputs
|
||||
const numberInputs = page.locator("input[type='number']");
|
||||
const count = await numberInputs.count();
|
||||
if (count >= 4) {
|
||||
// Ensure width and height are set (indices 2 and 3)
|
||||
await numberInputs.nth(2).fill("50");
|
||||
await numberInputs.nth(3).fill("50");
|
||||
} else if (count >= 2) {
|
||||
// If fewer inputs, fill the first two
|
||||
await numberInputs.nth(0).fill("50");
|
||||
await numberInputs.nth(1).fill("50");
|
||||
}
|
||||
|
||||
// Click crop button
|
||||
await page.locator("button[type='submit']").click();
|
||||
await waitForProcessing(page);
|
||||
|
||||
// Verify download
|
||||
const downloadBtn = page
|
||||
.getByRole("link", { name: /download/i })
|
||||
.first();
|
||||
await expect(downloadBtn).toBeVisible({ timeout: 15_000 });
|
||||
|
||||
const downloadPromise = page.waitForEvent("download");
|
||||
await downloadBtn.click();
|
||||
const download = await downloadPromise;
|
||||
expect(download.suggestedFilename()).toBeTruthy();
|
||||
});
|
||||
|
||||
test("upload -> compress -> download cycle", async ({
|
||||
loggedInPage: page,
|
||||
}) => {
|
||||
await page.goto("/compress");
|
||||
await expect(page.getByText("Compress").first()).toBeVisible();
|
||||
|
||||
await uploadTestImage(page);
|
||||
await expect(page.getByText("Upload from computer")).not.toBeVisible();
|
||||
|
||||
// Compress has sensible defaults, just click process
|
||||
await page.getByRole("button", { name: "Compress" }).click();
|
||||
await waitForProcessing(page);
|
||||
|
||||
const downloadBtn = page
|
||||
.getByRole("link", { name: /download/i })
|
||||
.first();
|
||||
await expect(downloadBtn).toBeVisible({ timeout: 15_000 });
|
||||
|
||||
const downloadPromise = page.waitForEvent("download");
|
||||
await downloadBtn.click();
|
||||
const download = await downloadPromise;
|
||||
expect(download.suggestedFilename()).toBeTruthy();
|
||||
|
||||
// Save and verify the downloaded file is a valid non-empty image
|
||||
const downloadPath = path.join(
|
||||
process.cwd(),
|
||||
"test-results",
|
||||
"download-compress-result",
|
||||
);
|
||||
await download.saveAs(downloadPath);
|
||||
const stat = fs.statSync(downloadPath);
|
||||
expect(stat.size).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
test("multi-tool session: resize then compress", async ({
|
||||
loggedInPage: page,
|
||||
}) => {
|
||||
// Step 1: Resize
|
||||
await page.goto("/resize");
|
||||
await uploadTestImage(page);
|
||||
await page.locator("input[placeholder='Auto']").first().fill("200");
|
||||
await page.getByRole("button", { name: "Resize" }).click();
|
||||
await waitForProcessing(page);
|
||||
|
||||
const resizeDownloadBtn = page
|
||||
.getByRole("link", { name: /download/i })
|
||||
.first();
|
||||
await expect(resizeDownloadBtn).toBeVisible({ timeout: 15_000 });
|
||||
|
||||
// Step 2: Navigate to compress and process a new image
|
||||
await page.goto("/compress");
|
||||
await uploadTestImage(page);
|
||||
await page.getByRole("button", { name: "Compress" }).click();
|
||||
await waitForProcessing(page);
|
||||
|
||||
const compressDownloadBtn = page
|
||||
.getByRole("link", { name: /download/i })
|
||||
.first();
|
||||
await expect(compressDownloadBtn).toBeVisible({ timeout: 15_000 });
|
||||
});
|
||||
|
||||
test("upload file then navigate away and back retains tool state", async ({
|
||||
loggedInPage: page,
|
||||
}) => {
|
||||
// Go to resize, upload, configure
|
||||
await page.goto("/resize");
|
||||
await uploadTestImage(page);
|
||||
await page.locator("input[placeholder='Auto']").first().fill("300");
|
||||
|
||||
// Navigate away to home
|
||||
await page.goto("/");
|
||||
await expect(page.getByText("Upload from computer")).toBeVisible();
|
||||
|
||||
// Navigate back to resize - the tool should reset (fresh state)
|
||||
await page.goto("/resize");
|
||||
await expect(page.getByText("Upload from computer")).toBeVisible();
|
||||
});
|
||||
|
||||
test("download button triggers actual file download", async ({
|
||||
loggedInPage: page,
|
||||
}) => {
|
||||
await page.goto("/strip-metadata");
|
||||
await uploadTestImage(page);
|
||||
|
||||
await page.getByRole("button", { name: /strip metadata/i }).click();
|
||||
await waitForProcessing(page);
|
||||
|
||||
const downloadBtn = page
|
||||
.getByRole("link", { name: /download/i })
|
||||
.first();
|
||||
await expect(downloadBtn).toBeVisible({ timeout: 15_000 });
|
||||
|
||||
// Intercept the download event
|
||||
const downloadPromise = page.waitForEvent("download");
|
||||
await downloadBtn.click();
|
||||
const download = await downloadPromise;
|
||||
|
||||
// Verify download properties
|
||||
const filename = download.suggestedFilename();
|
||||
expect(filename).toBeTruthy();
|
||||
expect(filename.length).toBeGreaterThan(0);
|
||||
|
||||
// Save and confirm it wrote bytes
|
||||
const savePath = path.join(
|
||||
process.cwd(),
|
||||
"test-results",
|
||||
"download-strip-metadata-result",
|
||||
);
|
||||
await download.saveAs(savePath);
|
||||
const stat = fs.statSync(savePath);
|
||||
expect(stat.size).toBeGreaterThan(0);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user