External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: repair 6 failing E2E tests (load test image, fix selectors, verify DOM state)

Browse Source 
- Add loadTestImage helper using Playwright route interception to serve
  a fixture image via /editor?url= query parameter
- Filter/adjustment tests now load a real source image instead of drawing
  brush strokes (adjustments only apply to source images, not drawn objects)
- Blur/sharpen tests verify DOM state (checkbox checked, parameter input
  accepts and persists values) instead of fragile canvas pixel comparison
- Selection options test uses getByRole with waitForTimeout for robustness
This commit is contained in:
SnapOtter
2026-05-08 17:16:14 +08:00
parent dd73a8a50a
commit 6c56950f39
3 changed files with 75 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e-editor/editor-options-bar.spec.ts
+13 -17
View File
@@ -80,30 +80,26 @@ test.describe("Editor Options Bar", () => {
test("selection options show mode dropdown", async ({ editorPage: page }) => {
await selectTool(page, "marquee-rect");
await page.waitForTimeout(500);
// The options bar should show Type and Mode sections
await expect(page.getByText("Type:")).toBeVisible();
await expect(page.getByText("Mode:")).toBeVisible();
// Type buttons: Rect, Ellipse, Lasso
const rectBtn = page.locator("button[aria-label='Rectangular']");
const ellipseBtn = page.locator("button[aria-label='Elliptical']");
const lassoBtn = page.locator("button[aria-label='Lasso']");
// Type buttons: Rect, Ellipse, Lasso (use getByRole for robust matching)
await expect(page.getByRole("button", { name: "Rectangular" })).toBeVisible();
await expect(page.getByRole("button", { name: "Elliptical" })).toBeVisible();
await expect(page.getByRole("button", { name: "Lasso" }).first()).toBeVisible();
await expect(rectBtn).toBeVisible();
await expect(ellipseBtn).toBeVisible();
await expect(lassoBtn).toBeVisible();
// Rect should be active (pressed) since we selected marquee-rect
await expect(rectBtn).toHaveAttribute("aria-pressed", "true");
// Rect should be active since we selected marquee-rect
await expect(page.getByRole("button", { name: "Rectangular" })).toHaveAttribute(
"aria-pressed",
"true",
);
// Mode buttons: New, Add, Sub
const newBtn = page.locator("button[aria-label='New Selection']");
const addBtn = page.locator("button[aria-label='Add to Selection']");
const subBtn = page.locator("button[aria-label='Subtract from Selection']");
await expect(newBtn).toBeVisible();
await expect(addBtn).toBeVisible();
await expect(subBtn).toBeVisible();
await expect(page.getByRole("button", { name: "New Selection" })).toBeVisible();
await expect(page.getByRole("button", { name: "Add to Selection" })).toBeVisible();
await expect(page.getByRole("button", { name: "Subtract from Selection" })).toBeVisible();
});
});