External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: pre-decode HEIC/HEIF in info tool to prevent stats failure

Browse Source 
Sharp can read HEIF container headers (metadata succeeds) but cannot
decode HEVC pixels (stats fails with "No decoding plugin installed").
Unconditionally pre-decode HEIF files via heif-dec CLI before any Sharp
operations, matching the createToolRoute factory behavior.
This commit is contained in:
SnapOtter
2026-05-18 14:44:21 +08:00
parent 475af753bf
commit 697566d00e
1 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/api/src/routes/tools/info.ts
+15 -14
View File
@@ -50,23 +50,24 @@ export function registerInfo(app: FastifyInstance) {
const validation = await validateImageBuffer(fileBuffer, filename);
const detectedFormat = validation.valid ? validation.format : null;
// For metadata reading, try Sharp on the raw buffer first -- it handles
// TIFF-based formats (DNG, CR2, NEF) without needing a full decode via
// ImageMagick/darktable. Only fall back to the decode pipeline for
// formats Sharp can't open at all (PSD, ICO, TGA, etc.).
// Pre-decode formats Sharp can't fully handle (needs pixel decoding for stats).
// HEIC/HEIF: Sharp can read container headers but can't decode HEVC pixels,
// so unconditionally pre-decode to PNG (matching createToolRoute behavior).
let metaBuffer = fileBuffer;
const ext = filename.split(".").pop()?.toLowerCase();
let sharpDirectFailed = false;
try {
await sharp(fileBuffer).metadata();
} catch {
sharpDirectFailed = true;
}
if (sharpDirectFailed) {
if (detectedFormat && needsCliDecode(detectedFormat)) {
metaBuffer = await decodeToSharpCompat(fileBuffer, detectedFormat, ext);
} else {
if (detectedFormat === "heif") {
metaBuffer = await decodeHeic(fileBuffer);
} else if (detectedFormat && needsCliDecode(detectedFormat)) {
metaBuffer = await decodeToSharpCompat(fileBuffer, detectedFormat, ext);
} else {
let sharpDirectFailed = false;
try {
await sharp(fileBuffer).metadata();
} catch {
sharpDirectFailed = true;
}
if (sharpDirectFailed) {
metaBuffer = await decodeHeic(fileBuffer);
}
}