fix(test): repair integration suite after analytics column/endpoint removal (#340)

* fix(test): repair integration suite after analytics column/endpoint removal

#336 moved analytics to a build-time bake: migration 0005 dropped the
users.analytics_enabled and analytics_consent_* columns and removed the
PUT /api/v1/user/analytics endpoint. Two integration tests were left
referencing the old shape and went red on main (13 failures):

- migrate-from-sqlite.test.ts built 1.x SQLite fixtures whose users table
  declared the analytics columns. The generic SELECT *-based importer then
  tried to INSERT them into the 2.0 target, which no longer has those
  columns, failing with Postgres 42703 and rolling back the whole import
  (cascading to all 12 assertions). 1.x never had analytics columns, so the
  fixtures are corrected to drop them. Also removed the now-dead analytics
  entries from the importer's TS/BOOL conversion sets.

- analytics.test.ts asserted the removed PUT endpoint returns 404 but sent
  the request unauthenticated, so the global auth preHandler answered 401
  first. It now authenticates, reaching Fastify's not-found handler (404).

Also removed the stale /api/v1/user/analytics path from openapi.yaml.

Verified locally: full platform integration bucket 1029 passed / 0 failed;
monorepo typecheck clean.

* test(e2e): drop orphaned analytics-consent dismissal calls

#336 deleted the entire analytics consent system (consent page, consent
module, and PUT /api/v1/user/analytics), but six tests/e2e files still
PUT to that removed endpoint to 'dismiss analytics consent.' The calls
were silent no-ops (Playwright request.put / fetch don't throw on 4xx),
so they passed while hitting a dead route.

There is no consent prompt to dismiss anymore, so remove the calls:
- auth.setup.ts / qa-auth.setup.ts: keep the waitForFunction that syncs on
  login completion, drop the now-unused token capture, the dead PUT, and
  the stale 'consent guard' comments.
- rbac / rbac-full / gui-settings-rbac / gui-settings-expanded specs: the
  re-login blocks existed solely to obtain a token for the PUT (reLoginData
  was used nowhere else and the block was the tail of each helper), so
  remove the whole block. The meaningful create-user/login/change-password
  work is untouched.

Verified: no /api/v1/user/analytics refs remain in tests/e2e; biome clean
(no unused vars).
This commit is contained in:
SnapOtter
2026-06-24 13:30:18 +08:00
committed by GitHub
parent 5dac40d782
commit 6917a8b0c7
10 changed files with 28 additions and 172 deletions
+2 -10
View File
@@ -8,17 +8,9 @@ export interface MigrationResult {
}
// columns storing epoch-seconds integers in 1.x
const TS = new Set([
"created_at",
"updated_at",
"expires_at",
"completed_at",
"last_used_at",
"analytics_consent_shown_at",
"analytics_consent_remind_at",
]);
const TS = new Set(["created_at", "updated_at", "expires_at", "completed_at", "last_used_at"]);
// columns storing 0/1 booleans in 1.x
const BOOL = new Set(["must_change_password", "analytics_enabled", "is_builtin"]);
const BOOL = new Set(["must_change_password", "is_builtin"]);
// per-table columns whose values must be cast to jsonb in the INSERT
const JSONB: Record<string, Set<string>> = {
jobs: new Set(["settings", "input_refs", "output_refs", "progress", "error"]),
-43
View File
@@ -6440,49 +6440,6 @@ paths:
instanceId:
type: string
/api/v1/user/analytics:
put:
operationId: updateAnalyticsConsent
tags: [Analytics]
summary: Update user analytics consent
description: |
Set the authenticated user's analytics consent preference, or snooze
the consent prompt for 7 days with remindLater.
security:
- bearerAuth: []
requestBody:
required: true
content:
application/json:
schema:
type: object
properties:
enabled:
type: boolean
description: Whether the user consents to analytics
remindLater:
type: boolean
description: Snooze the consent prompt for 7 days
responses:
"200":
description: Consent updated
content:
application/json:
schema:
type: object
properties:
ok:
type: boolean
analyticsEnabled:
type: boolean
nullable: true
"401":
description: Authentication required
content:
application/json:
schema:
$ref: "#/components/schemas/UnauthorizedError"
# ─── Features ────────────────────────────────────────────────────────────
/api/v1/features: