fix: resolve 20 Sentry issues and fix navbar test flakiness

Sentry fixes:
- Only send 5xx errors to Sentry (was sending 4xx rate-limit, media type errors)
- Encode non-ASCII chars in X-Output-Filename header (encodeURIComponent)
- Handle FK constraint failures gracefully in file upload, pipeline save, API keys
- Harden getDirSize against ENOENT race on readdirSync

Test fixes:
- Wrap navbar test renders in act() to flush async useEffect state updates
- Add useEffect cleanup to navbar to prevent state updates on unmounted component
- Fixes timeout when running in full test suite
This commit is contained in:
SnapOtter
2026-05-01 19:01:05 +08:00
parent ff8dcf63c7
commit 66211ed6a7
9 changed files with 128 additions and 87 deletions
+45 -32
View File
@@ -1,6 +1,6 @@
// @vitest-environment jsdom
import { cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
import { act, cleanup, fireEvent, render, screen } from "@testing-library/react";
import type React from "react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
@@ -28,69 +28,78 @@ beforeEach(() => {
afterEach(cleanup);
describe("Navbar", () => {
it("renders the brand name", () => {
render(<Navbar />);
it("renders the brand name", async () => {
await act(async () => {
render(<Navbar />);
});
expect(screen.getByText("SnapOtter")).toBeDefined();
});
it("renders navigation links", () => {
render(<Navbar />);
it("renders navigation links", async () => {
await act(async () => {
render(<Navbar />);
});
expect(screen.getAllByText("Features").length).toBeGreaterThan(0);
expect(screen.getAllByText("Pricing").length).toBeGreaterThan(0);
expect(screen.getAllByText("Docs").length).toBeGreaterThan(0);
expect(screen.getAllByText("Contact").length).toBeGreaterThan(0);
});
it("renders Book a Demo CTA", () => {
render(<Navbar />);
it("renders Book a Demo CTA", async () => {
await act(async () => {
render(<Navbar />);
});
const ctas = screen.getAllByText("Book a Demo");
expect(ctas.length).toBeGreaterThan(0);
});
it("fetches GitHub star count on mount", async () => {
render(<Navbar />);
await waitFor(() => {
expect(fetchMock).toHaveBeenCalledWith("https://api.github.com/repos/snapotter-hq/snapotter");
await act(async () => {
render(<Navbar />);
});
expect(fetchMock).toHaveBeenCalledWith("https://api.github.com/repos/snapotter-hq/snapotter");
});
it("displays formatted star count after fetch", async () => {
render(<Navbar />);
await waitFor(() => {
expect(screen.getByText("1.2k")).toBeDefined();
await act(async () => {
render(<Navbar />);
});
expect(screen.getByText("1.2k")).toBeDefined();
});
it("formats star count correctly for exact thousands", async () => {
fetchMock.mockResolvedValue({
json: () => Promise.resolve({ stargazers_count: 2000 }),
});
render(<Navbar />);
await waitFor(() => {
expect(screen.getByText("2k")).toBeDefined();
await act(async () => {
render(<Navbar />);
});
expect(screen.getByText("2k")).toBeDefined();
});
it("shows raw count for numbers under 1000", async () => {
fetchMock.mockResolvedValue({
json: () => Promise.resolve({ stargazers_count: 456 }),
});
render(<Navbar />);
await waitFor(() => {
expect(screen.getByText("456")).toBeDefined();
await act(async () => {
render(<Navbar />);
});
expect(screen.getByText("456")).toBeDefined();
});
it("handles star fetch failure gracefully", async () => {
fetchMock.mockRejectedValue(new Error("Network error"));
render(<Navbar />);
await waitFor(() => expect(fetchMock).toHaveBeenCalled());
// Star count should not appear - still shows default "Star" text
await act(async () => {
render(<Navbar />);
});
expect(fetchMock).toHaveBeenCalled();
expect(screen.getAllByText("Star on GitHub").length).toBeGreaterThan(0);
});
it("toggles mobile menu on hamburger click", () => {
render(<Navbar />);
it("toggles mobile menu on hamburger click", async () => {
await act(async () => {
render(<Navbar />);
});
const toggleButton = screen.getByLabelText("Toggle menu");
expect(screen.queryByText("Book a Demo")).toBeDefined();
fireEvent.click(toggleButton);
@@ -98,17 +107,19 @@ describe("Navbar", () => {
expect(mobileLinks.length).toBeGreaterThanOrEqual(2);
});
it("closes mobile menu when a link is clicked", () => {
render(<Navbar />);
it("closes mobile menu when a link is clicked", async () => {
await act(async () => {
render(<Navbar />);
});
fireEvent.click(screen.getByLabelText("Toggle menu"));
const mobileFeatures = screen.getAllByText("Features");
fireEvent.click(mobileFeatures[mobileFeatures.length - 1]);
// After clicking, mobile menu should close (we can't easily test DOM removal
// without checking state, but the onClick handler calls setOpen(false))
});
it("links Docs to external URL with target=_blank", () => {
render(<Navbar />);
it("links Docs to external URL with target=_blank", async () => {
await act(async () => {
render(<Navbar />);
});
const docsLinks = screen.getAllByText("Docs");
const externalDoc = docsLinks.find(
(el) => el.closest("a")?.getAttribute("target") === "_blank",
@@ -117,8 +128,10 @@ describe("Navbar", () => {
expect(externalDoc?.closest("a")?.getAttribute("href")).toBe("https://docs.snapotter.com");
});
it("links GitHub button to correct repo", () => {
render(<Navbar />);
it("links GitHub button to correct repo", async () => {
await act(async () => {
render(<Navbar />);
});
const githubLinks = screen.getAllByText("Star on GitHub");
const link = githubLinks[0].closest("a");
expect(link?.getAttribute("href")).toBe("https://github.com/snapotter-hq/snapotter");