External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: disable worker pool to prevent Docker processing hang

Browse Source 
Worker thread initialization imports the tool registry which reads SQLite.
Under Docker volume filesystems, this can deadlock silently on SQLITE_BUSY,
causing APPLY to spin at 0% forever. Sharp operations complete in milliseconds
and don't need worker offloading. Added 30s AbortSignal timeout as defense
in depth for future re-enablement.
This commit is contained in:
Siddharth Kumar Sah
2026-04-04 14:05:11 +08:00
parent 9f2dc00ec8
commit 5cd2b864bd
1 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/api/src/routes/tool-factory.ts
+15 -11
View File
@@ -44,15 +44,17 @@ export interface AnyToolRouteConfig {
*/ */
const toolRegistry = new Map<string, AnyToolRouteConfig>(); const toolRegistry = new Map<string, AnyToolRouteConfig>();
/** Tools that use the Python bridge and should NOT be offloaded to workers. */ /**
const SKIP_WORKER_TOOLS = new Set([ * Worker threads are disabled for all tools.
"remove-background", *
"upscale", * AI tools skip workers because they use the Python bridge.
"ocr", * Sharp-based tools skip workers because they complete in milliseconds
"blur-faces", * and the worker initialization (which imports the full tool registry
"erase-object", * and reads SQLite) can deadlock under Docker volume filesystems.
"smart-crop", *
]); * The Piscina pool is kept in the codebase for potential future use
* with long-running CPU-bound operations.
*/
/** /**
* Retrieve a registered tool config by its ID. * Retrieve a registered tool config by its ID.
@@ -183,7 +185,7 @@ export function createToolRoute<T>(app: FastifyInstance, config: ToolRouteConfig
// Offload to worker thread for non-AI tools. // Offload to worker thread for non-AI tools.
// Falls back to main-thread processing on any worker error. // Falls back to main-thread processing on any worker error.
// Disabled in test environments where worker_threads can't load .ts files. // Disabled in test environments where worker_threads can't load .ts files.
const useWorker = !SKIP_WORKER_TOOLS.has(config.toolId) && process.env.NODE_ENV !== "test"; const useWorker = false;
if (useWorker) { if (useWorker) {
try { try {
const pool = getWorkerPool(); const pool = getWorkerPool();
@@ -194,7 +196,9 @@ export function createToolRoute<T>(app: FastifyInstance, config: ToolRouteConfig
filename, filename,
inputFormat: validation.format, inputFormat: validation.format,
}; };
const workerResult: WorkerOutput = await pool.run(workerInput); const workerResult: WorkerOutput = await pool.run(workerInput, {
signal: AbortSignal.timeout(30_000),
});
result = { result = {
buffer: Buffer.from(workerResult.buffer), buffer: Buffer.from(workerResult.buffer),
filename: workerResult.filename, filename: workerResult.filename,