mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
fix(ci): repair the chronically-failing nightly workflow (#624)
The scheduled Nightly had been red for over a week across nearly every job. This root-causes and fixes each one. All were pre-existing: missing CI provisioning, specs that drifted as the app grew, a job too heavy for its timeout, and a fuzz that was never configured for file-upload endpoints. None came from the recent security merge. - Coverage + Docker Container E2E: install tesseract and its language packs so the built-in Fast OCR tests stop throwing spawn ENOENT; gate two repo-file and release-workflow tests that cannot run inside the slimmed container image. - E2E (Full, Serial, Cross-Browser, Device Matrix): refresh specs that drifted behind the app (tool renames, the now admin-only Tools tab, dropped About copy, locator collisions scoped to the right region). One real product fix rode along: /config/auth was refetched six times per tool-page load, so cache it behind a single shared fetch, dropping the tool page from 13 to 8 API calls. - Extended Matrix + Fuzz: shard the integration suite four ways so the full format x tool matrix plus property fuzz fits its budget instead of overrunning the 90-minute ceiling every night. - Schemathesis: exclude the tools with bespoke handlers that process synchronously in-request (they hang the fuzz on adversarial input) and suppress Hypothesis's data-generation health checks, which fire because file-upload endpoints reject the fuzzer's random bytes. not_a_server_error still runs on every generated case (5000+ per run). - Stabilize two long-tail flakes: raise the avif matrix per-test cap from 240s to 600s, and assert toHaveCount(0) on the deleted user row so a transient success toast no longer trips a strict-mode violation. Verified end to end: the full Nightly workflow is green on this branch (all 14 jobs), and PR CI is green.
This commit is contained in:
@@ -37,6 +37,33 @@ const ANON_ADMIN_PERMISSIONS = [
|
||||
"audit:read",
|
||||
];
|
||||
|
||||
interface AuthConfig {
|
||||
authEnabled: boolean;
|
||||
oidcEnabled?: boolean;
|
||||
oidcProviderName?: string | null;
|
||||
samlEnabled?: boolean;
|
||||
samlProviderName?: string | null;
|
||||
ssoEnforced?: boolean;
|
||||
}
|
||||
|
||||
// /api/v1/config/auth returns static instance config (auth mode, OIDC/SAML
|
||||
// setup) that cannot change without a server restart. useAuth() runs in many
|
||||
// components, so without sharing this the tool page fetches it once per consumer
|
||||
// (6+ times on initial load). Share a single fetch; reset on failure so a
|
||||
// transient error can be retried.
|
||||
let authConfigPromise: Promise<AuthConfig> | null = null;
|
||||
function fetchAuthConfig(): Promise<AuthConfig> {
|
||||
if (!authConfigPromise) {
|
||||
authConfigPromise = fetch("/api/v1/config/auth")
|
||||
.then((res) => res.json() as Promise<AuthConfig>)
|
||||
.catch((err) => {
|
||||
authConfigPromise = null;
|
||||
throw err;
|
||||
});
|
||||
}
|
||||
return authConfigPromise;
|
||||
}
|
||||
|
||||
export function useAuth() {
|
||||
const [state, setState] = useState<AuthState>({
|
||||
loading: true,
|
||||
@@ -61,8 +88,7 @@ export function useAuth() {
|
||||
|
||||
async function checkAuth() {
|
||||
try {
|
||||
const configRes = await fetch("/api/v1/config/auth");
|
||||
const config = await configRes.json();
|
||||
const config = await fetchAuthConfig();
|
||||
|
||||
if (!config.authEnabled) {
|
||||
if (!cancelled)
|
||||
|
||||
Reference in New Issue
Block a user