feat: add FEATURE_NOT_INSTALLED guards to API tool routes

Return 501 with structured error when an AI tool's feature bundle
is not installed, preventing Python ImportError crashes. Guards
added to tool-factory, batch, pipeline (both validation loops),
and restore-photo custom route.
This commit is contained in:
ashim-hq
2026-04-18 02:40:16 +08:00
parent 7ffbd5e3c6
commit 3c3aa74e98
4 changed files with 67 additions and 0 deletions
+24
View File
@@ -9,6 +9,7 @@
import { randomUUID } from "node:crypto";
import { writeFile } from "node:fs/promises";
import { join } from "node:path";
import { getBundleForTool, TOOL_BUNDLE_MAP } from "@ashim/shared";
import archiver from "archiver";
import { eq } from "drizzle-orm";
import type { FastifyInstance, FastifyReply, FastifyRequest } from "fastify";
@@ -18,6 +19,7 @@ import { env } from "../config.js";
import { db, schema } from "../db/index.js";
import { autoOrient } from "../lib/auto-orient.js";
import { formatZodErrors } from "../lib/errors.js";
import { isToolInstalled } from "../lib/feature-status.js";
import { validateImageBuffer } from "../lib/file-validation.js";
import { sanitizeFilename } from "../lib/filename.js";
import { decodeHeic } from "../lib/heic-converter.js";
@@ -156,6 +158,17 @@ export async function registerPipelineRoutes(app: FastifyInstance): Promise<void
});
}
// Guard: check if the tool's AI feature bundle is installed
if (!isToolInstalled(resolvedToolId)) {
const bundle = getBundleForTool(resolvedToolId);
return reply.status(501).send({
error: `Step ${i + 1} (${step.toolId}): Feature "${bundle?.name}" is not installed`,
code: "FEATURE_NOT_INSTALLED",
feature: TOOL_BUNDLE_MAP[resolvedToolId],
featureName: bundle?.name ?? resolvedToolId,
});
}
// Validate the settings for this tool
const settingsResult = toolConfig.settingsSchema.safeParse(step.settings);
if (!settingsResult.success) {
@@ -447,6 +460,17 @@ export async function registerPipelineRoutes(app: FastifyInstance): Promise<void
});
}
// Guard: check if the tool's AI feature bundle is installed
if (!isToolInstalled(step.toolId)) {
const bundle = getBundleForTool(step.toolId);
return reply.status(501).send({
error: `Step ${i + 1} (${step.toolId}): Feature "${bundle?.name}" is not installed`,
code: "FEATURE_NOT_INSTALLED",
feature: TOOL_BUNDLE_MAP[step.toolId],
featureName: bundle?.name ?? step.toolId,
});
}
const settingsResult = toolConfig.settingsSchema.safeParse(step.settings);
if (!settingsResult.success) {
return reply.status(400).send({