mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
fix(image): image-to-pdf presets no longer 404 on 2+ files (#633)
jpg-to-pdf and its six image-to-pdf-group siblings share the base tool's registerImageToPdfRoute, which never registers into the toolRegistry the generic /batch endpoint reads from. The shared conversion-preset settings component routed any 2+-file submission to /batch regardless of tool, so these presets 404'd with `Tool "<id>" not found` past the first file, while the base image-to-pdf tool stayed unaffected because it bypasses that dispatch entirely with its own settings component. MULTI_FILE_TOOLS now includes every image-to-pdf-group preset, derived from BASE_CONFIG instead of hardcoded, and the preset settings component checks that set before choosing batch vs. a single combined request. Fixes #627
This commit is contained in:
@@ -0,0 +1,23 @@
|
||||
import { BASE_CONFIG, CONVERSION_PRESETS } from "@snapotter/shared";
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { MULTI_FILE_TOOLS } from "@/lib/tool-display-modes";
|
||||
|
||||
/**
|
||||
* Issue #627: image-to-pdf-group presets (jpg-to-pdf, png-to-pdf, ...) combine
|
||||
* every uploaded file into one PDF via their own multi-file route, the same
|
||||
* as the base image-to-pdf tool. They must stay off the generic per-file
|
||||
* batch path, which never registers them (registerImageToPdfRoute bypasses
|
||||
* the createToolRoute/registerToolProcessFn registry the batch route depends
|
||||
* on) and 404s with `Tool "<id>" not found` if reached with 2+ files.
|
||||
*/
|
||||
describe("MULTI_FILE_TOOLS drift (issue #627)", () => {
|
||||
it("includes every conversion preset whose base combines inputs into one request", () => {
|
||||
for (const preset of CONVERSION_PRESETS) {
|
||||
if (BASE_CONFIG[preset.base].group !== "image-to-pdf") continue;
|
||||
expect(
|
||||
MULTI_FILE_TOOLS.has(preset.id),
|
||||
`preset "${preset.id}" (base "${preset.base}") combines inputs but is missing from MULTI_FILE_TOOLS`,
|
||||
).toBe(true);
|
||||
}
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user