External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(image): image-to-pdf presets no longer 404 on 2+ files (#633)

Browse Source 
jpg-to-pdf and its six image-to-pdf-group siblings share the base tool's
registerImageToPdfRoute, which never registers into the toolRegistry the
generic /batch endpoint reads from. The shared conversion-preset settings
component routed any 2+-file submission to /batch regardless of tool, so
these presets 404'd with `Tool "<id>" not found` past the first file, while
the base image-to-pdf tool stayed unaffected because it bypasses that
dispatch entirely with its own settings component.

MULTI_FILE_TOOLS now includes every image-to-pdf-group preset, derived from
BASE_CONFIG instead of hardcoded, and the preset settings component checks
that set before choosing batch vs. a single combined request.

Fixes #627
This commit is contained in:
SnapOtter
2026-07-25 09:18:18 +08:00
committed by GitHub
parent e0a7aecde8
commit 330cf559e0
5 changed files with 271 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/src/components/tools/conversion-preset-settings.tsx
+9 -2
View File
@@ -6,6 +6,7 @@ import { ProgressCard } from "@/components/common/progress-card";
import { useTranslation } from "@/contexts/i18n-context";
import { useToolProcessor } from "@/hooks/use-tool-processor";
import { format } from "@/lib/format";
import { MULTI_FILE_TOOLS } from "@/lib/tool-display-modes";
import { useFileStore } from "@/stores/file-store";
/** Target formats that honor a quality knob (lossy raster encodings). */
@@ -46,8 +47,14 @@ export function ConversionPresetSettings() {
const handleProcess = () => {
const settings = buildSettings();
if (files.length > 1) processAllFiles(files, settings);
else processFiles(files, settings);
// image-to-pdf-group presets combine every file into one request (same as
// the base tool), so they must skip the generic per-file /batch endpoint
// that MULTI_FILE_TOOLS-gated tools never register into (issue #627).
if (MULTI_FILE_TOOLS.has(toolId) || files.length <= 1) {
processFiles(files, settings);
} else {
processAllFiles(files, settings);
}
};
const handleSubmit = (e: React.FormEvent) => {
apps/web/src/lib/tool-display-modes.ts
+14 -2
View File
@@ -227,9 +227,15 @@ for (const preset of CONVERSION_PRESETS) {
/**
* Tools whose selected files all post in ONE request as repeated "file" parts.
* Consumed by use-tool-processor; backend routes declare maxInputs.
* Consumed by use-tool-processor and ConversionPresetSettings; backend routes
* declare maxInputs, or (image-to-pdf group) loop over every uploaded file
* with no cap. Conversion presets built on a combining base are added below
* from BASE_CONFIG so a future image-to-pdf-group preset can't drift out of
* sync the way jpg-to-pdf did (issue #627): registerImageToPdfRoute never
* registers into the createToolRoute/registerToolProcessFn registry that the
* generic per-file /batch route depends on, so those tools 404 there.
*/
export const MULTI_FILE_TOOLS: ReadonlySet<string> = new Set([
const multiFileTools = new Set<string>([
"create-zip",
"merge-audio",
"merge-csvs",
@@ -241,3 +247,9 @@ export const MULTI_FILE_TOOLS: ReadonlySet<string> = new Set([
"images-to-video",
"sprite-sheet",
]);
for (const preset of CONVERSION_PRESETS) {
if (BASE_CONFIG[preset.base].group === "image-to-pdf") {
multiFileTools.add(preset.id);
}
}
export const MULTI_FILE_TOOLS: ReadonlySet<string> = multiFileTools;