test(fixtures): address review nits (drop dead param, exclude .mjs from budget scan)

This commit is contained in:
SnapOtter
2026-06-19 20:44:35 +08:00
parent 427c543b72
commit 1aa3f8e48f
3 changed files with 6 additions and 7 deletions
+2 -4
View File
@@ -11269,7 +11269,6 @@
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.tga", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.tga",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.tiff", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.tiff",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.webp", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.webp",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/gen-manifest.mjs",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/bomb-50000x50000.png", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/bomb-50000x50000.png",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/garbage.jpg", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/garbage.jpg",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/garbage.pdf", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/garbage.pdf",
@@ -24413,7 +24412,6 @@
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.tga", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.tga",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.tiff", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.tiff",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.webp", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/formats/sample.webp",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/gen-manifest.mjs",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/bomb-50000x50000.png", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/bomb-50000x50000.png",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/garbage.jpg", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/garbage.jpg",
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/garbage.pdf", "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/fixtures/fixture-budget.test.ts > fixture size budget within budget: /Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/fixtures/hostile/garbage.pdf",
@@ -26506,7 +26504,7 @@
"/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/web/zustand-stores.test.ts > useThemeStore system theme resolves to dark when matchMedia prefers dark" "/Users/sidd/Desktop/Personal/Projects/SnapOtter/.claude/worktrees/test+suite-overhaul-and-real-fixtures/tests/unit/web/zustand-stores.test.ts > useThemeStore system theme resolves to dark when matchMedia prefers dark"
], ],
"counts": { "counts": {
"total": 13360, "total": 13359,
"passed": 13142 "passed": 13141
} }
} }
+2 -2
View File
@@ -113,11 +113,11 @@ export function readFixture(path: string): Buffer {
// Recursively collect every string-valued leaf, EXCLUDING `*hostileEmpty*` groups // Recursively collect every string-valued leaf, EXCLUDING `*hostileEmpty*` groups
// (intentionally zero-byte) and function leaves (the `formats`/`tiny` accessors). // (intentionally zero-byte) and function leaves (the `formats`/`tiny` accessors).
export function flattenFixturePaths(node: unknown, key = ""): string[] { export function flattenFixturePaths(node: unknown): string[] {
if (typeof node === "string") return [node]; if (typeof node === "string") return [node];
if (node && typeof node === "object") { if (node && typeof node === "object") {
return Object.entries(node).flatMap(([k, v]) => return Object.entries(node).flatMap(([k, v]) =>
k.toLowerCase().includes("hostileempty") ? [] : flattenFixturePaths(v, k), k.toLowerCase().includes("hostileempty") ? [] : flattenFixturePaths(v),
); );
} }
return []; // functions (accessors) and other non-leaves return []; // functions (accessors) and other non-leaves
+2 -1
View File
@@ -25,7 +25,8 @@ function walk(dir: string): string[] {
e.name === "index.ts" || e.name === "index.ts" ||
e.name === ".gitkeep" || e.name === ".gitkeep" ||
e.name.endsWith(".md") || e.name.endsWith(".md") ||
e.name.endsWith(".json") e.name.endsWith(".json") ||
e.name.endsWith(".mjs")
) )
return []; return [];
return [full]; return [full];