mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
test: reorganize flat test files into purpose-based subdirectories (phase 6)
Group 245 flat integration tests and 25 loose unit tests into
discoverable subdirectories per spec section 6:
integration/tools/{image,video,audio,document,data}/ (156 files)
integration/platform/ (64 files)
integration/generated/ (14 files)
integration/security/ (10 files)
unit/security/ (8 files, new subdir)
unit/api/ (7 files moved in)
unit/web/ (3 files moved in)
unit/shared/ (6 files moved in)
unit/image-engine/ (1 file moved in)
All moves via git mv (history preserved). Relative imports repaired
for both depth levels (platform/generated/security = +1, tools/ = +2):
static from-imports, dynamic import() calls, vi.mock() paths,
import.meta.dirname joins, and __dirname joins.
Vitest discovery unchanged (no test.include in config, recursive glob
matches subdirs, shard-by-hash unaffected). test-server.ts and
tool-route-drift.test.ts stay at integration root. fixtures/ untouched.
Parity gate: 13189 passing test names before = 13189 after (0 dropped).
This commit is contained in:
SnapOtter
@@ -0,0 +1,841 @@
|
||||
/**
|
||||
* Pipeline edge-case integration tests for the SnapOtter image API.
|
||||
*
|
||||
* Tests the pipeline execution system with unusual inputs: empty pipelines,
|
||||
* single steps, invalid tools, conflicting steps, and multi-step chains.
|
||||
*/
|
||||
|
||||
import { ffmpegAvailable } from "@snapotter/media-engine";
|
||||
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
||||
import { fixtures, readFixture } from "../../fixtures/index.js";
|
||||
import {
|
||||
buildTestApp,
|
||||
createMultipartPayload,
|
||||
loginAsAdmin,
|
||||
type TestApp,
|
||||
} from "../test-server.js";
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Fixtures
|
||||
// ---------------------------------------------------------------------------
|
||||
const PNG_200x150 = readFixture(fixtures.image.base.png200);
|
||||
const TINY_MP4 = readFixture(fixtures.video.tiny("mp4"));
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Shared state
|
||||
// ---------------------------------------------------------------------------
|
||||
let testApp: TestApp;
|
||||
let app: TestApp["app"];
|
||||
let adminToken: string;
|
||||
|
||||
beforeAll(async () => {
|
||||
testApp = await buildTestApp();
|
||||
app = testApp.app;
|
||||
adminToken = await loginAsAdmin(app);
|
||||
}, 30_000);
|
||||
|
||||
afterAll(async () => {
|
||||
await testApp.cleanup();
|
||||
}, 10_000);
|
||||
|
||||
/** Helper to POST a pipeline execution request. */
|
||||
function executePipeline(
|
||||
image: Buffer,
|
||||
filename: string,
|
||||
pipeline: { steps: Array<{ toolId: string; settings?: Record<string, unknown> }> },
|
||||
) {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename, content: image, contentType: "image/png" },
|
||||
{ name: "pipeline", content: JSON.stringify(pipeline) },
|
||||
]);
|
||||
return app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/execute",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
}
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// EMPTY PIPELINE
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Empty pipeline", () => {
|
||||
it("rejects a pipeline with zero steps", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", { steps: [] });
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/pipeline/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// SINGLE STEP PIPELINE
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Single step pipeline", () => {
|
||||
it("executes a pipeline with one resize step", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [{ toolId: "resize", settings: { width: 100 } }],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.stepsCompleted).toBe(1);
|
||||
expect(json.downloadUrl).toBeDefined();
|
||||
});
|
||||
|
||||
it("executes a pipeline with one rotate step", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [{ toolId: "rotate", settings: { angle: 180 } }],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.stepsCompleted).toBe(1);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE WITH INVALID TOOL
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline with invalid tool reference", () => {
|
||||
it("rejects a pipeline referencing a non-existent tool", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [{ toolId: "totally-fake-tool-that-does-not-exist" }],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/not found/i);
|
||||
});
|
||||
|
||||
it("rejects at the invalid step even when earlier steps are valid", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [{ toolId: "resize", settings: { width: 100 } }, { toolId: "nonexistent-tool" }],
|
||||
});
|
||||
|
||||
// Validation happens before execution — should reject immediately
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/step 2/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE WITH CONFLICTING STEPS
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline with conflicting steps", () => {
|
||||
it("applies resize steps in order (last wins)", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [
|
||||
{ toolId: "resize", settings: { width: 100, height: 100 } },
|
||||
{ toolId: "resize", settings: { width: 200, height: 200 } },
|
||||
],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.stepsCompleted).toBe(2);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE WITH MULTIPLE TOOLS CHAINED
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Multi-step pipeline chains", () => {
|
||||
it("chains resize then rotate then compress", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [
|
||||
{ toolId: "resize", settings: { width: 100 } },
|
||||
{ toolId: "rotate", settings: { angle: 90 } },
|
||||
{ toolId: "compress", settings: { quality: 60 } },
|
||||
],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.stepsCompleted).toBe(3);
|
||||
expect(json.steps).toHaveLength(3);
|
||||
expect(json.steps[0].toolId).toBe("resize");
|
||||
expect(json.steps[1].toolId).toBe("rotate");
|
||||
expect(json.steps[2].toolId).toBe("compress");
|
||||
});
|
||||
|
||||
it("chains crop then resize", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [
|
||||
{ toolId: "crop", settings: { left: 10, top: 10, width: 100, height: 100 } },
|
||||
{ toolId: "resize", settings: { width: 50 } },
|
||||
],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.stepsCompleted).toBe(2);
|
||||
// Output should be smaller than the original
|
||||
expect(json.processedSize).toBeLessThan(json.originalSize);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE WITH INVALID SETTINGS IN A STEP
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline with invalid settings in a step", () => {
|
||||
it("rejects a pipeline with invalid settings for a specific step", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [
|
||||
{ toolId: "resize", settings: { width: 100 } },
|
||||
{ toolId: "crop", settings: { left: -10, top: 0, width: 50, height: 50 } },
|
||||
],
|
||||
});
|
||||
|
||||
// left: -10 fails z.number().min(0) validation
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/step 2/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE DEFINITION FIELD MISSING
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Missing pipeline definition", () => {
|
||||
it("rejects when no pipeline field is provided", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "test.png", content: PNG_200x150, contentType: "image/png" },
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/execute",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/pipeline/i);
|
||||
});
|
||||
|
||||
it("rejects non-JSON pipeline definition", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "test.png", content: PNG_200x150, contentType: "image/png" },
|
||||
{ name: "pipeline", content: "this is not json" },
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/execute",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/json/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE WITHOUT IMAGE
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline without image", () => {
|
||||
it("rejects when no image file is provided", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({ steps: [{ toolId: "resize", settings: { width: 100 } }] }),
|
||||
},
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/execute",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
// The route may report either "No image file provided" or the more generic
|
||||
// "No file provided" depending on which validation fires first.
|
||||
expect(json.error).toMatch(/no (image|file)/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// SAVE PIPELINE EDGE CASES
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Save pipeline edge cases", () => {
|
||||
it("rejects saving a pipeline with empty name", async () => {
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/save",
|
||||
headers: {
|
||||
"content-type": "application/json",
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
},
|
||||
payload: {
|
||||
name: "",
|
||||
steps: [{ toolId: "resize", settings: { width: 100 } }],
|
||||
},
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
it("rejects saving a pipeline with no steps", async () => {
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/save",
|
||||
headers: {
|
||||
"content-type": "application/json",
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
},
|
||||
payload: {
|
||||
name: "empty-pipeline",
|
||||
steps: [],
|
||||
},
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
it("rejects saving a pipeline with an invalid tool reference", async () => {
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/save",
|
||||
headers: {
|
||||
"content-type": "application/json",
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
},
|
||||
payload: {
|
||||
name: "bad-pipeline",
|
||||
steps: [{ toolId: "this-tool-does-not-exist" }],
|
||||
},
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
it("saves and lists a valid pipeline", async () => {
|
||||
const saveRes = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/save",
|
||||
headers: {
|
||||
"content-type": "application/json",
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
},
|
||||
payload: {
|
||||
name: "edge-case-test-pipeline",
|
||||
description: "Created by edge case tests",
|
||||
steps: [
|
||||
{ toolId: "resize", settings: { width: 100 } },
|
||||
{ toolId: "rotate", settings: { angle: 90 } },
|
||||
],
|
||||
},
|
||||
});
|
||||
|
||||
expect(saveRes.statusCode).toBe(201);
|
||||
const saved = JSON.parse(saveRes.body);
|
||||
expect(saved.id).toBeDefined();
|
||||
expect(saved.name).toBe("edge-case-test-pipeline");
|
||||
|
||||
// Verify it appears in the list
|
||||
const listRes = await app.inject({
|
||||
method: "GET",
|
||||
url: "/api/v1/pipeline/list",
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
|
||||
expect(listRes.statusCode).toBe(200);
|
||||
const list = JSON.parse(listRes.body);
|
||||
const found = list.pipelines.find((p: { id: string }) => p.id === saved.id);
|
||||
expect(found).toBeDefined();
|
||||
expect(found.steps).toHaveLength(2);
|
||||
|
||||
// Clean up — delete the pipeline
|
||||
const deleteRes = await app.inject({
|
||||
method: "DELETE",
|
||||
url: `/api/v1/pipeline/${saved.id}`,
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
expect(deleteRes.statusCode).toBe(200);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PASSWORD TOOL PIPELINE SAVE REJECTION
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline save rejects password tools", () => {
|
||||
it("rejects saving a pipeline containing protect-pdf", async () => {
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/save",
|
||||
headers: {
|
||||
"content-type": "application/json",
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
},
|
||||
payload: {
|
||||
name: "protect-pipeline",
|
||||
steps: [
|
||||
{ toolId: "resize", settings: { width: 100 } },
|
||||
{ toolId: "protect-pdf", settings: { userPassword: "test" } },
|
||||
],
|
||||
},
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/password/i);
|
||||
});
|
||||
|
||||
it("rejects saving a pipeline containing unlock-pdf", async () => {
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/save",
|
||||
headers: {
|
||||
"content-type": "application/json",
|
||||
authorization: `Bearer ${adminToken}`,
|
||||
},
|
||||
payload: {
|
||||
name: "unlock-pipeline",
|
||||
steps: [{ toolId: "unlock-pdf", settings: { password: "test" } }],
|
||||
},
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/password/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE EXECUTE REJECTS PASSWORD TOOLS
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline execute rejects password tools", () => {
|
||||
it("rejects executing a pipeline containing protect-pdf", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [
|
||||
{ toolId: "resize", settings: { width: 100 } },
|
||||
{ toolId: "protect-pdf", settings: { userPassword: "test" } },
|
||||
],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/password/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE BATCH REJECTS PASSWORD TOOLS
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline batch rejects password tools", () => {
|
||||
it("rejects a batch pipeline containing unlock-pdf", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "test.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({
|
||||
steps: [{ toolId: "unlock-pdf", settings: { password: "test" } }],
|
||||
}),
|
||||
},
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/password/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// DELETE PIPELINE EDGE CASES
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Delete pipeline edge cases", () => {
|
||||
it("returns 404 when deleting a non-existent pipeline", async () => {
|
||||
const res = await app.inject({
|
||||
method: "DELETE",
|
||||
url: "/api/v1/pipeline/00000000-0000-0000-0000-000000000000",
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(404);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/not found/i);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE TOOLS LIST
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline tools endpoint", () => {
|
||||
it("returns the list of available pipeline tools", async () => {
|
||||
const res = await app.inject({
|
||||
method: "GET",
|
||||
url: "/api/v1/pipeline/tools",
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.toolIds).toBeDefined();
|
||||
expect(Array.isArray(json.toolIds)).toBe(true);
|
||||
expect(json.toolIds.length).toBeGreaterThan(0);
|
||||
// Core tools should be registered
|
||||
expect(json.toolIds).toContain("resize");
|
||||
expect(json.toolIds).toContain("rotate");
|
||||
expect(json.toolIds).toContain("compress");
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE BATCH EXECUTION
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline batch execution", () => {
|
||||
it("processes multiple files through a pipeline and returns ZIP", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "batch1.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{ name: "file", filename: "batch2.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({
|
||||
steps: [{ toolId: "resize", settings: { width: 50 } }],
|
||||
}),
|
||||
},
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
expect(res.headers["content-type"]).toBe("application/zip");
|
||||
expect(res.headers["x-job-id"]).toBeDefined();
|
||||
expect(res.headers["x-file-results"]).toBeDefined();
|
||||
});
|
||||
|
||||
it("handles non-ASCII filenames without ERR_INVALID_CHAR (#133)", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "图片.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{ name: "file", filename: "写真テスト.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({
|
||||
steps: [{ toolId: "resize", settings: { width: 50 } }],
|
||||
}),
|
||||
},
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const raw = res.headers["x-file-results"] as string;
|
||||
expect(raw).toMatch(/^[\x20-\x7E]+$/);
|
||||
const fileResults = JSON.parse(decodeURIComponent(raw));
|
||||
expect(fileResults["0"]).toContain("图片");
|
||||
expect(fileResults["1"]).toContain("写真テスト");
|
||||
});
|
||||
|
||||
it("rejects pipeline batch with no files", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({
|
||||
steps: [{ toolId: "resize", settings: { width: 50 } }],
|
||||
}),
|
||||
},
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
// The route may report either "No image file provided" or the more generic
|
||||
// "No file provided" depending on which validation fires first.
|
||||
expect(json.error).toMatch(/no (image|file)/i);
|
||||
});
|
||||
|
||||
it("rejects pipeline batch with no pipeline definition", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "lonely.png", contentType: "image/png", content: PNG_200x150 },
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/pipeline/i);
|
||||
});
|
||||
|
||||
it("rejects pipeline batch with invalid JSON pipeline", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "test.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{ name: "pipeline", content: "not-json!!" },
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toMatch(/json/i);
|
||||
});
|
||||
|
||||
it("rejects pipeline batch with an unknown tool", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "test.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({
|
||||
steps: [{ toolId: "nonexistent-tool-xyz" }],
|
||||
}),
|
||||
},
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
it("uses clientJobId when provided", async () => {
|
||||
const clientJobId = "custom-pipeline-batch-id-123";
|
||||
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "cid.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({
|
||||
steps: [{ toolId: "rotate", settings: { angle: 90 } }],
|
||||
}),
|
||||
},
|
||||
{ name: "clientJobId", content: clientJobId },
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
expect(res.headers["x-job-id"]).toBe(clientJobId);
|
||||
});
|
||||
|
||||
it("pipeline batch with multi-step chain processes correctly", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "multi.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({
|
||||
steps: [
|
||||
{ toolId: "resize", settings: { width: 100 } },
|
||||
{ toolId: "rotate", settings: { angle: 180 } },
|
||||
],
|
||||
}),
|
||||
},
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
expect(res.headers["content-type"]).toBe("application/zip");
|
||||
});
|
||||
|
||||
it("pipeline batch rejects invalid step settings", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "test.png", contentType: "image/png", content: PNG_200x150 },
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({
|
||||
steps: [{ toolId: "crop", settings: { left: -5, top: 0, width: 10, height: 10 } }],
|
||||
}),
|
||||
},
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/batch",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(400);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE STEP FAILURE DURING EXECUTION
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline execution failure recovery", () => {
|
||||
it("returns 422 when a processing step fails at runtime", async () => {
|
||||
// Crop with dimensions larger than the image will fail during processing
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [
|
||||
{ toolId: "resize", settings: { width: 10 } },
|
||||
// Crop area bigger than the resized image
|
||||
{ toolId: "crop", settings: { left: 0, top: 0, width: 5000, height: 5000 } },
|
||||
],
|
||||
});
|
||||
|
||||
// Should either get a 422 with error or 200 if sharp auto-clips
|
||||
const status = res.statusCode;
|
||||
expect(status === 200 || status === 422).toBe(true);
|
||||
|
||||
if (status === 422) {
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.error).toBeDefined();
|
||||
expect(json.completedSteps).toBeDefined();
|
||||
}
|
||||
});
|
||||
|
||||
it("reports completedSteps for partial pipeline failures", async () => {
|
||||
// First step succeeds, second step uses bad settings that will
|
||||
// cause a runtime error
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [{ toolId: "resize", settings: { width: 50 } }],
|
||||
});
|
||||
|
||||
// This should succeed; verifying the completedSteps field exists
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.stepsCompleted).toBe(1);
|
||||
expect(json.steps).toHaveLength(1);
|
||||
expect(json.steps[0].step).toBe(1);
|
||||
expect(json.steps[0].toolId).toBe("resize");
|
||||
expect(json.steps[0].size).toBeGreaterThan(0);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// PIPELINE EXECUTION RESPONSE FORMAT
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
describe("Pipeline execution response", () => {
|
||||
it("returns all expected fields in the response", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [{ toolId: "resize", settings: { width: 80 } }],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
|
||||
expect(json.jobId).toBeDefined();
|
||||
expect(json.downloadUrl).toBeDefined();
|
||||
expect(typeof json.originalSize).toBe("number");
|
||||
expect(typeof json.processedSize).toBe("number");
|
||||
expect(json.stepsCompleted).toBe(1);
|
||||
expect(json.steps).toHaveLength(1);
|
||||
expect(json.originalSize).toBe(PNG_200x150.length);
|
||||
});
|
||||
|
||||
it("processed size differs from original after real transformation", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [{ toolId: "resize", settings: { width: 50 } }],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
// Resizing to 50px should produce a different size
|
||||
expect(json.processedSize).not.toBe(json.originalSize);
|
||||
});
|
||||
|
||||
it("download URL is accessible", async () => {
|
||||
const res = await executePipeline(PNG_200x150, "test.png", {
|
||||
steps: [{ toolId: "rotate", settings: { angle: 90 } }],
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
|
||||
const dlRes = await app.inject({
|
||||
method: "GET",
|
||||
url: json.downloadUrl,
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
|
||||
expect(dlRes.statusCode).toBe(200);
|
||||
expect(dlRes.rawPayload.length).toBeGreaterThan(0);
|
||||
});
|
||||
});
|
||||
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// NON-IMAGE PIPELINE (regression)
|
||||
// ═══════════════════════════════════════════════════════════════════════════
|
||||
// Pipeline execute used to hardcode image validation and rejected video inputs
|
||||
// with "Invalid image". It now validates via the first step's modality handler.
|
||||
describe.skipIf(!ffmpegAvailable())("Non-image pipeline (video)", () => {
|
||||
it("runs a multi-step video pipeline and returns a downloadable result", async () => {
|
||||
const { body, contentType } = createMultipartPayload([
|
||||
{ name: "file", filename: "tiny.mp4", content: TINY_MP4, contentType: "video/mp4" },
|
||||
{
|
||||
name: "pipeline",
|
||||
content: JSON.stringify({
|
||||
steps: [
|
||||
{ toolId: "rotate-video", settings: { transform: "cw90" } },
|
||||
{ toolId: "mute-video", settings: {} },
|
||||
],
|
||||
}),
|
||||
},
|
||||
]);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/api/v1/pipeline/execute",
|
||||
headers: { "content-type": contentType, authorization: `Bearer ${adminToken}` },
|
||||
body,
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
const json = JSON.parse(res.body);
|
||||
expect(json.downloadUrl).toBeDefined();
|
||||
expect(json.stepsCompleted).toBe(2);
|
||||
|
||||
const dlRes = await app.inject({
|
||||
method: "GET",
|
||||
url: json.downloadUrl,
|
||||
headers: { authorization: `Bearer ${adminToken}` },
|
||||
});
|
||||
expect(dlRes.statusCode).toBe(200);
|
||||
expect(dlRes.rawPayload.length).toBeGreaterThan(0);
|
||||
}, 60_000);
|
||||
});
|
||||
Reference in New Issue
Block a user