fix(security): close the gaps a full 2.0 re-audit left open (#620)

Follow-up to a full re-audit of the 2.0 tree. Most prior findings were already
fixed; this closes the ones that were not:

- SAML assertion replay: validateInResponseTo ifPresent plus a Redis-backed
  CacheProvider, so a captured signed assertion cannot be replayed. ifPresent
  keeps IdP-initiated SSO working.
- MFA login challenge burned after 5 wrong TOTP codes.
- api_keys.key_prefix indexed; the per-request lookup was a full table scan.
- MAX_AI_JOBS_PER_USER caps a user's in-flight single-file AI jobs (the AI pool
  runs at concurrency 1). Batch and pipeline AI stay uncapped.
- MAX_WORKSPACE_SIZE_GB enforced instead of being dead config.
- SUBPROCESS_MEMORY_LIMIT_MB (default off) for the native media and doc engines;
  not applied to the AI sidecar.
- SVG sanitizer closes unquoted and whitespace-prefixed javascript: hrefs and
  the animateTransform/animateMotion/handler/mpath elements.
- Windows-style paths stripped from error output to match the Sentry scrubber.
- Postgres and Redis compose services get cap_drop plus pids_limit and cpus.
- .env.example ships MAX_SVG_SIZE_MB=50 (0 disabled the cap).

Adds security-focused unit and integration tests. typecheck, biome, and the
full unit and integration suites pass.
This commit is contained in:
SnapOtter
2026-07-23 00:18:16 +08:00
committed by GitHub
parent 10a2aabe58
commit 079fcd2631
33 changed files with 1747 additions and 57 deletions
+10 -2
View File
@@ -1,5 +1,5 @@
import { spawn } from "node:child_process";
import { markToolInputError, SafeError } from "@snapotter/shared";
import { markToolInputError, SafeError, wrapWithMemoryLimit } from "@snapotter/shared";
import { resolveFfmpeg } from "./binaries.js";
import { type FfmpegProgress, parseProgressBlock } from "./progress.js";
@@ -39,7 +39,15 @@ export async function runFfmpeg(args: string[], opts: RunFfmpegOptions = {}): Pr
const bin = resolveFfmpeg();
if (!bin) throw new Error("ffmpeg binary not found (set FFMPEG_PATH or install ffmpeg)");
return new Promise<string>((resolvePromise, reject) => {
const child = spawn(bin, ["-hide_banner", "-nostdin", "-y", ...args, "-progress", "pipe:1"], {
const [limBin, limArgs] = wrapWithMemoryLimit(bin, [
"-hide_banner",
"-nostdin",
"-y",
...args,
"-progress",
"pipe:1",
]);
const child = spawn(limBin, limArgs, {
stdio: ["ignore", "pipe", "pipe"],
});
let stderrTail = "";
+3 -1
View File
@@ -1,4 +1,5 @@
import { spawn } from "node:child_process";
import { wrapWithMemoryLimit } from "@snapotter/shared";
import { resolveFfprobe } from "./binaries.js";
import { markIfInputError } from "./ffmpeg.js";
@@ -42,7 +43,8 @@ export async function probeMedia(filePath: string, opts: ProbeOptions = {}): Pro
];
const timeoutMs = opts.timeoutMs ?? 15_000;
const stdout = await new Promise<string>((resolvePromise, reject) => {
const child = spawn(bin, args, { stdio: ["ignore", "pipe", "pipe"] });
const [limBin, limArgs] = wrapWithMemoryLimit(bin, args);
const child = spawn(limBin, limArgs, { stdio: ["ignore", "pipe", "pipe"] });
let out = "";
let err = "";
let settled = false;