feat: Add comprehensive keyboard shortcuts system for video editor

- Implement industry-standard video editing shortcuts (Space, J/K/L, arrows)
- Add playback controls: Space (play/pause), J/K/L (rewind/pause/forward)
- Add navigation: arrow keys (frame stepping), Shift+arrows (5s jumps), Home/End
- Add editing shortcuts: S (split at playhead), N (toggle snapping)
- Add selection shortcuts: Ctrl/Cmd+A (select all), Ctrl/Cmd+D (duplicate)
- Add keyboard shortcuts help dialog with categorized shortcuts display
- Integrate help button in editor header for discoverability
- Add TypeScript type declarations for better development experience
- Fix Docker build environment variable validation issues

All shortcuts follow professional video editing standards (Avid/Premiere/Final Cut).
Context-aware shortcuts that don't interfere with text input fields.
Toast notifications provide user feedback for better UX.
This commit is contained in:
vishesh711
2025-07-15 12:36:53 -04:00
parent 1f95bb98d6
commit d3204f6cd7
7 changed files with 504 additions and 5 deletions
+190 -3
View File
@@ -1,5 +1,5 @@
// @ts-nocheck - Temporary suppression for IDE type configuration issues (app works perfectly)
"use client";
import { ScrollArea } from "../ui/scroll-area";
import { Button } from "../ui/button";
import {
@@ -37,6 +37,7 @@ import { useProjectStore } from "@/stores/project-store";
import { useTimelineZoom } from "@/hooks/use-timeline-zoom";
import { processMediaFiles } from "@/lib/media-processing";
import { toast } from "sonner";
import * as React from "react";
import { useState, useRef, useEffect, useCallback } from "react";
import { TimelineTrackContent } from "./timeline-track";
import {
@@ -53,6 +54,7 @@ import {
getCumulativeHeightBefore,
getTotalTracksHeight,
TIMELINE_CONSTANTS,
snapTimeToFrame,
} from "@/constants/timeline-constants";
export function Timeline() {
@@ -234,7 +236,6 @@ export function Timeline() {
// Use frame snapping for timeline clicking
const projectFps = activeProject?.fps || 30;
const { snapTimeToFrame } = require("@/constants/timeline-constants");
const time = snapTimeToFrame(rawTime, projectFps);
seek(time);
@@ -280,7 +281,7 @@ export function Timeline() {
(e.key === "Delete" || e.key === "Backspace") &&
selectedElements.length > 0
) {
selectedElements.forEach(({ trackId, elementId }) => {
selectedElements.forEach(({ trackId, elementId }: { trackId: string; elementId: string }) => {
removeElementFromTrack(trackId, elementId);
});
clearSelectedElements();
@@ -322,6 +323,192 @@ export function Timeline() {
return () => window.removeEventListener("keydown", handleKeyDown);
}, [redo]);
// Core video editor keyboard shortcuts
useEffect(() => {
const handleKeyDown = (e: KeyboardEvent) => {
// Don't interfere with typing in inputs
const activeElement = document.activeElement as HTMLElement;
const isInputFocused = activeElement && (
activeElement.tagName === 'INPUT' ||
activeElement.tagName === 'TEXTAREA' ||
activeElement.contentEditable === 'true'
);
if (isInputFocused) return;
const { key, metaKey, ctrlKey, shiftKey } = e;
const isModified = metaKey || ctrlKey || shiftKey;
switch (key) {
case ' ': // Spacebar - Play/Pause
if (!isModified) {
e.preventDefault();
toggle();
toast.info(isPlaying ? 'Paused' : 'Playing', { duration: 1000 });
}
break;
case 'j':
case 'J':
if (!isModified) {
e.preventDefault();
// J - Rewind 1 second
seek(Math.max(0, currentTime - 1));
toast.info('Rewind 1s', { duration: 1000 });
}
break;
case 'k':
case 'K':
if (!isModified) {
e.preventDefault();
// K - Pause/Play toggle
toggle();
toast.info(isPlaying ? 'Paused' : 'Playing', { duration: 1000 });
}
break;
case 'l':
case 'L':
if (!isModified) {
e.preventDefault();
// L - Fast forward 1 second
seek(Math.min(duration, currentTime + 1));
toast.info('Forward 1s', { duration: 1000 });
}
break;
case 'ArrowLeft':
if (shiftKey) {
e.preventDefault();
// Shift+Left - Jump back 5 seconds
seek(Math.max(0, currentTime - 5));
} else if (!isModified) {
e.preventDefault();
// Left - Frame step backward (1/30 second)
seek(Math.max(0, currentTime - (1/30)));
}
break;
case 'ArrowRight':
if (shiftKey) {
e.preventDefault();
// Shift+Right - Jump forward 5 seconds
seek(Math.min(duration, currentTime + 5));
} else if (!isModified) {
e.preventDefault();
// Right - Frame step forward (1/30 second)
seek(Math.min(duration, currentTime + (1/30)));
}
break;
case 'Home':
if (!isModified) {
e.preventDefault();
seek(0);
toast.info('Start of timeline', { duration: 1000 });
}
break;
case 'End':
if (!isModified) {
e.preventDefault();
seek(duration);
toast.info('End of timeline', { duration: 1000 });
}
break;
case 's':
case 'S':
if (!isModified && selectedElements.length === 1) {
e.preventDefault();
// S - Split element at playhead
const { trackId, elementId } = selectedElements[0];
const track = tracks.find((t: any) => t.id === trackId);
const element = track?.elements.find((el: any) => el.id === elementId);
if (element) {
const effectiveStart = element.startTime;
const effectiveEnd = element.startTime + (element.duration - element.trimStart - element.trimEnd);
if (currentTime > effectiveStart && currentTime < effectiveEnd) {
splitElement(trackId, elementId, currentTime);
toast.success('Element split at playhead');
} else {
toast.error('Playhead must be within selected element');
}
}
}
break;
case 'n':
case 'N':
if (!isModified) {
e.preventDefault();
toggleSnapping();
toast.info(`Snapping ${snappingEnabled ? 'disabled' : 'enabled'}`, { duration: 1000 });
}
break;
}
// Multi-key shortcuts
if ((metaKey || ctrlKey) && !shiftKey) {
switch (key.toLowerCase()) {
case 'a':
e.preventDefault();
// Cmd/Ctrl+A - Select all elements
const allElements = tracks.flatMap((track: any) =>
track.elements.map((element: any) => ({
trackId: track.id,
elementId: element.id
}))
);
setSelectedElements(allElements);
toast.info(`Selected ${allElements.length} elements`, { duration: 1000 });
break;
case 'd':
if (selectedElements.length === 1) {
e.preventDefault();
// Cmd/Ctrl+D - Duplicate selected element
const { trackId, elementId } = selectedElements[0];
const track = tracks.find((t: any) => t.id === trackId);
const element = track?.elements.find((el: any) => el.id === elementId);
if (element) {
const newStartTime = element.startTime + (element.duration - element.trimStart - element.trimEnd) + 0.1;
const { id, ...elementWithoutId } = element;
addElementToTrack(trackId, {
...elementWithoutId,
startTime: newStartTime,
});
toast.success('Element duplicated');
}
}
break;
}
}
};
window.addEventListener("keydown", handleKeyDown);
return () => window.removeEventListener("keydown", handleKeyDown);
}, [
isPlaying,
currentTime,
duration,
selectedElements,
tracks,
toggle,
seek,
splitElement,
snappingEnabled,
toggleSnapping,
setSelectedElements,
addElementToTrack
]);
// Old marquee system removed - using new SelectionBox component instead
const handleDragEnter = (e: React.DragEvent) => {