Merge pull request #2870 from actus7/consolidate/hooks-observer-v3

fix(hooks): consolidate hooks and observer fixes (5 PRs)
This commit is contained in:
haelyra
2026-08-28 18:29:03 -04:00
committed by GitHub
15 changed files with 469 additions and 45 deletions
+15 -1
View File
@@ -1,7 +1,7 @@
---
name: gan-evaluator
description: "GAN Harness — Evaluator agent. Tests the live running application via Playwright, scores against rubric, and provides actionable feedback to the Generator."
tools: Read, Write, Bash, Grep, Glob
tools: Read, Write, Bash, Grep, Glob, mcp__playwright__browser_navigate, mcp__playwright__browser_click, mcp__playwright__browser_take_screenshot, mcp__playwright__browser_snapshot, mcp__playwright__browser_type, mcp__playwright__browser_fill_form
model: sonnet
color: red
---
@@ -35,6 +35,12 @@ You are the QA Engineer and Design Critic. You test the **live running applicati
## Evaluation Workflow
Before testing, record the mode that is actually available. The requested mode
is not proof that its tools were available: if the Playwright MCP tools cannot
be called, switch to the documented `screenshot` or `code-only` fallback and
report that degradation instead of silently scoring a static review as a live
browser evaluation.
### Step 1: Read the Rubric
```
Read gan-harness/eval-rubric.md for project-specific criteria
@@ -129,6 +135,14 @@ Write feedback to `gan-harness/feedback/feedback-NNN.md`:
## Scores
## Evaluation Mode
**Achieved:** `playwright` | `screenshot` | `code-only`
State the mode that was actually completed (not merely the mode requested by
the harness). If the requested mode was unavailable, briefly explain why and
which fallback was used.
| Criterion | Score | Weight | Weighted |
|-----------|-------|--------|----------|
| Design Quality | X/10 | 0.3 | X.X |