External/ContainerFlow
1
0
Fork 0
mirror of https://github.com/RGJorge/ContainerFlow.git synced 2026-08-03 07:21:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

v0.1.9 — fix crash on Windows when container Ports is null

Browse Source 
Docker Desktop on Windows can return null for c.Ports / c.Labels / c.Names
in the listContainers response (Linux returns empty array/object). The
mapping in discoverServices() assumed array, so .filter() crashed and the
refresh loop kept retrying every 5s, filling the logs.

Closes #7
This commit is contained in:
RGJorge
2026-05-18 17:06:53 +00:00
parent 6fd4440b7a
commit 3b18cad271
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
package.json
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "containerflow", "name": "containerflow",
"version": "0.1.8", "version": "0.1.9",
"license": "AGPL-3.0-or-later", "license": "AGPL-3.0-or-later",
"author": "Jorge Gonzalez D. (RGJorge)", "author": "Jorge Gonzalez D. (RGJorge)",
"type": "module", "type": "module",
src/server/docker.ts
+8 -4
View File
@@ -27,8 +27,12 @@ export async function discoverServices(all: boolean, projects: string[]): Promis
); );
let services: Service[] = containers.map((c, i) => { let services: Service[] = containers.map((c, i) => {
const name = c.Labels["com.docker.compose.service"] || c.Names[0]?.replace("/", "") || "unknown"; // Docker Desktop on Windows may return null for Labels/Names/Ports
const project = c.Labels["com.docker.compose.project"] || "docker"; // where the Linux daemon returns {} / [] — defend at the boundary.
const labels = c.Labels ?? {};
const names = c.Names ?? [];
const name = labels["com.docker.compose.service"] || names[0]?.replace("/", "") || "unknown";
const project = labels["com.docker.compose.project"] || "docker";
const info = inspections[i] as any; const info = inspections[i] as any;
// Extract network IPs // Extract network IPs
@@ -64,7 +68,7 @@ export async function discoverServices(all: boolean, projects: string[]): Promis
state, state,
status: c.Status, status: c.Status,
ports: [...new Map( ports: [...new Map(
c.Ports.filter((p) => p.PublicPort).map((p) => [ (c.Ports ?? []).filter((p) => p.PublicPort).map((p) => [
`${p.PublicPort}:${p.PrivatePort}`, `${p.PublicPort}:${p.PrivatePort}`,
{ host: p.PublicPort!, container: p.PrivatePort }, { host: p.PublicPort!, container: p.PrivatePort },
]) ])
@@ -72,7 +76,7 @@ export async function discoverServices(all: boolean, projects: string[]): Promis
networks: Object.keys(c.NetworkSettings?.Networks || {}), networks: Object.keys(c.NetworkSettings?.Networks || {}),
network_ips: networkIps, network_ips: networkIps,
project, project,
compose_file: c.Labels["com.docker.compose.project.config_files"] || "", compose_file: labels["com.docker.compose.project.config_files"] || "",
env: (info?.Config?.Env || []) as string[], env: (info?.Config?.Env || []) as string[],
restart_policy: info?.HostConfig?.RestartPolicy?.Name || "", restart_policy: info?.HostConfig?.RestartPolicy?.Name || "",
memory_limit: info?.HostConfig?.Memory || 0, memory_limit: info?.HostConfig?.Memory || 0,