External/CloakBrowser
1
0
Fork 0
mirror of https://github.com/CloakHQ/CloakBrowser.git synced 2026-06-23 11:41:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: align humanize timeout default with Playwright's 30s auto-retry (#172)

Browse Source 
The humanize layer hardcoded timeout=2000ms for element lookups, causing
locator.click() and page.click() to fail instantly instead of retrying
for 30s like standard Playwright. Aligned all defaults to 30000ms across
Python sync/async, JS Playwright, and JS Puppeteer paths. Bumped the
outer retry sleep from 200ms to 500ms for DOM mutation settle time.
This commit is contained in:
CloakHQ
2026-05-01 20:48:06 +02:00
parent 2df8c7e2d1
commit f01902025a
8 changed files with 30 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
js/src/human-puppeteer/scroll.ts
+4 -8
View File
@@ -57,12 +57,12 @@ export async function smoothWheel(
/**
* Poll ``page.$(selector)`` for up to ``timeout`` ms, returning the element's
* bounding box when found. ``timeout`` defaults to 2000ms when not specified.
* bounding box when found. ``timeout`` defaults to 30000ms when not specified.
*/
async function getElementBox(
page: Page,
selector: string,
timeout: number = 2000,
timeout: number = 30000,
): Promise<ElementBounds | null> {
const start = Date.now();
const pollInterval = 100;
@@ -97,11 +97,7 @@ export async function humanScrollIntoView(
if (!viewport) throw new Error('Viewport size not available');
let box = await getBox();
if (!box) {
await sleep(200);
box = await getBox();
if (!box) throw new Error('Element not found while scrolling into view');
}
if (!box) throw new Error('Element not found while scrolling into view');
if (isInViewport(box, viewport.height, cfg)) {
return { box, cursorX, cursorY };
@@ -188,7 +184,7 @@ export async function humanScrollIntoView(
*
* ``timeout`` controls how long we poll ``page.$(selector)`` before giving up,
* so callers like ``page.click('#x', { timeout: 5000 })`` can wait longer for
* slow-loading elements (#172). Default stays 2000ms when not specified.
* slow-loading elements (#172). Default matches Playwright's 30000ms when not specified.
*/
export async function scrollToElement(
page: Page,
js/src/human/scroll.ts
+3 -7
View File
@@ -57,11 +57,7 @@ export async function humanScrollIntoView(
if (!viewport) throw new Error('Viewport size not available');
let box = await getBox();
if (!box) {
await sleep(200);
box = await getBox();
if (!box) throw new Error('Element not found while scrolling into view');
}
if (!box) throw new Error('Element not found while scrolling into view');
if (isInViewport(box, viewport.height, cfg)) {
return { box, cursorX, cursorY };
@@ -151,7 +147,7 @@ export async function humanScrollIntoView(
*
* ``timeout`` is forwarded to Playwright's ``boundingBox({ timeout })`` so
* callers like ``page.click('#x', { timeout: 5000 })`` can wait longer for
* slow-loading elements (#172). Default stays 2000ms when not specified.
* slow-loading elements (#172). Default matches Playwright's 30000ms when not specified.
*/
export async function scrollToElement(
page: Page,
@@ -172,7 +168,7 @@ export async function scrollToElement(
async function getElementBox(
page: Page,
selector: string,
timeout: number = 2000,
timeout: number = 30000,
): Promise<ElementBounds | null> {
const el = page.locator(selector).first();
try {