feat: make patchright optional, default to stock playwright

tests/conftest.py

@@ -0,0 +1,11 @@
+"""Shared test fixtures."""
+
+import os
+
+import pytest
+
+
+@pytest.fixture(autouse=True)
+def _clean_backend_env(monkeypatch):
+    """Ensure CLOAKBROWSER_BACKEND doesn't leak into tests from the host environment."""
+    monkeypatch.delenv("CLOAKBROWSER_BACKEND", raising=False)

tests/test_backend.py

@@ -0,0 +1,45 @@
+"""Unit tests for backend resolution (_resolve_backend)."""
+
+import os
+from unittest.mock import patch
+
+import pytest
+
+from cloakbrowser.browser import _resolve_backend
+
+
+def test_resolve_backend_default():
+    """No param, no env var → 'playwright'."""
+    with patch.dict(os.environ, {}, clear=True):
+        assert _resolve_backend(None) == "playwright"
+
+
+def test_resolve_backend_explicit_playwright():
+    assert _resolve_backend("playwright") == "playwright"
+
+
+def test_resolve_backend_explicit_patchright():
+    assert _resolve_backend("patchright") == "patchright"
+
+
+def test_resolve_backend_env_var():
+    """CLOAKBROWSER_BACKEND env var used when no param."""
+    with patch.dict(os.environ, {"CLOAKBROWSER_BACKEND": "patchright"}):
+        assert _resolve_backend(None) == "patchright"
+
+
+def test_resolve_backend_param_beats_env():
+    """Explicit param overrides env var."""
+    with patch.dict(os.environ, {"CLOAKBROWSER_BACKEND": "patchright"}):
+        assert _resolve_backend("playwright") == "playwright"
+
+
+def test_resolve_backend_invalid_raises():
+    with pytest.raises(ValueError, match="Unknown backend 'bogus'"):
+        _resolve_backend("bogus")
+
+
+def test_resolve_backend_invalid_env_raises():
+    with patch.dict(os.environ, {"CLOAKBROWSER_BACKEND": "bogus"}):
+        with pytest.raises(ValueError, match="Unknown backend 'bogus'"):
+            _resolve_backend(None)

tests/test_persistent_context.py

@@ -1,6 +1,6 @@
 """Unit tests for launch_persistent_context() and launch_persistent_context_async().
 
-All tests mock patchright to avoid needing a binary.
+All tests mock playwright to avoid needing a binary.
 """
 
 import warnings
@@ -32,7 +32,7 @@ def test_persistent_context_args_built(_mock_geoip, _mock_bin):
     """Stealth args + extra args combined correctly."""
     pw_cm, pw, context = _make_mock_pw_and_context()
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         launch_persistent_context("/tmp/profile", args=["--disable-gpu"])
 
@@ -48,7 +48,7 @@ def test_persistent_context_default_viewport(_mock_geoip, _mock_bin):
     """DEFAULT_VIEWPORT applied when no viewport given."""
     pw_cm, pw, context = _make_mock_pw_and_context()
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         launch_persistent_context("/tmp/profile")
 
@@ -63,7 +63,7 @@ def test_persistent_context_custom_viewport(_mock_geoip, _mock_bin):
     pw_cm, pw, context = _make_mock_pw_and_context()
     custom = {"width": 1280, "height": 720}
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         launch_persistent_context("/tmp/profile", viewport=custom)
 
@@ -77,7 +77,7 @@ def test_persistent_context_user_agent(_mock_geoip, _mock_bin):
     """user_agent forwarded to launch_persistent_context()."""
     pw_cm, pw, context = _make_mock_pw_and_context()
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         launch_persistent_context("/tmp/profile", user_agent="Custom/1.0")
 
@@ -90,7 +90,7 @@ def test_persistent_context_locale_and_timezone(_mock_bin):
     """Both timezone and locale flow to context kwargs and binary args."""
     pw_cm, pw, context = _make_mock_pw_and_context()
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         launch_persistent_context("/tmp/profile", timezone="Asia/Tokyo", locale="ja-JP")
 
@@ -109,7 +109,7 @@ def test_persistent_context_color_scheme(_mock_geoip, _mock_bin):
     """color_scheme forwarded correctly."""
     pw_cm, pw, context = _make_mock_pw_and_context()
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         launch_persistent_context("/tmp/profile", color_scheme="dark")
 
@@ -123,7 +123,7 @@ def test_persistent_context_geoip(_mock_bin, _mock_geoip):
     """geoip fills missing tz/locale."""
     pw_cm, pw, context = _make_mock_pw_and_context()
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         launch_persistent_context("/tmp/profile", proxy="http://proxy:8080", geoip=True)
 
@@ -137,7 +137,7 @@ def test_persistent_context_timezone_id_deprecation(_mock_bin):
     """Old timezone_id kwarg migrated with warning."""
     pw_cm, pw, context = _make_mock_pw_and_context()
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         with warnings.catch_warnings(record=True) as w:
             warnings.simplefilter("always")
@@ -156,7 +156,7 @@ def test_persistent_context_close_stops_pw(_mock_geoip, _mock_bin):
     pw_cm, pw, context = _make_mock_pw_and_context()
     original_close = context.close
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         ctx = launch_persistent_context("/tmp/profile")
 
@@ -171,7 +171,7 @@ def test_persistent_context_proxy_string(_mock_geoip, _mock_bin):
     """Proxy string parsed and passed."""
     pw_cm, pw, context = _make_mock_pw_and_context()
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         launch_persistent_context("/tmp/profile", proxy="http://user:pass@proxy:8080")
 
@@ -188,7 +188,7 @@ def test_persistent_context_proxy_dict(_mock_geoip, _mock_bin):
     pw_cm, pw, context = _make_mock_pw_and_context()
     proxy_dict = {"server": "http://proxy:8080", "bypass": ".google.com"}
 
-    with patch("patchright.sync_api.sync_playwright", return_value=pw_cm):
+    with patch("playwright.sync_api.sync_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context
         launch_persistent_context("/tmp/profile", proxy=proxy_dict)
 
@@ -218,7 +218,7 @@ async def test_persistent_context_async_args_built(_mock_geoip, _mock_bin):
     """Async launch builds args correctly."""
     pw_cm, pw, context = _make_mock_async_pw_and_context()
 
-    with patch("patchright.async_api.async_playwright", return_value=pw_cm):
+    with patch("playwright.async_api.async_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context_async
         await launch_persistent_context_async("/tmp/profile", args=["--disable-gpu"])
 
@@ -235,7 +235,7 @@ async def test_persistent_context_async_close_stops_pw(_mock_geoip, _mock_bin):
     pw_cm, pw, context = _make_mock_async_pw_and_context()
     original_close = context.close
 
-    with patch("patchright.async_api.async_playwright", return_value=pw_cm):
+    with patch("playwright.async_api.async_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context_async
         ctx = await launch_persistent_context_async("/tmp/profile")
 
@@ -250,7 +250,7 @@ async def test_persistent_context_async_timezone_id_deprecation(_mock_bin):
     """Deprecated timezone_id kwarg migrated with warning in async path."""
     pw_cm, pw, context = _make_mock_async_pw_and_context()
 
-    with patch("patchright.async_api.async_playwright", return_value=pw_cm):
+    with patch("playwright.async_api.async_playwright", return_value=pw_cm):
         from cloakbrowser.browser import launch_persistent_context_async
         with warnings.catch_warnings(record=True) as w:
             warnings.simplefilter("always")