From 95a98b6747d195ad98c259eb71d0241a7bdcd6ca Mon Sep 17 00:00:00 2001 From: "@aaronjmars" <61592645+aaronjmars@users.noreply.github.com> Date: Tue, 12 May 2026 09:53:31 -0400 Subject: [PATCH] fix(security): isolate workflow_dispatch input to avoid shell injection in attest-release (#223) Security hardening: route workflow_dispatch input through env var to prevent shell injection in attest-release workflow. --- .github/workflows/attest-release.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/attest-release.yml b/.github/workflows/attest-release.yml index 0a3a4e9..4228b7f 100644 --- a/.github/workflows/attest-release.yml +++ b/.github/workflows/attest-release.yml @@ -16,9 +16,10 @@ jobs: contents: write # Download release assets steps: - name: Download release binaries - run: gh release download ${{ github.event.inputs.tag }} --repo CloakHQ/cloakbrowser --pattern "cloakbrowser-*.tar.gz" --pattern "cloakbrowser-*.zip" + run: gh release download "$RELEASE_TAG" --repo CloakHQ/cloakbrowser --pattern "cloakbrowser-*.tar.gz" --pattern "cloakbrowser-*.zip" env: GH_TOKEN: ${{ github.token }} + RELEASE_TAG: ${{ github.event.inputs.tag }} - name: Attest build provenance uses: actions/attest-build-provenance@a2bbfa25375fe432b6a289bc6b6cd05ecd0c4c32 # v4.1.0