fix: review fixes — bump CHROMIUM_VERSION to v145, add colorScheme to JS, guard download fallback

cloakbrowser/browser.py

@@ -15,7 +15,7 @@ Usage:
 from __future__ import annotations
 
 import logging
-from typing import Any
+from typing import Any, Literal
 from urllib.parse import unquote, urlparse, urlunparse
 
 from .config import DEFAULT_VIEWPORT, get_default_stealth_args
@@ -168,7 +168,7 @@ def launch_context(
     viewport: dict | None = None,
     locale: str | None = None,
     timezone_id: str | None = None,
-    color_scheme: str | None = None,
+    color_scheme: Literal["light", "dark", "no-preference"] | None = None,
     geoip: bool = False,
     **kwargs: Any,
 ) -> Any:

cloakbrowser/config.py

@@ -12,7 +12,7 @@ from ._version import __version__
 # ---------------------------------------------------------------------------
 # Chromium version shipped with this release
 # ---------------------------------------------------------------------------
-CHROMIUM_VERSION = "142.0.7444.175"
+CHROMIUM_VERSION = "145.0.7632.109"
 
 # ---------------------------------------------------------------------------
 # Default stealth arguments passed to the patched Chromium binary.

cloakbrowser/download.py

@@ -121,10 +121,12 @@ def _download_and_extract(version: str | None = None) -> None:
         tmp_path = Path(tmp.name)
 
     try:
-        # Try primary, fall back to GitHub Releases
+        # Try primary, fall back to GitHub Releases (skip fallback if custom URL)
         try:
             _download_file(primary_url, tmp_path)
         except Exception as primary_err:
+            if os.environ.get("CLOAKBROWSER_DOWNLOAD_URL"):
+                raise
             logger.warning(
                 "Primary download failed (%s), trying GitHub Releases...",
                 primary_err,

js/src/config.ts

@@ -10,7 +10,7 @@ import path from "node:path";
 // ---------------------------------------------------------------------------
 // Chromium version shipped with this release
 // ---------------------------------------------------------------------------
-export const CHROMIUM_VERSION = "142.0.7444.175";
+export const CHROMIUM_VERSION = "145.0.7632.109";
 
 // ---------------------------------------------------------------------------
 // Platform detection

js/src/download.ts

@@ -151,10 +151,13 @@ async function downloadAndExtract(version?: string): Promise<void> {
   );
 
   try {
-    // Try primary server, fall back to GitHub Releases
+    // Try primary server, fall back to GitHub Releases (skip fallback if custom URL)
     try {
       await downloadFile(primaryUrl, tmpPath);
     } catch (primaryErr) {
+      if (process.env.CLOAKBROWSER_DOWNLOAD_URL) {
+        throw primaryErr;
+      }
       console.warn(
         `[cloakbrowser] Primary download failed (${primaryErr instanceof Error ? primaryErr.message : primaryErr}), trying GitHub Releases...`
       );

js/src/playwright.ts

@@ -71,6 +71,7 @@ export async function launchContext(
       viewport: options.viewport ?? DEFAULT_VIEWPORT,
       ...(resolved.locale ? { locale: resolved.locale } : {}),
       ...(resolved.timezone ? { timezoneId: resolved.timezone } : {}),
+      ...(options.colorScheme ? { colorScheme: options.colorScheme } : {}),
     });
   } catch (err) {
     await browser.close();

js/src/types.ts

@@ -30,6 +30,8 @@ export interface LaunchContextOptions extends LaunchOptions {
   locale?: string;
   /** Timezone, e.g. "America/New_York". */
   timezoneId?: string;
+  /** Color scheme preference — 'light', 'dark', or 'no-preference'. */
+  colorScheme?: "light" | "dark" | "no-preference";
 }
 
 export interface BinaryInfo {