fix: review fixes — bump CHROMIUM_VERSION to v145, add colorScheme to JS, guard download fallback

This commit is contained in:
CloakHQ
2026-03-02 02:59:23 +01:00
parent f417fe2530
commit 8eb666885f
7 changed files with 14 additions and 6 deletions
+1 -1
View File
@@ -10,7 +10,7 @@ import path from "node:path";
// ---------------------------------------------------------------------------
// Chromium version shipped with this release
// ---------------------------------------------------------------------------
export const CHROMIUM_VERSION = "142.0.7444.175";
export const CHROMIUM_VERSION = "145.0.7632.109";
// ---------------------------------------------------------------------------
// Platform detection
+4 -1
View File
@@ -151,10 +151,13 @@ async function downloadAndExtract(version?: string): Promise<void> {
);
try {
// Try primary server, fall back to GitHub Releases
// Try primary server, fall back to GitHub Releases (skip fallback if custom URL)
try {
await downloadFile(primaryUrl, tmpPath);
} catch (primaryErr) {
if (process.env.CLOAKBROWSER_DOWNLOAD_URL) {
throw primaryErr;
}
console.warn(
`[cloakbrowser] Primary download failed (${primaryErr instanceof Error ? primaryErr.message : primaryErr}), trying GitHub Releases...`
);
+1
View File
@@ -71,6 +71,7 @@ export async function launchContext(
viewport: options.viewport ?? DEFAULT_VIEWPORT,
...(resolved.locale ? { locale: resolved.locale } : {}),
...(resolved.timezone ? { timezoneId: resolved.timezone } : {}),
...(options.colorScheme ? { colorScheme: options.colorScheme } : {}),
});
} catch (err) {
await browser.close();
+2
View File
@@ -30,6 +30,8 @@ export interface LaunchContextOptions extends LaunchOptions {
locale?: string;
/** Timezone, e.g. "America/New_York". */
timezoneId?: string;
/** Color scheme preference — 'light', 'dark', or 'no-preference'. */
colorScheme?: "light" | "dark" | "no-preference";
}
export interface BinaryInfo {