mirror of
https://github.com/bmadcode/BMAD-METHOD.git
synced 2025-12-19 02:35:31 +00:00
## Overview
This commit represents a complete overhaul of the BMAD agent creation system, establishing clear standards for agent development, installation workflows, and persona design. The changes span documentation, tooling, reference implementations, and field-specific guidance.
## Key Components
### 1. Agent Installation Infrastructure
**New CLI Command: `agent-install`**
- Interactive agent installation with persona customization
- Supports Simple (single YAML), Expert (sidecar files), and Module agents
- Template variable processing with Handlebars-style syntax
- Automatic compilation from YAML to XML (.md) format
- Manifest tracking and IDE integration (Claude Code, Cursor, Windsurf, etc.)
- Source preservation in `_cfg/custom/agents/` for reinstallation
**Files Created:**
- `tools/cli/commands/agent-install.js` - Main CLI command
- `tools/cli/lib/agent/compiler.js` - YAML to XML compilation engine
- `tools/cli/lib/agent/installer.js` - Installation orchestration
- `tools/cli/lib/agent/template-engine.js` - Handlebars template processing
**Compiler Features:**
- Auto-injects frontmatter, activation, handlers, help/exit menu items
- Smart handler inclusion (only includes action/workflow/exec/tmpl handlers actually used)
- Proper XML escaping and formatting
- Persona name customization (e.g., "Fred the Commit Poet")
### 2. Documentation Overhaul
**Deleted Bloated/Outdated Docs (2,651 lines removed):**
- Old verbose architecture docs
- Redundant pattern files
- Outdated workflow guides
**Created Focused, Type-Specific Docs:**
- `src/modules/bmb/docs/understanding-agent-types.md` - Architecture vs capability distinction
- `src/modules/bmb/docs/simple-agent-architecture.md` - Self-contained agents
- `src/modules/bmb/docs/expert-agent-architecture.md` - Agents with sidecar files
- `src/modules/bmb/docs/module-agent-architecture.md` - Workflow-integrated agents
- `src/modules/bmb/docs/agent-compilation.md` - YAML → XML process
- `src/modules/bmb/docs/agent-menu-patterns.md` - Menu design patterns
- `src/modules/bmb/docs/index.md` - Documentation hub
**Net Result:** ~1,930 line reduction while adding MORE value through focused content
### 3. Create-Agent Workflow Enhancements
**Critical Persona Field Guidance Added to Step 4:**
Explains how the LLM interprets each persona field when the agent activates:
- **role** → "What knowledge, skills, and capabilities do I possess?"
- **identity** → "What background, experience, and context shape my responses?"
- **communication_style** → "What verbal patterns, word choice, quirks, and phrasing do I use?"
- **principles** → "What beliefs and operating philosophy drive my choices?"
**Key Insight:** `communication_style` should ONLY describe HOW the agent talks, not restate role/identity/principles. The `communication-presets.csv` provides 60 pure communication styles with NO role/identity/principles mixed in.
**Files Updated:**
- `src/modules/bmb/workflows/create-agent/instructions.md` - Added persona field interpretation guide
- `src/modules/bmb/workflows/create-agent/brainstorm-context.md` - Refined to 137 lines
- `src/modules/bmb/workflows/create-agent/communication-presets.csv` - 60 styles across 13 categories
### 4. Reference Agent Cleanup
**Removed install_config Personality Bloat:**
Understanding: Future installer will handle personality customization, so stripped all personality toggles from reference agents.
**commit-poet.agent.yaml** (Simple Agent):
- BEFORE: 36 personality combinations (3 enthusiasm × 3 depths × 4 styles) = decision fatigue
- AFTER: Single concise persona with pure communication style
- Changed from verbose conditionals to: "Poetic drama and flair with every turn of a phrase. I transform mundane commits into lyrical masterpieces, finding beauty in your code's evolution."
- Reduction: 248 lines → 153 lines (38% reduction)
**journal-keeper.agent.yaml** (Expert Agent):
- Stripped install_config, simplified communication_style
- Shows proper Expert agent structure with sidecar files
**security-engineer.agent.yaml & trend-analyst.agent.yaml** (Module Agents):
- Added header comments explaining WHY Module Agent (design intent, not just location)
- Clarified: Module agents are designed FOR ecosystem integration, not capability-limited
**Files Updated:**
- `src/modules/bmb/reference/agents/simple-examples/commit-poet.agent.yaml`
- `src/modules/bmb/reference/agents/expert-examples/journal-keeper/journal-keeper.agent.yaml`
- `src/modules/bmb/reference/agents/module-examples/security-engineer.agent.yaml`
- `src/modules/bmb/reference/agents/module-examples/trend-analyst.agent.yaml`
### 5. BMM Agent Voice Enhancement
**Gave all 9 BMM agents distinct, memorable communication voices:**
**Mary (analyst)** - The favorite! Changed from generic "systematic and probing" to:
"Treats analysis like a treasure hunt - excited by every clue, thrilled when patterns emerge. Asks questions that spark 'aha!' moments while structuring insights with precision."
**Other Notable Voices:**
- **John (pm):** "Asks 'WHY?' relentlessly like a detective on a case. Direct and data-sharp, cuts through fluff to what actually matters."
- **Winston (architect):** "Speaks in calm, pragmatic tones, balancing 'what could be' with 'what should be.' Champions boring technology that actually works."
- **Amelia (dev):** "Ultra-succinct. Speaks in file paths and AC IDs - every statement citable. No fluff, all precision."
- **Bob (sm):** "Crisp and checklist-driven. Every word has a purpose, every requirement crystal clear. Zero tolerance for ambiguity."
- **Sally (ux-designer):** "Paints pictures with words, telling user stories that make you FEEL the problem. Empathetic advocate with creative storytelling flair."
**Pattern Applied:** Moved behaviors from communication_style to principles, keeping communication_style as PURE verbal patterns.
**Files Updated:**
- `src/modules/bmm/agents/analyst.agent.yaml`
- `src/modules/bmm/agents/pm.agent.yaml`
- `src/modules/bmm/agents/architect.agent.yaml`
- `src/modules/bmm/agents/dev.agent.yaml`
- `src/modules/bmm/agents/sm.agent.yaml`
- `src/modules/bmm/agents/tea.agent.yaml`
- `src/modules/bmm/agents/tech-writer.agent.yaml`
- `src/modules/bmm/agents/ux-designer.agent.yaml`
- `src/modules/bmm/agents/frame-expert.agent.yaml`
### 6. Linting Fixes
**ESLint Compliance:**
- Replaced all `'utf-8'` with `'utf8'` (unicorn/text-encoding-identifier-case)
- Changed `variables.hasOwnProperty(varName)` to `Object.hasOwn(variables, varName)` (unicorn/prefer-object-has-own)
- Replaced `JSON.parse(JSON.stringify(...))` with `structuredClone(...)` (unicorn/prefer-structured-clone)
- Fixed empty YAML mapping values in sample files
**Files Fixed:**
- 7 JavaScript files across agent tooling (compiler, installer, commands, IDE integration)
- 1 YAML sample file
## Architecture Decisions
### Agent Types Are About Architecture, Not Capability
- **Simple:** Self-contained in single YAML (NOT limited in capability)
- **Expert:** Includes sidecar files (templates, docs, etc.)
- **Module:** Designed for BMAD ecosystem integration (workflows, cross-agent coordination)
### Persona Field Separation Critical for LLM Interpretation
The LLM needs distinct fields to understand its role:
- Mixing role/identity/principles into communication_style confuses the persona
- Pure communication styles (from communication-presets.csv) have ZERO role/identity/principles content
- Example DON'T: "Experienced analyst who uses systematic approaches..." (mixing identity + style)
- Example DO: "Systematic and probing. Structures findings hierarchically." (pure style)
### Install-Time vs Runtime Configuration
- Template variables ({{var}}) resolve at compile-time
- Runtime variables ({user_name}, {bmad_folder}) resolve when agent activates
- Future installer will handle personality customization, so agents should ship with single default persona
## Testing
- All linting passes (ESLint with max-warnings=0)
- Agent compilation tested with commit-poet, journal-keeper examples
- Install workflow validated with Simple and Expert agent types
- Manifest tracking and IDE integration verified
## Impact
This establishes BMAD as having a complete, production-ready agent creation and installation system with:
- Clear documentation for all agent types
- Automated compilation and installation
- Strong persona design guidance
- Reference implementations showing best practices
- Distinct, memorable agent voices throughout BMM module
Co-Authored-By: BMad Builder <builder@bmad.dev>
Co-Authored-By: Mary the Analyst <analyst@bmad.dev>
Co-Authored-By: Paige the Tech Writer <tech-writer@bmad.dev>
377 lines
12 KiB
JavaScript
377 lines
12 KiB
JavaScript
const path = require('node:path');
|
|
const { BaseIdeSetup } = require('./_base-ide');
|
|
const chalk = require('chalk');
|
|
const inquirer = require('inquirer');
|
|
const { AgentCommandGenerator } = require('./shared/agent-command-generator');
|
|
|
|
/**
|
|
* GitHub Copilot setup handler
|
|
* Creates chat modes in .github/chatmodes/ and configures VS Code settings
|
|
*/
|
|
class GitHubCopilotSetup extends BaseIdeSetup {
|
|
constructor() {
|
|
super('github-copilot', 'GitHub Copilot', true); // preferred IDE
|
|
this.configDir = '.github';
|
|
this.chatmodesDir = 'chatmodes';
|
|
this.vscodeDir = '.vscode';
|
|
}
|
|
|
|
/**
|
|
* Collect configuration choices before installation
|
|
* @param {Object} options - Configuration options
|
|
* @returns {Object} Collected configuration
|
|
*/
|
|
async collectConfiguration(options = {}) {
|
|
const config = {};
|
|
|
|
console.log('\n' + chalk.blue(' 🔧 VS Code Settings Configuration'));
|
|
console.log(chalk.dim(' GitHub Copilot works best with specific settings\n'));
|
|
|
|
const response = await inquirer.prompt([
|
|
{
|
|
type: 'list',
|
|
name: 'configChoice',
|
|
message: 'How would you like to configure VS Code settings?',
|
|
choices: [
|
|
{ name: 'Use recommended defaults (fastest)', value: 'defaults' },
|
|
{ name: 'Configure each setting manually', value: 'manual' },
|
|
{ name: 'Skip settings configuration', value: 'skip' },
|
|
],
|
|
default: 'defaults',
|
|
},
|
|
]);
|
|
config.vsCodeConfig = response.configChoice;
|
|
|
|
if (response.configChoice === 'manual') {
|
|
config.manualSettings = await inquirer.prompt([
|
|
{
|
|
type: 'input',
|
|
name: 'maxRequests',
|
|
message: 'Maximum requests per session (1-50)?',
|
|
default: '15',
|
|
validate: (input) => {
|
|
const num = parseInt(input);
|
|
return (num >= 1 && num <= 50) || 'Enter 1-50';
|
|
},
|
|
},
|
|
{
|
|
type: 'confirm',
|
|
name: 'runTasks',
|
|
message: 'Allow running workspace tasks?',
|
|
default: true,
|
|
},
|
|
{
|
|
type: 'confirm',
|
|
name: 'mcpDiscovery',
|
|
message: 'Enable MCP server discovery?',
|
|
default: true,
|
|
},
|
|
{
|
|
type: 'confirm',
|
|
name: 'autoFix',
|
|
message: 'Enable automatic error fixing?',
|
|
default: true,
|
|
},
|
|
{
|
|
type: 'confirm',
|
|
name: 'autoApprove',
|
|
message: 'Auto-approve tools (less secure)?',
|
|
default: false,
|
|
},
|
|
]);
|
|
}
|
|
|
|
return config;
|
|
}
|
|
|
|
/**
|
|
* Setup GitHub Copilot configuration
|
|
* @param {string} projectDir - Project directory
|
|
* @param {string} bmadDir - BMAD installation directory
|
|
* @param {Object} options - Setup options
|
|
*/
|
|
async setup(projectDir, bmadDir, options = {}) {
|
|
console.log(chalk.cyan(`Setting up ${this.name}...`));
|
|
|
|
// Configure VS Code settings using pre-collected config if available
|
|
const config = options.preCollectedConfig || {};
|
|
await this.configureVsCodeSettings(projectDir, { ...options, ...config });
|
|
|
|
// Create .github/chatmodes directory
|
|
const githubDir = path.join(projectDir, this.configDir);
|
|
const chatmodesDir = path.join(githubDir, this.chatmodesDir);
|
|
await this.ensureDir(chatmodesDir);
|
|
|
|
// Clean up any existing BMAD files before reinstalling
|
|
await this.cleanup(projectDir);
|
|
|
|
// Generate agent launchers
|
|
const agentGen = new AgentCommandGenerator(this.bmadFolderName);
|
|
const { artifacts: agentArtifacts } = await agentGen.collectAgentArtifacts(bmadDir, options.selectedModules || []);
|
|
|
|
// Create chat mode files with bmad- prefix
|
|
let modeCount = 0;
|
|
for (const artifact of agentArtifacts) {
|
|
const content = artifact.content;
|
|
const chatmodeContent = await this.createChatmodeContent({ module: artifact.module, name: artifact.name }, content);
|
|
|
|
// Use bmad- prefix: bmad-agent-{module}-{name}.chatmode.md
|
|
const targetPath = path.join(chatmodesDir, `bmad-agent-${artifact.module}-${artifact.name}.chatmode.md`);
|
|
await this.writeFile(targetPath, chatmodeContent);
|
|
modeCount++;
|
|
|
|
console.log(chalk.green(` ✓ Created chat mode: bmad-agent-${artifact.module}-${artifact.name}`));
|
|
}
|
|
|
|
console.log(chalk.green(`✓ ${this.name} configured:`));
|
|
console.log(chalk.dim(` - ${modeCount} chat modes created`));
|
|
console.log(chalk.dim(` - Chat modes directory: ${path.relative(projectDir, chatmodesDir)}`));
|
|
console.log(chalk.dim(` - VS Code settings configured`));
|
|
console.log(chalk.dim('\n Chat modes available in VS Code Chat view'));
|
|
|
|
return {
|
|
success: true,
|
|
chatmodes: modeCount,
|
|
settings: true,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Configure VS Code settings for GitHub Copilot
|
|
*/
|
|
async configureVsCodeSettings(projectDir, options) {
|
|
const fs = require('fs-extra');
|
|
const vscodeDir = path.join(projectDir, this.vscodeDir);
|
|
const settingsPath = path.join(vscodeDir, 'settings.json');
|
|
|
|
await this.ensureDir(vscodeDir);
|
|
|
|
// Read existing settings
|
|
let existingSettings = {};
|
|
if (await fs.pathExists(settingsPath)) {
|
|
try {
|
|
const content = await fs.readFile(settingsPath, 'utf8');
|
|
existingSettings = JSON.parse(content);
|
|
console.log(chalk.yellow(' Found existing .vscode/settings.json'));
|
|
} catch {
|
|
console.warn(chalk.yellow(' Could not parse settings.json, creating new'));
|
|
}
|
|
}
|
|
|
|
// Use pre-collected configuration or skip if not available
|
|
let configChoice = options.vsCodeConfig;
|
|
if (!configChoice) {
|
|
// If no pre-collected config, skip configuration
|
|
console.log(chalk.yellow(' ⚠ No configuration collected, skipping VS Code settings'));
|
|
return;
|
|
}
|
|
|
|
if (configChoice === 'skip') {
|
|
console.log(chalk.yellow(' ⚠ Skipping VS Code settings'));
|
|
return;
|
|
}
|
|
|
|
let bmadSettings = {};
|
|
|
|
if (configChoice === 'defaults') {
|
|
bmadSettings = {
|
|
'chat.agent.enabled': true,
|
|
'chat.agent.maxRequests': 15,
|
|
'github.copilot.chat.agent.runTasks': true,
|
|
'chat.mcp.discovery.enabled': true,
|
|
'github.copilot.chat.agent.autoFix': true,
|
|
'chat.tools.autoApprove': false,
|
|
};
|
|
console.log(chalk.green(' ✓ Using recommended defaults'));
|
|
} else {
|
|
// Manual configuration - use pre-collected settings
|
|
const manual = options.manualSettings || {};
|
|
|
|
bmadSettings = {
|
|
'chat.agent.enabled': true,
|
|
'chat.agent.maxRequests': parseInt(manual.maxRequests || 15),
|
|
'github.copilot.chat.agent.runTasks': manual.runTasks === undefined ? true : manual.runTasks,
|
|
'chat.mcp.discovery.enabled': manual.mcpDiscovery === undefined ? true : manual.mcpDiscovery,
|
|
'github.copilot.chat.agent.autoFix': manual.autoFix === undefined ? true : manual.autoFix,
|
|
'chat.tools.autoApprove': manual.autoApprove || false,
|
|
};
|
|
}
|
|
|
|
// Merge settings (existing take precedence)
|
|
const mergedSettings = { ...bmadSettings, ...existingSettings };
|
|
|
|
// Write settings
|
|
await fs.writeFile(settingsPath, JSON.stringify(mergedSettings, null, 2));
|
|
console.log(chalk.green(' ✓ VS Code settings configured'));
|
|
}
|
|
|
|
/**
|
|
* Create chat mode content
|
|
*/
|
|
async createChatmodeContent(agent, content) {
|
|
// Extract metadata from launcher frontmatter if present
|
|
const descMatch = content.match(/description:\s*"([^"]+)"/);
|
|
const title = descMatch ? descMatch[1] : this.formatTitle(agent.name);
|
|
|
|
const description = `Activates the ${title} agent persona.`;
|
|
|
|
// Strip any existing frontmatter from the content
|
|
const frontmatterRegex = /^---\s*\n[\s\S]*?\n---\s*\n/;
|
|
let cleanContent = content;
|
|
if (frontmatterRegex.test(content)) {
|
|
cleanContent = content.replace(frontmatterRegex, '').trim();
|
|
}
|
|
|
|
// Available GitHub Copilot tools (November 2025 - Official VS Code Documentation)
|
|
// Reference: https://code.visualstudio.com/docs/copilot/reference/copilot-vscode-features#_chat-tools
|
|
const tools = [
|
|
'changes', // List of source control changes
|
|
'codebase', // Perform code search in workspace
|
|
'createDirectory', // Create new directory in workspace
|
|
'createFile', // Create new file in workspace
|
|
'editFiles', // Apply edits to files in workspace
|
|
'fetch', // Fetch content from web page
|
|
'fileSearch', // Search files using glob patterns
|
|
'githubRepo', // Perform code search in GitHub repo
|
|
'listDirectory', // List files in a directory
|
|
'problems', // Add workspace issues from Problems panel
|
|
'readFile', // Read content of a file in workspace
|
|
'runInTerminal', // Run shell command in integrated terminal
|
|
'runTask', // Run existing task in workspace
|
|
'runTests', // Run unit tests in workspace
|
|
'runVscodeCommand', // Run VS Code command
|
|
'search', // Enable file searching in workspace
|
|
'searchResults', // Get search results from Search view
|
|
'terminalLastCommand', // Get last terminal command and output
|
|
'terminalSelection', // Get current terminal selection
|
|
'testFailure', // Get unit test failure information
|
|
'textSearch', // Find text in files
|
|
'usages', // Find references and navigate definitions
|
|
];
|
|
|
|
let chatmodeContent = `---
|
|
description: "${description.replaceAll('"', String.raw`\"`)}"
|
|
tools: ${JSON.stringify(tools)}
|
|
---
|
|
|
|
# ${title} Agent
|
|
|
|
${cleanContent}
|
|
|
|
`;
|
|
|
|
return chatmodeContent;
|
|
}
|
|
|
|
/**
|
|
* Format name as title
|
|
*/
|
|
formatTitle(name) {
|
|
return name
|
|
.split('-')
|
|
.map((word) => word.charAt(0).toUpperCase() + word.slice(1))
|
|
.join(' ');
|
|
}
|
|
|
|
/**
|
|
* Cleanup GitHub Copilot configuration - surgically remove only BMAD files
|
|
*/
|
|
async cleanup(projectDir) {
|
|
const fs = require('fs-extra');
|
|
const chatmodesDir = path.join(projectDir, this.configDir, this.chatmodesDir);
|
|
|
|
if (await fs.pathExists(chatmodesDir)) {
|
|
// Only remove files that start with bmad- prefix
|
|
const files = await fs.readdir(chatmodesDir);
|
|
let removed = 0;
|
|
|
|
for (const file of files) {
|
|
if (file.startsWith('bmad-') && file.endsWith('.chatmode.md')) {
|
|
await fs.remove(path.join(chatmodesDir, file));
|
|
removed++;
|
|
}
|
|
}
|
|
|
|
if (removed > 0) {
|
|
console.log(chalk.dim(` Cleaned up ${removed} existing BMAD chat modes`));
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Install a custom agent launcher for GitHub Copilot
|
|
* @param {string} projectDir - Project directory
|
|
* @param {string} agentName - Agent name (e.g., "fred-commit-poet")
|
|
* @param {string} agentPath - Path to compiled agent (relative to project root)
|
|
* @param {Object} metadata - Agent metadata
|
|
* @returns {Object|null} Info about created command
|
|
*/
|
|
async installCustomAgentLauncher(projectDir, agentName, agentPath, metadata) {
|
|
const chatmodesDir = path.join(projectDir, this.configDir, this.chatmodesDir);
|
|
|
|
if (!(await this.exists(path.join(projectDir, this.configDir)))) {
|
|
return null; // IDE not configured for this project
|
|
}
|
|
|
|
await this.ensureDir(chatmodesDir);
|
|
|
|
const launcherContent = `You must fully embody this agent's persona and follow all activation instructions exactly as specified. NEVER break character until given an exit command.
|
|
|
|
<agent-activation CRITICAL="TRUE">
|
|
1. LOAD the FULL agent file from @${agentPath}
|
|
2. READ its entire contents - this contains the complete agent persona, menu, and instructions
|
|
3. FOLLOW every step in the <activation> section precisely
|
|
4. DISPLAY the welcome/greeting as instructed
|
|
5. PRESENT the numbered menu
|
|
6. WAIT for user input before proceeding
|
|
</agent-activation>
|
|
`;
|
|
|
|
// GitHub Copilot needs specific tools in frontmatter
|
|
const copilotTools = [
|
|
'changes',
|
|
'codebase',
|
|
'createDirectory',
|
|
'createFile',
|
|
'editFiles',
|
|
'fetch',
|
|
'fileSearch',
|
|
'githubRepo',
|
|
'listDirectory',
|
|
'problems',
|
|
'readFile',
|
|
'runInTerminal',
|
|
'runTask',
|
|
'runTests',
|
|
'runVscodeCommand',
|
|
'search',
|
|
'searchResults',
|
|
'terminalLastCommand',
|
|
'terminalSelection',
|
|
'testFailure',
|
|
'textSearch',
|
|
'usages',
|
|
];
|
|
|
|
const chatmodeContent = `---
|
|
description: "Activates the ${metadata.title || agentName} agent persona."
|
|
tools: ${JSON.stringify(copilotTools)}
|
|
---
|
|
|
|
# ${metadata.title || agentName} Agent
|
|
|
|
${launcherContent}
|
|
`;
|
|
|
|
const chatmodePath = path.join(chatmodesDir, `bmad-agent-custom-${agentName}.chatmode.md`);
|
|
await this.writeFile(chatmodePath, chatmodeContent);
|
|
|
|
return {
|
|
path: chatmodePath,
|
|
command: `bmad-agent-custom-${agentName}`,
|
|
};
|
|
}
|
|
}
|
|
|
|
module.exports = { GitHubCopilotSetup };
|