fix(bmm): normalize story status references to lowercase kebab-case

Updated status references to use canonical lowercase kebab-case format:

- dev-story/instructions.xml: Status field set to "review" (was "Ready for Review")
- dev-story/instructions.xml: Output messages reference actual "review" status
- dev-story/checklist.md: Status field instruction uses "review"
- daily-standup.xml: Status examples use "in-progress, review"

Story lifecycle: backlog → ready-for-dev → in-progress → review → done

Fixes #1105

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Alex Verkhovsky 2025-12-11 23:20:29 -07:00
parent ed0defbe08
commit 7a9f1d4a3c
3 changed files with 7 additions and 7 deletions

View File

@ -10,7 +10,7 @@
<step n="1" title="Project Context Discovery"> <step n="1" title="Project Context Discovery">
<action>Check for stories folder at {project-root}{output_folder}/stories/</action> <action>Check for stories folder at {project-root}{output_folder}/stories/</action>
<action>Find current story by identifying highest numbered story file</action> <action>Find current story by identifying highest numbered story file</action>
<action>Read story status (In Progress, Ready for Review, etc.)</action> <action>Read story status (in-progress, review, etc.)</action>
<action>Extract agent notes from Dev Agent Record, TEA Results, PO Notes sections</action> <action>Extract agent notes from Dev Agent Record, TEA Results, PO Notes sections</action>
<action>Check for next story references from epics</action> <action>Check for next story references from epics</action>
<action>Identify blockers from story sections</action> <action>Identify blockers from story sections</action>

View File

@ -57,7 +57,7 @@ validation-rules:
## 🔚 Final Status Verification ## 🔚 Final Status Verification
- [ ] **Story Status Updated:** Story Status set to "Ready for Review" - [ ] **Story Status Updated:** Story Status set to "review"
- [ ] **Sprint Status Updated:** Sprint status updated to "review" (when sprint tracking is used) - [ ] **Sprint Status Updated:** Sprint status updated to "review" (when sprint tracking is used)
- [ ] **Quality Gates Passed:** All quality checks and validations completed successfully - [ ] **Quality Gates Passed:** All quality checks and validations completed successfully
- [ ] **No HALT Conditions:** No blocking issues or incomplete work remaining - [ ] **No HALT Conditions:** No blocking issues or incomplete work remaining

View File

@ -322,7 +322,7 @@
<action>Run the full regression suite (do not skip)</action> <action>Run the full regression suite (do not skip)</action>
<action>Confirm File List includes every changed file</action> <action>Confirm File List includes every changed file</action>
<action>Execute enhanced definition-of-done validation</action> <action>Execute enhanced definition-of-done validation</action>
<action>Update the story Status to: "Ready for Review"</action> <action>Update the story Status to: "review"</action>
<!-- Enhanced Definition of Done Validation --> <!-- Enhanced Definition of Done Validation -->
<action>Validate definition-of-done checklist with essential requirements: <action>Validate definition-of-done checklist with essential requirements:
@ -346,17 +346,17 @@
<action>Verify current status is "in-progress" (expected previous state)</action> <action>Verify current status is "in-progress" (expected previous state)</action>
<action>Update development_status[{{story_key}}] = "review"</action> <action>Update development_status[{{story_key}}] = "review"</action>
<action>Save file, preserving ALL comments and structure including STATUS DEFINITIONS</action> <action>Save file, preserving ALL comments and structure including STATUS DEFINITIONS</action>
<output>✅ Story marked Ready for Review in sprint status</output> <output>✅ Story status updated to "review" in sprint-status.yaml</output>
</check> </check>
<check if="{sprint_status} file does NOT exist OR {{current_sprint_status}} == 'no-sprint-tracking'"> <check if="{sprint_status} file does NOT exist OR {{current_sprint_status}} == 'no-sprint-tracking'">
<output> Story marked Ready for Review in story file (no sprint tracking configured)</output> <output> Story status updated to "review" in story file (no sprint tracking configured)</output>
</check> </check>
<check if="story key not found in sprint status"> <check if="story key not found in sprint status">
<output>⚠️ Story file updated, but sprint-status update failed: {{story_key}} not found <output>⚠️ Story file updated, but sprint-status update failed: {{story_key}} not found
Story is marked Ready for Review in file, but sprint-status.yaml may be out of sync. Story status is set to "review" in file, but sprint-status.yaml may be out of sync.
</output> </output>
</check> </check>
@ -373,7 +373,7 @@
<action>Communicate to {user_name} that story implementation is complete and ready for review</action> <action>Communicate to {user_name} that story implementation is complete and ready for review</action>
<action>Summarize key accomplishments: story ID, story key, title, key changes made, tests added, files modified</action> <action>Summarize key accomplishments: story ID, story key, title, key changes made, tests added, files modified</action>
<action>Provide the story file path and current status (now "Ready for Review")</action> <action>Provide the story file path and current status (now "review")</action>
<action>Based on {user_skill_level}, ask if user needs any explanations about: <action>Based on {user_skill_level}, ask if user needs any explanations about:
- What was implemented and how it works - What was implemented and how it works