chore: addressed PR comments

This commit is contained in:
Murat Ozcan 2025-11-11 10:49:58 -06:00
parent 4b33badbaa
commit 0bda1ba31d
3 changed files with 15 additions and 12 deletions

View File

@ -149,7 +149,7 @@ jobs:
with: with:
repository: bmad-code-org/bmad-bundles repository: bmad-code-org/bmad-bundles
path: bmad-bundles path: bmad-bundles
token: ${{ secrets.BUNDLES_DEPLOY_KEY }} token: ${{ secrets.BUNDLES_PAT }}
- name: Update bundles - name: Update bundles
run: | run: |

View File

@ -61,9 +61,6 @@ jobs:
run: | run: |
sed -i 's/"version": ".*"/"version": "${{ steps.version.outputs.new_version }}"/' tools/installer/package.json sed -i 's/"version": ".*"/"version": "${{ steps.version.outputs.new_version }}"/' tools/installer/package.json
- name: Build project
run: npm run build
- name: Generate web bundles - name: Generate web bundles
run: npm run bundle run: npm run bundle

View File

@ -26,11 +26,13 @@ gh api repos/bmad-code-org/bmad-bundles/pages --method POST -f source[branch]=ma
# (Optional) confirm status # (Optional) confirm status
gh api repos/bmad-code-org/bmad-bundles/pages --jq '{status,source}' gh api repos/bmad-code-org/bmad-bundles/pages --jq '{status,source}'
# 4. Create deploy key # 4. Create GitHub PAT and add as secret
ssh-keygen -t ed25519 -C "github-actions" -f deploy-key -N "" # Go to: https://github.com/settings/tokens/new
gh repo deploy-key add deploy-key.pub --repo bmad-code-org/bmad-bundles --title "CI" --allow-write # Scopes: repo (full control)
gh secret set BUNDLES_DEPLOY_KEY --repo bmad-code-org/BMAD-METHOD < deploy-key # Name: bmad-bundles-ci
rm deploy-key* # Then add as secret:
gh secret set BUNDLES_PAT --repo bmad-code-org/BMAD-METHOD
# (paste PAT when prompted)
``` ```
If the Pages POST returns `409`, the site already exists. If it returns `422` about `main` missing, redo step 2 to push the initial commit. If the Pages POST returns `409`, the site already exists. If it returns `422` about `main` missing, redo step 2 to push the initial commit.
@ -43,7 +45,7 @@ If the Pages POST returns `409`, the site already exists. If it returns `422` ab
**On main merge:** **On main merge:**
- `.github/workflows/bundle-latest.yml` runs - `.github/workflows/bundle-latest.yaml` runs
- Publishes to: `https://bmad-code-org.github.io/bmad-bundles/` - Publishes to: `https://bmad-code-org.github.io/bmad-bundles/`
**On release:** **On release:**
@ -69,10 +71,14 @@ npm run release:patch
## Troubleshooting ## Troubleshooting
**"Permission denied (publickey)"** **"Permission denied" or auth errors**
```bash ```bash
gh secret list --repo bmad-code-org/BMAD-METHOD | grep BUNDLES # Verify PAT secret exists
gh secret list --repo bmad-code-org/BMAD-METHOD | grep BUNDLES_PAT
# If missing, recreate PAT and add secret:
gh secret set BUNDLES_PAT --repo bmad-code-org/BMAD-METHOD
``` ```
**GitHub Pages not updating / need to re-check config** **GitHub Pages not updating / need to re-check config**