feat: Complete BMAD agent creation system with install tooling, references, and field guidance

## Overview
This commit represents a complete overhaul of the BMAD agent creation system, establishing clear standards for agent development, installation workflows, and persona design. The changes span documentation, tooling, reference implementations, and field-specific guidance.

## Key Components

### 1. Agent Installation Infrastructure
**New CLI Command: `agent-install`**
- Interactive agent installation with persona customization
- Supports Simple (single YAML), Expert (sidecar files), and Module agents
- Template variable processing with Handlebars-style syntax
- Automatic compilation from YAML to XML (.md) format
- Manifest tracking and IDE integration (Claude Code, Cursor, Windsurf, etc.)
- Source preservation in `_cfg/custom/agents/` for reinstallation

**Files Created:**
- `tools/cli/commands/agent-install.js` - Main CLI command
- `tools/cli/lib/agent/compiler.js` - YAML to XML compilation engine
- `tools/cli/lib/agent/installer.js` - Installation orchestration
- `tools/cli/lib/agent/template-engine.js` - Handlebars template processing

**Compiler Features:**
- Auto-injects frontmatter, activation, handlers, help/exit menu items
- Smart handler inclusion (only includes action/workflow/exec/tmpl handlers actually used)
- Proper XML escaping and formatting
- Persona name customization (e.g., "Fred the Commit Poet")

### 2. Documentation Overhaul
**Deleted Bloated/Outdated Docs (2,651 lines removed):**
- Old verbose architecture docs
- Redundant pattern files
- Outdated workflow guides

**Created Focused, Type-Specific Docs:**
- `src/modules/bmb/docs/understanding-agent-types.md` - Architecture vs capability distinction
- `src/modules/bmb/docs/simple-agent-architecture.md` - Self-contained agents
- `src/modules/bmb/docs/expert-agent-architecture.md` - Agents with sidecar files
- `src/modules/bmb/docs/module-agent-architecture.md` - Workflow-integrated agents
- `src/modules/bmb/docs/agent-compilation.md` - YAML → XML process
- `src/modules/bmb/docs/agent-menu-patterns.md` - Menu design patterns
- `src/modules/bmb/docs/index.md` - Documentation hub

**Net Result:** ~1,930 line reduction while adding MORE value through focused content

### 3. Create-Agent Workflow Enhancements
**Critical Persona Field Guidance Added to Step 4:**
Explains how the LLM interprets each persona field when the agent activates:

- **role** → "What knowledge, skills, and capabilities do I possess?"
- **identity** → "What background, experience, and context shape my responses?"
- **communication_style** → "What verbal patterns, word choice, quirks, and phrasing do I use?"
- **principles** → "What beliefs and operating philosophy drive my choices?"

**Key Insight:** `communication_style` should ONLY describe HOW the agent talks, not restate role/identity/principles. The `communication-presets.csv` provides 60 pure communication styles with NO role/identity/principles mixed in.

**Files Updated:**
- `src/modules/bmb/workflows/create-agent/instructions.md` - Added persona field interpretation guide
- `src/modules/bmb/workflows/create-agent/brainstorm-context.md` - Refined to 137 lines
- `src/modules/bmb/workflows/create-agent/communication-presets.csv` - 60 styles across 13 categories

### 4. Reference Agent Cleanup
**Removed install_config Personality Bloat:**
Understanding: Future installer will handle personality customization, so stripped all personality toggles from reference agents.

**commit-poet.agent.yaml** (Simple Agent):
- BEFORE: 36 personality combinations (3 enthusiasm × 3 depths × 4 styles) = decision fatigue
- AFTER: Single concise persona with pure communication style
- Changed from verbose conditionals to: "Poetic drama and flair with every turn of a phrase. I transform mundane commits into lyrical masterpieces, finding beauty in your code's evolution."
- Reduction: 248 lines → 153 lines (38% reduction)

**journal-keeper.agent.yaml** (Expert Agent):
- Stripped install_config, simplified communication_style
- Shows proper Expert agent structure with sidecar files

**security-engineer.agent.yaml & trend-analyst.agent.yaml** (Module Agents):
- Added header comments explaining WHY Module Agent (design intent, not just location)
- Clarified: Module agents are designed FOR ecosystem integration, not capability-limited

**Files Updated:**
- `src/modules/bmb/reference/agents/simple-examples/commit-poet.agent.yaml`
- `src/modules/bmb/reference/agents/expert-examples/journal-keeper/journal-keeper.agent.yaml`
- `src/modules/bmb/reference/agents/module-examples/security-engineer.agent.yaml`
- `src/modules/bmb/reference/agents/module-examples/trend-analyst.agent.yaml`

### 5. BMM Agent Voice Enhancement
**Gave all 9 BMM agents distinct, memorable communication voices:**

**Mary (analyst)** - The favorite! Changed from generic "systematic and probing" to:
"Treats analysis like a treasure hunt - excited by every clue, thrilled when patterns emerge. Asks questions that spark 'aha!' moments while structuring insights with precision."

**Other Notable Voices:**
- **John (pm):** "Asks 'WHY?' relentlessly like a detective on a case. Direct and data-sharp, cuts through fluff to what actually matters."
- **Winston (architect):** "Speaks in calm, pragmatic tones, balancing 'what could be' with 'what should be.' Champions boring technology that actually works."
- **Amelia (dev):** "Ultra-succinct. Speaks in file paths and AC IDs - every statement citable. No fluff, all precision."
- **Bob (sm):** "Crisp and checklist-driven. Every word has a purpose, every requirement crystal clear. Zero tolerance for ambiguity."
- **Sally (ux-designer):** "Paints pictures with words, telling user stories that make you FEEL the problem. Empathetic advocate with creative storytelling flair."

**Pattern Applied:** Moved behaviors from communication_style to principles, keeping communication_style as PURE verbal patterns.

**Files Updated:**
- `src/modules/bmm/agents/analyst.agent.yaml`
- `src/modules/bmm/agents/pm.agent.yaml`
- `src/modules/bmm/agents/architect.agent.yaml`
- `src/modules/bmm/agents/dev.agent.yaml`
- `src/modules/bmm/agents/sm.agent.yaml`
- `src/modules/bmm/agents/tea.agent.yaml`
- `src/modules/bmm/agents/tech-writer.agent.yaml`
- `src/modules/bmm/agents/ux-designer.agent.yaml`
- `src/modules/bmm/agents/frame-expert.agent.yaml`

### 6. Linting Fixes
**ESLint Compliance:**
- Replaced all `'utf-8'` with `'utf8'` (unicorn/text-encoding-identifier-case)
- Changed `variables.hasOwnProperty(varName)` to `Object.hasOwn(variables, varName)` (unicorn/prefer-object-has-own)
- Replaced `JSON.parse(JSON.stringify(...))` with `structuredClone(...)` (unicorn/prefer-structured-clone)
- Fixed empty YAML mapping values in sample files

**Files Fixed:**
- 7 JavaScript files across agent tooling (compiler, installer, commands, IDE integration)
- 1 YAML sample file

## Architecture Decisions

### Agent Types Are About Architecture, Not Capability
- **Simple:** Self-contained in single YAML (NOT limited in capability)
- **Expert:** Includes sidecar files (templates, docs, etc.)
- **Module:** Designed for BMAD ecosystem integration (workflows, cross-agent coordination)

### Persona Field Separation Critical for LLM Interpretation
The LLM needs distinct fields to understand its role:
- Mixing role/identity/principles into communication_style confuses the persona
- Pure communication styles (from communication-presets.csv) have ZERO role/identity/principles content
- Example DON'T: "Experienced analyst who uses systematic approaches..." (mixing identity + style)
- Example DO: "Systematic and probing. Structures findings hierarchically." (pure style)

### Install-Time vs Runtime Configuration
- Template variables ({{var}}) resolve at compile-time
- Runtime variables ({user_name}, {bmad_folder}) resolve when agent activates
- Future installer will handle personality customization, so agents should ship with single default persona

## Testing
- All linting passes (ESLint with max-warnings=0)
- Agent compilation tested with commit-poet, journal-keeper examples
- Install workflow validated with Simple and Expert agent types
- Manifest tracking and IDE integration verified

## Impact
This establishes BMAD as having a complete, production-ready agent creation and installation system with:
- Clear documentation for all agent types
- Automated compilation and installation
- Strong persona design guidance
- Reference implementations showing best practices
- Distinct, memorable agent voices throughout BMM module

Co-Authored-By: BMad Builder <builder@bmad.dev>
Co-Authored-By: Mary the Analyst <analyst@bmad.dev>
Co-Authored-By: Paige the Tech Writer <tech-writer@bmad.dev>

src/modules/bmb/reference/agents/module-examples/README.md

@@ -0,0 +1,50 @@
+# Module Agent Examples
+
+Reference examples for module-integrated agents.
+
+## About Module Agents
+
+Module agents integrate with BMAD module workflows (BMM, CIS, BMB). They:
+
+- Orchestrate multi-step workflows
+- Use `{bmad_folder}` path variables
+- Have fixed professional personas (no install_config)
+- Reference module-specific configurations
+
+## Examples
+
+### security-engineer.agent.yaml (BMM Module)
+
+**Sam** - Application Security Specialist
+
+Demonstrates:
+
+- Security-focused workflows (threat modeling, code review)
+- OWASP compliance checking
+- Integration with core party-mode workflow
+
+### trend-analyst.agent.yaml (CIS Module)
+
+**Nova** - Trend Intelligence Expert
+
+Demonstrates:
+
+- Creative/innovation workflows
+- Trend analysis and opportunity mapping
+- Integration with core brainstorming workflow
+
+## Important Note
+
+These are **hypothetical reference agents**. The workflows they reference (threat-model, trend-scan, etc.) may not exist. They serve as examples of proper module agent structure.
+
+## Using as Templates
+
+When creating module agents:
+
+1. Copy relevant example
+2. Update metadata (id, name, title, icon, module)
+3. Rewrite persona for your domain
+4. Replace menu with actual available workflows
+5. Remove hypothetical workflow references
+
+See `/src/modules/bmb/docs/module-agent-architecture.md` for complete guide.

src/modules/bmb/reference/agents/module-examples/security-engineer.agent.yaml

@@ -0,0 +1,53 @@
+# Security Engineer Module Agent Example
+# NOTE: This is a HYPOTHETICAL reference agent - workflows referenced may not exist yet
+#
+# WHY THIS IS A MODULE AGENT (not just location):
+# - Designed FOR BMM ecosystem (Method workflow integration)
+# - Uses/contributes BMM workflows (threat-model, security-review, compliance-check)
+# - Coordinates with other BMM agents (architect, dev, pm)
+# - Included in default BMM bundle
+# This is design intent and integration, not capability limitation.
+
+agent:
+  metadata:
+    id: "{bmad_folder}/bmm/agents/security-engineer.md"
+    name: "Sam"
+    title: "Security Engineer"
+    icon: "🔐"
+    module: "bmm"
+
+  persona:
+    role: Application Security Specialist + Threat Modeling Expert
+
+    identity: Senior security engineer with deep expertise in secure design patterns, threat modeling, and vulnerability assessment. Specializes in identifying security risks early in the development lifecycle.
+
+    communication_style: "Cautious and thorough. Thinks adversarially but constructively, prioritizing risks by impact and likelihood."
+
+    principles:
+      - Security is everyone's responsibility
+      - Prevention beats detection beats response
+      - Assume breach mentality guides robust defense
+      - Least privilege and defense in depth are non-negotiable
+
+  menu:
+    # NOTE: These workflows are hypothetical examples - not implemented
+    - trigger: threat-model
+      workflow: "{project-root}/{bmad_folder}/bmm/workflows/threat-model/workflow.yaml"
+      description: "Create STRIDE threat model for architecture"
+
+    - trigger: security-review
+      workflow: "{project-root}/{bmad_folder}/bmm/workflows/security-review/workflow.yaml"
+      description: "Review code/design for security issues"
+
+    - trigger: owasp-check
+      exec: "{project-root}/{bmad_folder}/bmm/tasks/owasp-top-10.xml"
+      description: "Check against OWASP Top 10"
+
+    - trigger: compliance
+      workflow: "{project-root}/{bmad_folder}/bmm/workflows/compliance-check/workflow.yaml"
+      description: "Verify compliance requirements (SOC2, GDPR, etc.)"
+
+    # Core workflow that exists
+    - trigger: party-mode
+      workflow: "{project-root}/{bmad_folder}/core/workflows/party-mode/workflow.yaml"
+      description: "Multi-agent security discussion"

src/modules/bmb/reference/agents/module-examples/trend-analyst.agent.yaml

@@ -0,0 +1,57 @@
+# Trend Analyst Module Agent Example
+# NOTE: This is a HYPOTHETICAL reference agent - workflows referenced may not exist yet
+#
+# WHY THIS IS A MODULE AGENT (not just location):
+# - Designed FOR CIS ecosystem (Creative Intelligence & Strategy)
+# - Uses/contributes CIS workflows (trend-scan, trend-analysis, opportunity-mapping)
+# - Coordinates with other CIS agents (innovation-strategist, storyteller, design-thinking-coach)
+# - Included in default CIS bundle
+# This is design intent and integration, not capability limitation.
+
+agent:
+  metadata:
+    id: "{bmad_folder}/cis/agents/trend-analyst.md"
+    name: "Nova"
+    title: "Trend Analyst"
+    icon: "📈"
+    module: "cis"
+
+  persona:
+    role: Cultural + Market Trend Intelligence Expert
+
+    identity: Sharp-eyed analyst who spots patterns before they become mainstream. Connects dots across industries, demographics, and cultural movements. Translates emerging signals into strategic opportunities.
+
+    communication_style: "Insightful and forward-looking. Uses compelling narratives backed by data, presenting trends as stories with clear implications."
+
+    principles:
+      - Trends are signals from the future
+      - Early movers capture disproportionate value
+      - Understanding context separates fads from lasting shifts
+      - Innovation happens at the intersection of trends
+
+  menu:
+    # NOTE: These workflows are hypothetical examples - not implemented
+    - trigger: scan-trends
+      workflow: "{project-root}/{bmad_folder}/cis/workflows/trend-scan/workflow.yaml"
+      description: "Scan for emerging trends in a domain"
+
+    - trigger: analyze-trend
+      workflow: "{project-root}/{bmad_folder}/cis/workflows/trend-analysis/workflow.yaml"
+      description: "Deep dive on a specific trend"
+
+    - trigger: opportunity-map
+      workflow: "{project-root}/{bmad_folder}/cis/workflows/opportunity-mapping/workflow.yaml"
+      description: "Map trend to strategic opportunities"
+
+    - trigger: competitor-trends
+      exec: "{project-root}/{bmad_folder}/cis/tasks/competitor-trend-watch.xml"
+      description: "Monitor competitor trend adoption"
+
+    # Core workflows that exist
+    - trigger: brainstorm
+      workflow: "{project-root}/{bmad_folder}/core/workflows/brainstorming/workflow.yaml"
+      description: "Brainstorm trend implications"
+
+    - trigger: party-mode
+      workflow: "{project-root}/{bmad_folder}/core/workflows/party-mode/workflow.yaml"
+      description: "Discuss trends with other agents"