mirror of
https://github.com/bitsocialnet/5chan.git
synced 2026-08-03 07:41:04 +02:00
Apply the asymmetric viewport buffer that already fixed mobile to desktop
multiboard feeds, and trim per-post mount cost so remounts during scroll-up
are cheaper:
- Desktop multiboard buffer goes from {600,600} to {1200,2400} (top-heavy),
matching the mobile pattern from 99c0bbfac so items stay mounted longer
when scrolling back up
- Cache feed post height estimate by CID in pretext-height-estimates so
remounts skip the Pretext text-measurement work
- Memoize CommentMedia and switch its expanded-media-store reads to atomic
selectors so it stops rerendering on unrelated store changes
- Memoize useCommentMediaInfo return so its reference is stable for memo
comparators downstream
- Stop useFetchGifFirstFrame from forcing an extra render on every post
mount by bailing out of equivalent setState calls
- Extract PendingModerationActions out of PostInfo so the two
usePublishCommentModeration calls only run on the post page when
mod-approval is actually pending, not on every feed item
294 lines
8.9 KiB
TypeScript
294 lines
8.9 KiB
TypeScript
import * as React from 'react';
|
|
import { createElement } from 'react';
|
|
import { createRoot, type Root } from 'react-dom/client';
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
|
import CommentMedia from '../comment-media';
|
|
|
|
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
|
const act = (React as { act?: (cb: () => void | Promise<void>) => void | Promise<void> }).act as (cb: () => void | Promise<void>) => void | Promise<void>;
|
|
|
|
const testState = vi.hoisted(() => ({
|
|
canEmbed: false,
|
|
fitExpandedImagesToScreen: false,
|
|
getHasThumbnailResult: true,
|
|
gifFrameStatus: 'idle' as 'failed' | 'idle' | 'loading' | 'ready',
|
|
gifFrameUrl: null as string | null,
|
|
hostname: 'example.com',
|
|
isMobile: false,
|
|
unmuteExpandedVideoSound: false,
|
|
}));
|
|
|
|
vi.mock('react-i18next', () => ({
|
|
useTranslation: () => ({
|
|
t: (key: string) => key,
|
|
}),
|
|
}));
|
|
|
|
vi.mock('../../../lib/utils/media-utils', () => ({
|
|
getDisplayMediaInfoType: (type: string) => type,
|
|
getHasThumbnail: () => testState.getHasThumbnailResult,
|
|
getMediaDimensions: () => '640x480',
|
|
}));
|
|
|
|
vi.mock('../../../lib/utils/url-utils', () => ({
|
|
getHostname: () => testState.hostname,
|
|
}));
|
|
|
|
vi.mock('../../../stores/use-expanded-media-store', () => {
|
|
const getState = () => ({
|
|
fitExpandedImagesToScreen: testState.fitExpandedImagesToScreen,
|
|
unmuteExpandedVideoSound: testState.unmuteExpandedVideoSound,
|
|
});
|
|
return {
|
|
default: (selector?: (s: ReturnType<typeof getState>) => unknown) => (selector ? selector(getState()) : getState()),
|
|
};
|
|
});
|
|
|
|
vi.mock('../../../hooks/use-fetch-gif-first-frame', () => ({
|
|
default: () => ({
|
|
frameUrl: testState.gifFrameUrl,
|
|
status: testState.gifFrameStatus,
|
|
}),
|
|
}));
|
|
|
|
vi.mock('../../../hooks/use-is-mobile', () => ({
|
|
default: () => testState.isMobile,
|
|
}));
|
|
|
|
vi.mock('../../embed', () => ({
|
|
__esModule: true,
|
|
canEmbed: () => testState.canEmbed,
|
|
default: ({ url }: { url: string }) => createElement('div', { 'data-testid': 'embed' }, url),
|
|
}));
|
|
|
|
let container: HTMLDivElement;
|
|
let root: Root;
|
|
let setShowThumbnailMock: ReturnType<typeof vi.fn>;
|
|
|
|
const renderMedia = async (props: Record<string, unknown>) => {
|
|
await act(async () => {
|
|
root.render(createElement(CommentMedia, props as any));
|
|
});
|
|
};
|
|
|
|
describe('CommentMedia', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
testState.canEmbed = false;
|
|
testState.fitExpandedImagesToScreen = false;
|
|
testState.getHasThumbnailResult = true;
|
|
testState.gifFrameStatus = 'idle';
|
|
testState.gifFrameUrl = null;
|
|
testState.hostname = 'example.com';
|
|
testState.isMobile = false;
|
|
testState.unmuteExpandedVideoSound = false;
|
|
setShowThumbnailMock = vi.fn();
|
|
|
|
container = document.createElement('div');
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
});
|
|
|
|
afterEach(() => {
|
|
act(() => root.unmount());
|
|
container.remove();
|
|
});
|
|
|
|
it('toggles image expansion on mobile and renders the media metadata', async () => {
|
|
testState.isMobile = true;
|
|
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
linkHeight: 300,
|
|
linkWidth: 600,
|
|
type: 'image',
|
|
url: 'https://cdn.example.com/image.jpg',
|
|
},
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: true,
|
|
});
|
|
|
|
const image = container.querySelector('img[src="https://cdn.example.com/image.jpg"]');
|
|
expect(image).toBeTruthy();
|
|
expect(container.textContent).toContain('image');
|
|
|
|
await act(async () => {
|
|
image?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
|
});
|
|
|
|
expect(container.textContent).toContain('https://cdn.example.com/image');
|
|
expect(container.textContent).toContain('640x480');
|
|
});
|
|
|
|
it('falls back to the deleted-file placeholder when an image fails to load', async () => {
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
type: 'image',
|
|
url: 'https://cdn.example.com/missing.jpg',
|
|
},
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: true,
|
|
});
|
|
|
|
const image = container.querySelector('img[src="https://cdn.example.com/missing.jpg"]');
|
|
expect(image).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
image?.dispatchEvent(new Event('error', { bubbles: true }));
|
|
});
|
|
|
|
expect(container.querySelector('img[alt="File deleted"]')).toBeTruthy();
|
|
});
|
|
|
|
it('renders GIF thumbnail states and toggles the media view from the placeholder', async () => {
|
|
testState.isMobile = true;
|
|
testState.gifFrameStatus = 'loading';
|
|
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
type: 'gif',
|
|
url: 'https://cdn.example.com/animated.gif',
|
|
},
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: true,
|
|
});
|
|
|
|
const placeholder = container.querySelector('[aria-label="Loading GIF thumbnail"]');
|
|
expect(placeholder).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
placeholder?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
|
});
|
|
|
|
expect(setShowThumbnailMock).toHaveBeenCalledWith(false);
|
|
|
|
testState.gifFrameStatus = 'ready';
|
|
testState.gifFrameUrl = 'https://cdn.example.com/frame.png';
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
type: 'gif',
|
|
url: 'https://cdn.example.com/animated.gif',
|
|
},
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: true,
|
|
});
|
|
|
|
expect(container.textContent).toContain('animated gif');
|
|
expect(container.querySelector('img[src="https://cdn.example.com/frame.png"]')).toBeTruthy();
|
|
});
|
|
|
|
it('renders fallback embedded webpage links when there is no thumbnail', async () => {
|
|
testState.canEmbed = true;
|
|
testState.getHasThumbnailResult = false;
|
|
testState.isMobile = true;
|
|
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
type: 'webpage',
|
|
url: 'https://example.com/article',
|
|
},
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: true,
|
|
});
|
|
|
|
expect(container.textContent).toContain('example.com');
|
|
|
|
const fallbackButton = Array.from(container.querySelectorAll('span')).find((node) => node.textContent === 'example.com' && node.getAttribute('role') === 'button');
|
|
await act(async () => {
|
|
fallbackButton?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
|
});
|
|
|
|
expect(setShowThumbnailMock).toHaveBeenCalledWith(false);
|
|
});
|
|
|
|
it('renders the expanded embed view with a close button on mobile', async () => {
|
|
testState.isMobile = true;
|
|
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
patternThumbnailUrl: 'https://cdn.example.com/thumb.jpg',
|
|
type: 'iframe',
|
|
url: 'https://youtu.be/test',
|
|
},
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: false,
|
|
});
|
|
|
|
expect(container.querySelector('[data-testid="embed"]')?.textContent).toContain('https://youtu.be/test');
|
|
|
|
const closeButton = Array.from(container.querySelectorAll('span')).find((node) => node.textContent === 'close');
|
|
expect(closeButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
closeButton?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
|
});
|
|
|
|
expect(setShowThumbnailMock).toHaveBeenCalledWith(true);
|
|
});
|
|
|
|
it('renders deleted and spoiler thumbnails instead of the original media', async () => {
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
type: 'video',
|
|
url: 'https://cdn.example.com/video.mp4',
|
|
},
|
|
deleted: true,
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: true,
|
|
});
|
|
|
|
expect(container.querySelector('img[alt="File deleted"]')).toBeTruthy();
|
|
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
type: 'video',
|
|
url: 'https://cdn.example.com/video.mp4',
|
|
},
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: true,
|
|
spoiler: true,
|
|
});
|
|
|
|
const spoiler = container.querySelector('img[src="assets/spoiler.png"]');
|
|
expect(spoiler).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
spoiler?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
|
});
|
|
|
|
expect(setShowThumbnailMock).toHaveBeenCalledWith(false);
|
|
});
|
|
|
|
it('unmutes expanded videos when the preference is enabled', async () => {
|
|
testState.unmuteExpandedVideoSound = true;
|
|
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
type: 'video',
|
|
url: 'https://cdn.example.com/video.mp4',
|
|
},
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: false,
|
|
});
|
|
|
|
const video = container.querySelector<HTMLVideoElement>('video[src="https://cdn.example.com/video.mp4"]');
|
|
expect(video).toBeTruthy();
|
|
expect(video?.muted).toBe(false);
|
|
});
|
|
|
|
it('keeps expanded videos muted when the preference is disabled', async () => {
|
|
await renderMedia({
|
|
commentMediaInfo: {
|
|
type: 'video',
|
|
url: 'https://cdn.example.com/video.mp4',
|
|
},
|
|
setShowThumbnail: setShowThumbnailMock,
|
|
showThumbnail: false,
|
|
});
|
|
|
|
const video = container.querySelector<HTMLVideoElement>('video[src="https://cdn.example.com/video.mp4"]');
|
|
expect(video).toBeTruthy();
|
|
expect(video?.muted).toBe(true);
|
|
});
|
|
});
|