From bb54704a89f658aa2c23cc2d4bfe2975c7e53a91 Mon Sep 17 00:00:00 2001 From: Tom Date: Thu, 25 May 2023 21:03:17 +0200 Subject: [PATCH] fix eslint --- src/components/views/Board.jsx | 9 +++++---- src/components/views/Catalog.jsx | 6 +++--- src/components/views/Thread.jsx | 6 +++--- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/components/views/Board.jsx b/src/components/views/Board.jsx index cbe48770..4d38c8b3 100644 --- a/src/components/views/Board.jsx +++ b/src/components/views/Board.jsx @@ -114,11 +114,12 @@ const Board = () => { setOpenMenuCid(null); }; - const handleOutsideClick = (e) => { + const handleOutsideClick = useCallback((e) => { if (openMenuCid !== null && !postMenuRef.current.contains(e.target) && !postMenuCatalogRef.current.contains(e.target)) { setOpenMenuCid(null); } - }; + }, [openMenuCid, postMenuRef, postMenuCatalogRef]); + useEffect(() => { if (openMenuCid !== null) { @@ -130,7 +131,7 @@ const Board = () => { return () => { document.removeEventListener('click', handleOutsideClick); }; - }, [openMenuCid]); + }, [openMenuCid, handleOutsideClick]); @@ -458,7 +459,7 @@ const Board = () => { if (editedComment !== '') { setTriggerPublishCommentEdit(true); } - }, [editedComment]); + }, [editedComment, setIsAuthorEdit]); useEffect(() => { diff --git a/src/components/views/Catalog.jsx b/src/components/views/Catalog.jsx index 96d3bd0b..23e45ac8 100644 --- a/src/components/views/Catalog.jsx +++ b/src/components/views/Catalog.jsx @@ -103,11 +103,11 @@ const Catalog = () => { setOpenMenuCid(null); }; - const handleOutsideClick = (e) => { + const handleOutsideClick = useCallback((e) => { if (openMenuCid !== null && !postMenuRef.current.contains(e.target) && !postMenuCatalogRef.current.contains(e.target)) { setOpenMenuCid(null); } - }; + }, [openMenuCid, postMenuRef, postMenuCatalogRef]); useEffect(() => { if (openMenuCid !== null) { @@ -119,7 +119,7 @@ const Catalog = () => { return () => { document.removeEventListener('click', handleOutsideClick); }; - }, [openMenuCid]); + }, [openMenuCid, handleOutsideClick]); diff --git a/src/components/views/Thread.jsx b/src/components/views/Thread.jsx index f6646f04..55479fce 100644 --- a/src/components/views/Thread.jsx +++ b/src/components/views/Thread.jsx @@ -116,11 +116,11 @@ const Thread = () => { setOpenMenuCid(null); }; - const handleOutsideClick = (e) => { + const handleOutsideClick = useCallback((e) => { if (openMenuCid !== null && !postMenuRef.current.contains(e.target) && !postMenuCatalogRef.current.contains(e.target)) { setOpenMenuCid(null); } - }; + }, [openMenuCid, postMenuRef, postMenuCatalogRef]); useEffect(() => { if (openMenuCid !== null) { @@ -132,7 +132,7 @@ const Thread = () => { return () => { document.removeEventListener('click', handleOutsideClick); }; - }, [openMenuCid]); + }, [openMenuCid, handleOutsideClick]); useEffect(() => {