feat(rules page): rebuild directory rules page with vendored lists (#1147)

* feat(rules page): rebuild directory rules page with vendored lists

Mirror per-directory JSON from lists into src/data/5chan-directories, rework /rules layout to match 4chan (sidebar nav, category boxes, P2P load), and keep spoiler markup visible in rule text via parseSpoilers.

* fix(rules): keep directory defaults cache atomic

* fix(rules): derive defaults from shared directory refresh

* fix(rules): address directory refresh edge cases
This commit is contained in:
Tommaso Casaburi
2026-05-31 11:39:40 +07:00
committed by GitHub
parent e4638ac8c7
commit b442e05191
75 changed files with 2853 additions and 1333 deletions
+191 -75
View File
@@ -1,10 +1,10 @@
import { useEffect, useState, FormEvent } from 'react';
import { useNavigate, useParams } from 'react-router-dom';
import { Fragment, useEffect, useRef, useState, FormEvent } from 'react';
import { Link, useParams } from 'react-router-dom';
import { useCommunity } from '@bitsocial/bitsocial-react-hooks';
import { Footer, HomeLogo } from '../home';
import { useDirectories, DirectoryCommunity, findDirectoryByAddress } from '../../hooks/use-directories';
import { useDirectories, useDirectoryDefaults, DirectoryCommunity, DirectoryDefaultsData } from '../../hooks/use-directories';
import { useCommunityIdentifier } from '../../hooks/use-community-identifiers';
import { getCommunityAddress, getBoardPath } from '../../lib/utils/route-utils';
import { getCommunityAddress, getBoardPath, isDirectoryRoute } from '../../lib/utils/route-utils';
import Markdown from '../../components/markdown';
import LoadingEllipsis from '../../components/loading-ellipsis';
import useStateString from '../../hooks/use-state-string';
@@ -12,6 +12,12 @@ import styles from './rules.module.css';
import { useTranslation } from 'react-i18next';
import lowerCase from 'lodash/lowerCase';
interface CategoryGroup {
key: string;
label: string;
communities: DirectoryCommunity[];
}
const getBoardShortCode = (title?: string): string => {
if (!title) return '';
const match = title.match(/^\/([^/]+)\//);
@@ -24,31 +30,128 @@ const getBoardName = (title?: string): string => {
return match ? match[1] : title;
};
const BoardRulesDisplay = ({ communityAddress, directories }: { communityAddress: string; directories: DirectoryCommunity[] }) => {
const getDirectoryCode = (community: DirectoryCommunity): string => community.directoryCode ?? getBoardShortCode(community.title);
const getDirectoryDisplayTitle = (community: DirectoryCommunity): string => {
const shortCode = getDirectoryCode(community);
const boardName = getBoardName(community.title);
if (shortCode && boardName) {
return `/${shortCode}/ - ${boardName}`;
}
return community.title ?? community.address;
};
const getDirectoryRules = (defaults: DirectoryDefaultsData, code: string): string[] => (code ? (defaults.directories[code]?.rules ?? []) : []);
// Upload boards (e.g. /f/ - Flash) require post flairs/tagging on uploads; everything else is an image board, mirroring 4chan's split.
const isUploadDirectory = (defaults: DirectoryDefaultsData, code: string): boolean => !!defaults.directories[code]?.features?.postFlairs;
// Split the directories into ordered category groups (image boards first, then upload boards), dropping empty ones.
const groupDirectoriesByCategory = (directories: DirectoryCommunity[], defaults: DirectoryDefaultsData): CategoryGroup[] =>
[
{ key: 'image', label: 'Image Boards' },
{ key: 'upload', label: 'Upload Boards' },
]
.map(({ key, label }) => ({
key,
label,
communities: directories.filter((community) => (key === 'upload') === isUploadDirectory(defaults, getDirectoryCode(community))),
}))
.filter((group) => group.communities.length > 0);
// Resolve a /rules/:boardIdentifier segment (directory code or board address) to a directory code.
const resolveDirectoryCode = (identifier: string, directories: DirectoryCommunity[]): string | null => {
if (isDirectoryRoute(identifier, directories)) {
return identifier;
}
const code = getBoardPath(getCommunityAddress(identifier, directories), directories);
return isDirectoryRoute(code, directories) ? code : null;
};
// A single directory's rules (h3 title + ordered rules), anchored by code for deep-link scrolling.
const DirectorySection = ({ community, rules }: { community: DirectoryCommunity; rules: string[] }) => {
const code = getDirectoryCode(community);
return (
<div id={code || undefined}>
<h3 className={styles.directoryTitle}>{getDirectoryDisplayTitle(community)}</h3>
{rules.length > 0 ? (
<ol>
{rules.map((rule, index) => (
<li key={`${index}-${rule}`}>
<Markdown content={rule} parseSpoilers={false} />
</li>
))}
</ol>
) : (
<p>
<em>This directory has no specific rules.</em>
</p>
)}
</div>
);
};
// Directory rules come straight from the directories JSON (defaults), so a whole category renders at once without a P2P fetch.
const CategoryRulesBox = ({ group, defaults }: { group: CategoryGroup; defaults: DirectoryDefaultsData }) => (
<div className={`${styles.box} ${styles.rulesBox}`} id={`category-${group.key}`}>
<div className={styles.boxBar}>
<h2 className={styles.rulesBoxTitle}>{group.label}</h2>
</div>
<div className={styles.boxContent}>
{group.communities.map((community, index) => (
<Fragment key={community.address}>
<DirectorySection community={community} rules={getDirectoryRules(defaults, getDirectoryCode(community))} />
{/* Separator below each entry except the last (matches 4chan's <hr> between board rules). */}
{index < group.communities.length - 1 && <hr className={styles.directoryDivider} />}
</Fragment>
))}
</div>
</div>
);
// Quick-jump nav (left column) grouped by category; clicking a directory insta-scrolls to its rules via /rules/:code.
const DirectoryNav = ({ groups }: { groups: CategoryGroup[] }) => (
<div className={`${styles.box} ${styles.selectorBox}`}>
<div className={styles.boxBar}>
<h2 className={styles.selectorBoxTitle}>Directories</h2>
</div>
<div className={styles.boxContent}>
<nav className={styles.directoryNav}>
<ul>
{groups.map((group) => (
<li key={group.key}>
{/* Button (not an anchor) so the HashRouter route hash is preserved while still scrolling to the category. */}
<button type='button' className={styles.directoryNavHeader} onClick={() => document.getElementById(`category-${group.key}`)?.scrollIntoView()}>
{group.label}
</button>
<ul>
{group.communities.map((community) => {
const code = getDirectoryCode(community);
return (
<li key={community.address}>
<Link to={`/rules/${code}`}>{getBoardName(community.title) || getDirectoryDisplayTitle(community)}</Link>
</li>
);
})}
</ul>
</li>
))}
</ul>
</nav>
</div>
</div>
);
// P2P board rules: fetched live from peers for an arbitrary board address.
const BoardRulesDisplay = ({ communityAddress }: { communityAddress: string }) => {
const { t } = useTranslation();
const communityIdentifier = useCommunityIdentifier(communityAddress);
const community = useCommunity(communityIdentifier ? { community: communityIdentifier } : undefined);
const { rules, state, title, shortAddress } = community || {};
const { rules, state, shortAddress } = community || {};
const stateString = useStateString(community) || t('downloading_board');
const isLoaded = state === 'succeeded';
const defaultSub = directories.find((sub) => sub.address === communityAddress);
let displayTitle: string;
if (defaultSub?.title) {
const shortCode = getBoardShortCode(defaultSub.title);
const boardName = getBoardName(defaultSub.title);
displayTitle = `Rules for: /${shortCode}/ - ${boardName}`;
} else if (title) {
const shortCode = getBoardShortCode(title);
const boardName = getBoardName(title);
if (shortCode && boardName && boardName !== title) {
displayTitle = `Rules for: /${shortCode}/ - ${boardName}`;
} else {
displayTitle = `Rules for: ${shortAddress || communityAddress}`;
}
} else {
displayTitle = `Rules for: ${shortAddress || communityAddress}`;
}
const displayTitle = `Rules for: ${shortAddress || communityAddress}`;
return (
<div className={`${styles.box} ${styles.rulesBox}`}>
@@ -64,7 +167,7 @@ const BoardRulesDisplay = ({ communityAddress, directories }: { communityAddress
<ol>
{rules.map((rule: string, index: number) => (
<li key={`${index}-${rule}`}>
<Markdown content={rule} />
<Markdown content={rule} parseSpoilers={false} />
</li>
))}
</ol>
@@ -78,60 +181,33 @@ const BoardRulesDisplay = ({ communityAddress, directories }: { communityAddress
);
};
const BoardSelector = ({
directories,
selectedAddress,
onSelect,
}: {
directories: DirectoryCommunity[];
selectedAddress: string;
onSelect: (address: string) => void;
}) => {
// Load any board's own rules live from peers (P2P), separate from the static directory rules below.
// Once a board is loaded the action toggles to "Clear", which drops the result box and empties the input.
const LoadBoardRules = ({ onLoad, onClear, isLoaded }: { onLoad: (address: string) => void; onClear: () => void; isLoaded: boolean }) => {
const { t } = useTranslation();
const [customAddress, setCustomAddress] = useState('');
const selectedDefaultBoard = findDirectoryByAddress(directories, selectedAddress);
const selectedBoardValue = selectedDefaultBoard?.address ?? '';
const handleSelectChange = (e: React.ChangeEvent<HTMLSelectElement>) => {
const value = e.target.value;
if (value) {
onSelect(value);
setCustomAddress('');
}
};
const handleCustomSubmit = (e: FormEvent) => {
const handleSubmit = (e: FormEvent) => {
e.preventDefault();
const trimmed = customAddress.trim();
if (trimmed) {
onSelect(trimmed);
onLoad(trimmed);
}
};
const { t } = useTranslation();
const handleClear = () => {
setCustomAddress('');
onClear();
};
return (
<div className={`${styles.box} ${styles.selectorBox}`}>
<div className={styles.boxBar}>
<h2 className={styles.selectorBoxTitle}>Load rules from a board</h2>
<h2 className={styles.selectorBoxTitle}>Load rules P2P from any board</h2>
</div>
<div className={styles.boxContent}>
<div className={styles.selectorRow}>
<select value={selectedBoardValue} onChange={handleSelectChange} className={styles.boardSelect}>
<option value=''>Select board&hellip;</option>
{directories
.toSorted((a, b) => getBoardShortCode(a.title).localeCompare(getBoardShortCode(b.title)))
.map((sub) => {
const shortCode = getBoardShortCode(sub.title);
const boardName = getBoardName(sub.title);
return (
<option key={sub.address} value={sub.address}>
/{shortCode}/ - {boardName}
</option>
);
})}
</select>
<span className={styles.orSeparator}>or</span>
<form onSubmit={handleCustomSubmit} className={styles.customAddressForm}>
<form onSubmit={handleSubmit} className={styles.customAddressForm}>
<input
type='text'
aria-label={lowerCase(t('enter_board_address'))}
@@ -140,9 +216,15 @@ const BoardSelector = ({
onChange={(e) => setCustomAddress(e.target.value)}
className={styles.addressInput}
/>
<button type='submit' className={styles.goButton}>
Open Board
</button>
{isLoaded ? (
<button type='button' className={styles.goButton} onClick={handleClear}>
Clear
</button>
) : (
<button type='submit' className={styles.goButton}>
Load
</button>
)}
</form>
</div>
</div>
@@ -152,21 +234,44 @@ const BoardSelector = ({
const Rules = () => {
const { boardIdentifier } = useParams();
const navigate = useNavigate();
const directories = useDirectories();
const directoryDefaults = useDirectoryDefaults();
const [loadedAddress, setLoadedAddress] = useState('');
const scrolledForRef = useRef<string | null>(null);
const selectedAddress = boardIdentifier ? getCommunityAddress(boardIdentifier, directories) : '';
// Order directories alphabetically by directory code (e.g. /3/, /a/, /aco/...), like 4chan, not by title.
const directoriesWithCode = directories.filter((community) => getDirectoryCode(community)).toSorted((a, b) => getDirectoryCode(a).localeCompare(getDirectoryCode(b)));
const categoryGroups = groupDirectoriesByCategory(directoriesWithCode, directoryDefaults);
const handleBoardSelect = (address: string) => {
const path = getBoardPath(address, directories);
navigate(`/rules/${path}`, { replace: true });
const handleLoad = (address: string) => {
setLoadedAddress(getCommunityAddress(address, directories));
};
useEffect(() => {
window.scrollTo(0, 0);
document.title = 'Rules - 5chan';
}, []);
useEffect(() => {
setLoadedAddress('');
if (!boardIdentifier) {
scrolledForRef.current = null;
window.scrollTo(0, 0);
}
}, [boardIdentifier]);
// Deep-link: /rules/:code insta-scrolls to that directory's rules once the matching section is rendered.
useEffect(() => {
if (!boardIdentifier || scrolledForRef.current === boardIdentifier) {
return;
}
const code = resolveDirectoryCode(boardIdentifier, directories);
const element = code ? document.getElementById(code) : null;
if (element) {
element.scrollIntoView();
scrolledForRef.current = boardIdentifier;
}
}, [boardIdentifier, directories]);
return (
<div className={styles.wrapper}>
<div className={styles.content}>
@@ -177,14 +282,25 @@ const Rules = () => {
</div>
<div className={styles.boxContent}>
5chan does <i>not</i> have global rules or moderators. It is a serverless, adminless, static tool for browsing and posting to decentralized imageboards.{' '}
<strong>Each board sets its own rules independently</strong>, determined by the board owner and board admins, and enforced by the board moderators.
<strong>Each directory sets its own rules</strong>, listed below and expected of the boards that host it; individual board owners and admins may add their
own.
<br />
<br />
Please read and respect the rules of whatever board you decide to post to.
</div>
</div>
<BoardSelector directories={directories} selectedAddress={selectedAddress} onSelect={handleBoardSelect} />
{selectedAddress && <BoardRulesDisplay communityAddress={selectedAddress} directories={directories} />}
<LoadBoardRules onLoad={handleLoad} onClear={() => setLoadedAddress('')} isLoaded={!!loadedAddress} />
{loadedAddress && <BoardRulesDisplay communityAddress={loadedAddress} />}
<div className={styles.columns}>
<div className={styles.leftColumn}>
<DirectoryNav groups={categoryGroups} />
</div>
<div className={styles.rightColumn}>
{categoryGroups.map((group) => (
<CategoryRulesBox key={group.key} group={group} defaults={directoryDefaults} />
))}
</div>
</div>
<Footer />
</div>
</div>