External/5chan
1
0
Fork 0
mirror of https://github.com/bitsocialnet/5chan.git synced 2026-08-03 07:41:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat(media-upload): Electron recipe parity and diagnostics

Browse Source
This commit is contained in:
plebeius
2026-02-19 17:49:27 +08:00
parent bbddb9ce17
commit b3e8df318c
4 changed files with 164 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
electron/media-upload-recipes.js
+45 -1
View File
@@ -3,6 +3,15 @@
* Each recipe defines selectors and behavior for DOM-based upload flows.
* Selectors are candidate-based: try each until one matches. Fail fast on blocked indicators.
*
* Android vs Electron differences (documented to prevent drift):
* - Android (MediaUploadRecipes.java): imgur/postimages only; no catbox (uses different flow).
* Uses WebChromeClient file chooser interception; trigger JS clicks file input.
* - Electron: catbox/imgur/postimages. Uses CDP DOM.setFileInputFiles + submit button click.
* Catbox: Electron-only; keep behavior unchanged.
* - Blocked/success selectors: reconciled with Android for imgur/postimages; Electron may add
* extra candidates (e.g. [data-captcha], .login-form) where DOM differs.
* - Timeouts: imgur/postimages 45s (parity); catbox 30s (Electron-only).
*
* @typedef {Object} ProviderRecipe
* @property {string} uploadUrl - Full URL of the provider's upload page
* @property {readonly string[]} fileInputSelectorCandidates - CSS selectors for file input (first match wins)
@@ -27,6 +36,7 @@ export const MEDIA_UPLOAD_RECIPES = Object.freeze({
blockedIndicators: Object.freeze(['#challenge', '.captcha', '[data-captcha]', '.g-recaptcha', '.login-form', '#recaptcha']),
timeoutMs: 30_000,
}),
/* Reconciled with Android MediaUploadRecipes (imgur): file input, success extractors, blocked indicators. */
imgur: Object.freeze({
uploadUrl: 'https://imgur.com/upload',
fileInputSelectorCandidates: Object.freeze(['input[type="file"]', 'input[type=file]', '[data-file-input]']),
@@ -35,9 +45,11 @@ export const MEDIA_UPLOAD_RECIPES = Object.freeze({
selectorCandidates: Object.freeze(['a[href*="i.imgur.com"]', 'input[value*="i.imgur.com"]', '[class*="copy-link"] input', '[data-link]']),
attribute: 'href',
}),
blockedIndicators: Object.freeze(['#challenge', '.captcha', '.g-recaptcha', '#recaptcha', '.signin', '.login']),
/* Android: .signin, .login. Electron adds: [data-captcha], .login-form for DOM variations. */
blockedIndicators: Object.freeze(['#challenge', '.captcha', '[data-captcha]', '.g-recaptcha', '#recaptcha', '.login-form', '.signin', '.login']),
timeoutMs: 45_000,
}),
/* Reconciled with Android MediaUploadRecipes (postimages): file input, success extractors, blocked indicators. */
postimages: Object.freeze({
uploadUrl: 'https://postimages.org',
fileInputSelectorCandidates: Object.freeze(['input[type="file"]', 'input[type=file]', '#uploadFile', '.fileinput']),
@@ -50,3 +62,35 @@ export const MEDIA_UPLOAD_RECIPES = Object.freeze({
timeoutMs: 45_000,
}),
});
/**
* Validates that every provider has required recipe fields: trigger (file input), success extractor,
* blocked indicators, and timeout. Throws if any provider is invalid.
*/
function validateRecipes() {
const required = ['fileInputSelectorCandidates', 'submitSelectorCandidates', 'successExtractor', 'blockedIndicators', 'timeoutMs'];
for (const [provider, recipe] of Object.entries(MEDIA_UPLOAD_RECIPES)) {
for (const key of required) {
if (!(key in recipe) || recipe[key] == null) {
throw new Error(`Recipe validation failed: ${provider} missing or null: ${key}`);
}
}
const ex = recipe.successExtractor;
if (!Array.isArray(ex?.selectorCandidates) || ex.selectorCandidates.length === 0 || !ex.attribute) {
throw new Error(`Recipe validation failed: ${provider} successExtractor must have non-empty selectorCandidates and attribute`);
}
if (!Array.isArray(recipe.fileInputSelectorCandidates) || recipe.fileInputSelectorCandidates.length === 0) {
throw new Error(`Recipe validation failed: ${provider} fileInputSelectorCandidates must be non-empty array`);
}
if (!Array.isArray(recipe.blockedIndicators) || recipe.blockedIndicators.length === 0) {
throw new Error(`Recipe validation failed: ${provider} blockedIndicators must be non-empty array`);
}
if (typeof recipe.timeoutMs !== 'number' || recipe.timeoutMs <= 0) {
throw new Error(`Recipe validation failed: ${provider} timeoutMs must be positive number`);
}
}
}
validateRecipes();
export { validateRecipes };