External/5chan
1
0
Fork 0
mirror of https://github.com/bitsocialnet/5chan.git synced 2026-08-03 07:41:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(feed): measure expanded reply media height

Browse Source
This commit is contained in:
Tommaso Casaburi
2026-04-27 13:30:38 +07:00
parent 4fe0494be6
commit b0b5d45376
5 changed files with 49 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/utils/__tests__/pretext-height-estimates.test.ts
+13
View File
@@ -7,6 +7,7 @@ import {
resolveFeedVirtualizationMode,
resolveReplyVirtualizationMode,
} from '../pretext-height-estimates';
import { EXPANDED_MEDIA_DATA_ATTRIBUTE } from '../measurement-attributes';
describe('pretext-height-estimates', () => {
beforeEach(() => {
@@ -81,6 +82,18 @@ describe('pretext-height-estimates', () => {
expect(getReplyItemSizeFromElement(element, 'offsetHeight')).toBe(222);
});
it('uses live DOM height when expanded media is inside an estimated item', () => {
const element = document.createElement('div');
const child = document.createElement('div');
Object.defineProperty(element, 'offsetHeight', { configurable: true, value: 421 });
element.dataset.pretextHeight = '123';
child.setAttribute(EXPANDED_MEDIA_DATA_ATTRIBUTE, 'true');
element.appendChild(child);
expect(getReplyItemSizeFromElement(element, 'offsetHeight')).toBe(421);
});
it('adds desktop board-label height for multiboard text posts without media', () => {
const metrics = {
abbrFontSizePx: 13,