feat(reply-modal): insert quoted post numbers at textarea caret

Replace single-quote blocking behavior with smooth multi-quote support. When the reply modal is open, clicking another post number now inserts >>number at the current caret position instead of showing an alert. Includes caret tracking across blur events and an infinite-loop guard to prevent recursive `setPublishReplyOptions` calls.
This commit is contained in:
plebeius
2026-02-10 14:57:47 +08:00
parent 9d17213e66
commit 8a192b41b4
2 changed files with 77 additions and 4 deletions
+66 -1
View File
@@ -8,6 +8,7 @@ import { getFormattedTimeAgo } from '../../lib/utils/time-utils';
import { isValidURL } from '../../lib/utils/url-utils'; import { isValidURL } from '../../lib/utils/url-utils';
import { isAllView, isSubscriptionsView } from '../../lib/utils/view-utils'; import { isAllView, isSubscriptionsView } from '../../lib/utils/view-utils';
import useSelectedTextStore from '../../stores/use-selected-text-store'; import useSelectedTextStore from '../../stores/use-selected-text-store';
import useReplyModalStore from '../../stores/use-reply-modal-store';
import usePublishReply from '../../hooks/use-publish-reply'; import usePublishReply from '../../hooks/use-publish-reply';
import useIsMobile from '../../hooks/use-is-mobile'; import useIsMobile from '../../hooks/use-is-mobile';
import styles from './reply-modal.module.css'; import styles from './reply-modal.module.css';
@@ -43,7 +44,12 @@ const ReplyModal = ({ closeModal, showReplyModal, parentCid, parentNumber, threa
const [url, setUrl] = useState(''); const [url, setUrl] = useState('');
const textRef = useRef<HTMLTextAreaElement | null>(null); const textRef = useRef<HTMLTextAreaElement | null>(null);
const urlRef = useRef<HTMLInputElement>(null); const urlRef = useRef<HTMLInputElement>(null);
const lastSelectionStartRef = useRef(0);
const lastSelectionEndRef = useRef(0);
const lastProcessedQuoteInsertRequestIdRef = useRef(0);
const { selectedText } = useSelectedTextStore(); const { selectedText } = useSelectedTextStore();
const quoteInsertRequestId = useReplyModalStore((state) => state.quoteInsertRequestId);
const quoteInsertNumber = useReplyModalStore((state) => state.quoteInsertNumber);
const [error, setError] = useState<string | null>(null); const [error, setError] = useState<string | null>(null);
const [lengthError, setLengthError] = useState<string | null>(null); const [lengthError, setLengthError] = useState<string | null>(null);
@@ -186,6 +192,9 @@ const ReplyModal = ({ closeModal, showReplyModal, parentCid, parentNumber, threa
if (showReplyModal && textRef.current) { if (showReplyModal && textRef.current) {
textRef.current.spellcheck = false; textRef.current.spellcheck = false;
textRef.current.value = contentPrefix + (selectedText || ''); textRef.current.value = contentPrefix + (selectedText || '');
const len = textRef.current.value.length;
lastSelectionStartRef.current = len;
lastSelectionEndRef.current = len;
setTimeout(() => { setTimeout(() => {
if (textRef.current) { if (textRef.current) {
@@ -200,6 +209,8 @@ const ReplyModal = ({ closeModal, showReplyModal, parentCid, parentNumber, threa
if (!value.startsWith(contentPrefix)) { if (!value.startsWith(contentPrefix)) {
e.target.value = contentPrefix + value.slice(contentPrefix.length); e.target.value = contentPrefix + value.slice(contentPrefix.length);
} }
lastSelectionStartRef.current = e.target.selectionStart ?? e.target.value.length;
lastSelectionEndRef.current = e.target.selectionEnd ?? lastSelectionStartRef.current;
}; };
const handleContentChange = (e: React.ChangeEvent<HTMLTextAreaElement>) => { const handleContentChange = (e: React.ChangeEvent<HTMLTextAreaElement>) => {
@@ -211,6 +222,44 @@ const ReplyModal = ({ closeModal, showReplyModal, parentCid, parentNumber, threa
} }
}; };
useEffect(() => {
const canInsertQuote = showReplyModal && quoteInsertRequestId !== 0 && !!textRef.current;
const textarea = textRef.current;
if (!canInsertQuote || !textarea) {
return;
}
// Guard: skip if we already processed this exact request id.
// setPublishReplyOptions identity changes after each call (store update -> new content -> new useCallback),
// which re-triggers this effect. Without this guard, that creates an infinite update loop.
if (quoteInsertRequestId === lastProcessedQuoteInsertRequestIdRef.current) {
return;
}
lastProcessedQuoteInsertRequestIdRef.current = quoteInsertRequestId;
const quote = `>>${quoteInsertNumber ?? '?'}`;
const isFocused = document.activeElement === textarea;
const rawStart = isFocused ? (textarea.selectionStart ?? textarea.value.length) : lastSelectionStartRef.current;
const selectionEnd = isFocused ? (textarea.selectionEnd ?? rawStart) : lastSelectionEndRef.current;
const minStart = contentPrefix.length;
const start = Math.max(rawStart, minStart);
const end = Math.max(selectionEnd, minStart);
const nextValue = `${textarea.value.slice(0, start)}${quote}${textarea.value.slice(end)}`;
textarea.value = nextValue;
const nextCursor = start + quote.length;
textarea.focus();
textarea.setSelectionRange(nextCursor, nextCursor);
lastSelectionStartRef.current = nextCursor;
lastSelectionEndRef.current = nextCursor;
const contentWithoutPrefix = nextValue.slice(contentPrefix.length);
const formattedContent = formatMarkdown(contentWithoutPrefix);
setPublishReplyOptions({ content: formattedContent });
checkContentLength(formattedContent, t);
}, [showReplyModal, quoteInsertRequestId, quoteInsertNumber, contentPrefix, setPublishReplyOptions, checkContentLength, t]);
// on android, auto upload file to image hosting sites with open api // on android, auto upload file to image hosting sites with open api
const [isUploading, setIsUploading] = useState(false); const [isUploading, setIsUploading] = useState(false);
const [uploadedFileName, setUploadedFileName] = useState<string | null>(null); const [uploadedFileName, setUploadedFileName] = useState<string | null>(null);
@@ -294,7 +343,23 @@ const ReplyModal = ({ closeModal, showReplyModal, parentCid, parentNumber, threa
/> />
</div> </div>
<div className={styles.content}> <div className={styles.content}>
<textarea cols={48} rows={4} wrap='soft' ref={textRef} spellCheck={true} onInput={handleContentInput} onChange={handleContentChange} /> <textarea
cols={48}
rows={4}
wrap='soft'
ref={textRef}
spellCheck={true}
onInput={handleContentInput}
onChange={handleContentChange}
onSelect={(e) => {
lastSelectionStartRef.current = e.currentTarget.selectionStart ?? e.currentTarget.value.length;
lastSelectionEndRef.current = e.currentTarget.selectionEnd ?? lastSelectionStartRef.current;
}}
onBlur={(e) => {
lastSelectionStartRef.current = e.currentTarget.selectionStart ?? e.currentTarget.value.length;
lastSelectionEndRef.current = e.currentTarget.selectionEnd ?? lastSelectionStartRef.current;
}}
/>
</div> </div>
<div className={styles.footer}> <div className={styles.footer}>
{url && !isAndroid && ( {url && !isAndroid && (
+11 -3
View File
@@ -9,6 +9,8 @@ interface ReplyModalState {
threadCid: string | null; threadCid: string | null;
subplebbitAddress: string | null; subplebbitAddress: string | null;
scrollY: number; scrollY: number;
quoteInsertRequestId: number;
quoteInsertNumber: number | null;
closeModal: () => void; closeModal: () => void;
openReplyModal: (parentCid: string, parentNumber: number | undefined, postCid: string, threadNumber: number | undefined, subplebbitAddress: string) => void; openReplyModal: (parentCid: string, parentNumber: number | undefined, postCid: string, threadNumber: number | undefined, subplebbitAddress: string) => void;
} }
@@ -21,6 +23,8 @@ const useReplyModalStore = create<ReplyModalState>((set, get) => ({
threadCid: null, threadCid: null,
subplebbitAddress: null, subplebbitAddress: null,
scrollY: 0, scrollY: 0,
quoteInsertRequestId: 0,
quoteInsertNumber: null,
closeModal: () => { closeModal: () => {
// Reset selected text if you're using that store // Reset selected text if you're using that store
@@ -30,13 +34,17 @@ const useReplyModalStore = create<ReplyModalState>((set, get) => ({
activeCid: null, activeCid: null,
parentNumber: null, parentNumber: null,
threadNumber: null, threadNumber: null,
quoteInsertNumber: null,
}); });
}, },
openReplyModal: (parentCid, parentNumber, postCid, threadNumber, subplebbitAddress) => { openReplyModal: (parentCid, parentNumber, postCid, threadNumber, subplebbitAddress) => {
// Don't update if already open with different parent // If the reply modal is already open, insert this quote in the current textarea at caret.
if (get().activeCid && get().activeCid !== parentCid) { if (get().showReplyModal) {
window.alert('Multiple quotes are not possible on 5chan for the time being, because of a protocol limitation. Please reply to one post at a time.'); set((state) => ({
quoteInsertRequestId: state.quoteInsertRequestId + 1,
quoteInsertNumber: parentNumber ?? null,
}));
return; return;
} }