External/5chan
1
0
Fork 0
mirror of https://github.com/bitsocialnet/5chan.git synced 2026-08-03 07:41:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(post): align op permalinks to the outer thread container (#1050)

Browse Source 
* fix(post): align op permalinks to the outer thread container

* perf(scroll-to-reply): stop interval when max attempts/duration reached
This commit is contained in:
Tommaso Casaburi
2026-03-10 18:08:20 +08:00
committed by GitHub
parent 4cb5c4a833
commit 6ed3708322
13 changed files with 382 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/hooks/__tests__/use-scroll-to-reply.test.tsx
+48 -25
View File
@@ -75,39 +75,69 @@ describe('useScrollToReply', () => {
targetReplyCid: 'reply-2',
});
act(() => {
vi.advanceTimersByTime(350);
});
expect(testState.scrollToIndexMock).toHaveBeenCalledWith({
align: 'center',
behavior: 'smooth',
behavior: 'auto',
index: 1,
});
expect(testState.loadMoreMock).not.toHaveBeenCalled();
});
it('scrolls to the latest loaded reply and schedules loadMore while searching', async () => {
it('centers a mounted target immediately even when it is already visible', async () => {
const replyElement = document.createElement('div');
const scrollIntoViewMock = vi.fn();
replyElement.dataset.cid = 'reply-2';
replyElement.dataset.postCid = 'post-1';
replyElement.scrollIntoView = scrollIntoViewMock;
document.body.appendChild(replyElement);
await renderHook({
hasMore: true,
replies: [{ cid: 'reply-1' }, { cid: 'reply-2' }],
targetReplyCid: 'reply-2',
});
expect(scrollIntoViewMock).toHaveBeenCalledWith({
behavior: 'auto',
block: 'center',
});
expect(testState.scrollToIndexMock).not.toHaveBeenCalled();
expect(testState.loadMoreMock).not.toHaveBeenCalled();
});
it('scrolls a mounted offscreen target into view immediately', async () => {
const replyElement = document.createElement('div');
const scrollIntoViewMock = vi.fn();
replyElement.dataset.cid = 'reply-3';
replyElement.dataset.postCid = 'post-1';
replyElement.scrollIntoView = scrollIntoViewMock;
document.body.appendChild(replyElement);
await renderHook({
hasMore: true,
replies: [{ cid: 'reply-1' }, { cid: 'reply-3' }],
targetReplyCid: 'reply-3',
});
expect(scrollIntoViewMock).toHaveBeenCalledWith({
behavior: 'auto',
block: 'center',
});
expect(testState.scrollToIndexMock).not.toHaveBeenCalled();
});
it('scrolls to the latest loaded reply and triggers loadMore immediately while searching', async () => {
await renderHook({
hasMore: true,
replies: [{ cid: 'reply-1' }, { cid: 'reply-2' }],
targetReplyCid: 'reply-3',
});
act(() => {
vi.advanceTimersByTime(350);
});
expect(testState.scrollToIndexMock).toHaveBeenCalledWith({
align: 'end',
behavior: 'smooth',
behavior: 'auto',
index: 1,
});
act(() => {
vi.advanceTimersByTime(300);
});
expect(testState.loadMoreMock).toHaveBeenCalledTimes(1);
});
@@ -115,6 +145,7 @@ describe('useScrollToReply', () => {
const replyElement = document.createElement('div');
const scrollIntoViewMock = vi.fn();
replyElement.dataset.cid = 'reply-3';
replyElement.dataset.postCid = 'post-1';
replyElement.scrollIntoView = scrollIntoViewMock;
document.body.appendChild(replyElement);
@@ -124,12 +155,8 @@ describe('useScrollToReply', () => {
targetReplyCid: 'reply-3',
});
act(() => {
vi.advanceTimersByTime(350);
});
expect(scrollIntoViewMock).toHaveBeenCalledWith({
behavior: 'smooth',
behavior: 'auto',
block: 'center',
});
expect(testState.scrollToIndexMock).not.toHaveBeenCalled();
@@ -142,10 +169,6 @@ describe('useScrollToReply', () => {
targetReplyCid: 'reply-404',
});
act(() => {
vi.advanceTimersByTime(350);
});
expect(warnSpy).toHaveBeenCalledWith('[scroll-to-reply] Could not find reply with CID "reply-404" in the feed.');
expect(testState.loadMoreMock).not.toHaveBeenCalled();
});