mirror of
https://github.com/bitsocialnet/5chan.git
synced 2026-08-03 07:41:04 +02:00
fix(codebase audit): preserve cleanup without regressions
Fix codebase audit regressions while preserving UI/UX behavior and adding review-driven hardening.
This commit is contained in:
@@ -23,11 +23,16 @@ import type { QueuedCommentRouteState } from '../../lib/utils/mod-queue-utils';
|
||||
import type { ReplyVirtualizationMode } from '../../lib/utils/pretext-height-estimates';
|
||||
import styles from './post.module.css';
|
||||
|
||||
type CommentWithRefresh = Comment & {
|
||||
export type CommentWithRefresh = Comment & {
|
||||
approved?: boolean;
|
||||
communityAddress?: string;
|
||||
refresh?: () => Promise<void>;
|
||||
state?: string;
|
||||
pendingApproval?: boolean;
|
||||
error?: Error;
|
||||
errors?: Error[];
|
||||
index?: number;
|
||||
removed?: boolean;
|
||||
};
|
||||
|
||||
const getRouteUserState = (state: unknown): QueuedCommentRouteState | undefined => {
|
||||
@@ -134,9 +139,9 @@ export interface PostProps {
|
||||
index?: number;
|
||||
isHidden?: boolean;
|
||||
hasThumbnail?: boolean;
|
||||
post?: any;
|
||||
post?: CommentWithRefresh;
|
||||
postReplyCount?: number;
|
||||
reply?: any;
|
||||
reply?: Comment;
|
||||
replyPaginationOverride?: ReplyPaginationOverride;
|
||||
replyVirtualizationModeOverride?: ReplyVirtualizationMode;
|
||||
roles?: Role[];
|
||||
@@ -364,10 +369,7 @@ const PostPage = () => {
|
||||
const queuedReplyHasMore = queuedReplyRepliesResult.hasMore;
|
||||
const queuedReplyLoadMore = queuedReplyRepliesResult.loadMore;
|
||||
const queuedReplyReset = (queuedReplyRepliesResult as { reset?: () => Promise<void> }).reset;
|
||||
const queuedReplyReplies =
|
||||
((queuedReplyRepliesResult as { updatedReplies?: Comment[] }).updatedReplies?.length
|
||||
? (queuedReplyRepliesResult as { updatedReplies?: Comment[] }).updatedReplies
|
||||
: queuedReplyRepliesResult.replies) || [];
|
||||
const queuedReplyReplies = (queuedReplyRepliesResult.updatedReplies?.length ? queuedReplyRepliesResult.updatedReplies : queuedReplyRepliesResult.replies) || [];
|
||||
const replyPaginationOverride = useMemo(() => {
|
||||
if (!queuedReply || !post?.cid) return undefined;
|
||||
return {
|
||||
|
||||
Reference in New Issue
Block a user