External/5chan
1
0
Fork 0
mirror of https://github.com/bitsocialnet/5chan.git synced 2026-08-03 07:41:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(codebase audit): preserve cleanup without regressions

Browse Source 
Fix codebase audit regressions while preserving UI/UX behavior and adding review-driven hardening.
This commit is contained in:
Tommaso Casaburi
2026-04-24 15:48:07 +07:00
committed by GitHub
parent 5df994b2c7
commit 5dc5408a15
70 changed files with 1478 additions and 518 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/stores/__tests__/use-catalog-filters-store.test.ts
+6 -8
View File
@@ -87,7 +87,7 @@ describe('useCatalogFiltersStore', () => {
expect(persisted).not.toContain('"filteredCids"');
});
it('applies search and content filters, hides matching comments, and counts hidden cids only once per board', async () => {
it('applies search and content filters without mutating counts from the predicate', async () => {
const useCatalogFiltersStore = await loadStore();
useCatalogFiltersStore.getState().setFilterItems([createFilterItem('spam', { hide: true }), createFilterItem('highlight', { hide: false, top: true })] as never);
@@ -103,15 +103,13 @@ describe('useCatalogFiltersStore', () => {
expect(filter?.({ cid: 'cid-3', content: 'topic highlight', communityAddress: 'music.eth' } as never)).toBe(true);
expect(filter?.({ cid: 'cid-4', content: 'ordinary update', communityAddress: 'music.eth' } as never)).toBe(false);
vi.runAllTimers();
const state = useCatalogFiltersStore.getState();
expect(testState.commentMatchesPatternMock).toHaveBeenCalled();
expect(state.filterItems[0].count).toBe(1);
expect(state.filterItems[0].filteredCids).toEqual(new Set(['cid-1']));
expect(state.filterItems[0].communityCounts.get('music.eth')).toBe(1);
expect(state.filteredCount).toBe(1);
expect(state.getFilteredCountForCurrentCommunity()).toBe(1);
expect(state.filterItems[0].count).toBe(0);
expect(state.filterItems[0].filteredCids).toEqual(new Set());
expect(state.filterItems[0].communityCounts.get('music.eth')).toBe(0);
expect(state.filteredCount).toBe(0);
expect(state.getFilteredCountForCurrentCommunity()).toBe(0);
});
it('preserves counts for unchanged filters when saving and clears matched filters', async () => {