External/5chan
1
0
Fork 0
mirror of https://github.com/bitsocialnet/5chan.git synced 2026-08-03 07:41:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(board): wait for feed before empty state

Browse Source
This commit is contained in:
Tommaso Casaburi
2026-04-19 15:33:33 +07:00
parent f2ab25bd08
commit 5b124d4469
2 changed files with 63 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/views/board/board.tsx
+13 -3
View File
@@ -48,7 +48,9 @@ const BOARD_SORT_TYPE = 'active' as const;
interface BoardFooterProps {
communityAddresses: string[];
hasMore: boolean;
feedState: string | undefined;
combinedFeedLength: number;
isSingleCommunityBoard: boolean;
isInSubscriptionsView: boolean;
isInModView: boolean;
currentTimeFilterName: string;
@@ -69,7 +71,9 @@ interface BoardFooterProps {
const BoardFooter = ({
communityAddresses,
hasMore,
feedState,
combinedFeedLength,
isSingleCommunityBoard,
isInSubscriptionsView,
isInModView,
currentTimeFilterName,
@@ -85,6 +89,9 @@ const BoardFooter = ({
const { t } = useTranslation();
const loadingStateString = useFeedStateString(communityAddresses) || (combinedFeedLength === 0 ? t('loading_feed') : t('looking_for_more_posts'));
const isLoadedCommunityState = communityState === 'succeeded' || communityState === 'ready';
const canShowNoThreads = !isSingleCommunityBoard || (isLoadedCommunityState && feedState === 'succeeded');
const isEmptyBoardLoading = isSingleCommunityBoard && combinedFeedLength === 0 && !canShowNoThreads && communityState !== 'failed';
let footerContent;
if (moreThreadsSuggestion && moreThreadsSuggestionPathname) {
@@ -112,7 +119,7 @@ const BoardFooter = ({
/>
</div>
);
} else if (combinedFeedLength === 0) {
} else if (combinedFeedLength === 0 && canShowNoThreads) {
footerContent = t('no_threads');
}
if (communityAddresses && communityAddresses.length === 0) {
@@ -129,7 +136,7 @@ const BoardFooter = ({
) : isInModView && accountCommunityAddressesLength === 0 ? (
<span className='red'>{t('not_mod_of_any_board')}</span>
) : (
showLoadingEllipsis && hasMore && <LoadingEllipsis string={loadingStateString} />
showLoadingEllipsis && (hasMore || isEmptyBoardLoading) && <LoadingEllipsis string={loadingStateString} />
)}
</div>
</div>
@@ -213,7 +220,7 @@ const Board = ({ feedCacheKey, viewType, boardIdentifier: boardIdentifierProp, t
[communities, effectiveInfiniteScroll, infiniteFeedPostsPerPage, paginationFeedPostsPerPage, excludeArchivedFilter, multiboardTimeFilterSeconds],
);
const { feed, hasMore, loadMore, reset, expandTimeWindow } = useFeed(feedOptions);
const { feed, hasMore, loadMore, reset, expandTimeWindow, state: feedState } = useFeed(feedOptions);
const { currentTimeFilterName, currentTimeFilterSeconds, expandSuggestionTimeWindow } = useExpandedTimeFilter({
timeFilterName,
timeFilterSeconds: multiboardTimeFilterSeconds,
@@ -422,7 +429,9 @@ const Board = ({ feedCacheKey, viewType, boardIdentifier: boardIdentifierProp, t
<BoardFooter
communityAddresses={communityAddresses}
hasMore={hasMore}
feedState={feedState}
combinedFeedLength={combinedFeed.length}
isSingleCommunityBoard={!isInAllView && !isInSubscriptionsView && !isInModView}
isInSubscriptionsView={isInSubscriptionsView}
isInModView={isInModView}
currentTimeFilterName={currentTimeFilterName}
@@ -509,6 +518,7 @@ const Board = ({ feedCacheKey, viewType, boardIdentifier: boardIdentifierProp, t
moreThreadsSuggestionPathname,
expandSuggestionTimeWindow,
communityState,
feedState,
communityAddress,
subscriptions?.length,
accountCommunityAddresses?.length,