External/5chan
1
0
Fork 0
mirror of https://github.com/bitsocialnet/5chan.git synced 2026-08-03 07:41:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(board): wait for feed before empty state

Browse Source
This commit is contained in:
Tommaso Casaburi
2026-04-19 15:33:33 +07:00
parent f2ab25bd08
commit 5b124d4469
2 changed files with 63 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/views/board/__tests__/board.test.tsx
+50 -1
View File
@@ -34,7 +34,8 @@ const testState = vi.hoisted(() => ({
} as Record<string, { address: string; features?: Record<string, unknown> }>,
feed: [] as TestComment[],
feedOptionsCalls: [] as Array<{ communitiesLength?: number; newerThan?: number; postsPerPage?: number; sortType?: string }>,
feedStateString: 'syncing',
feedState: undefined as string | undefined,
feedStateString: 'syncing' as string | undefined,
filteredDirectoryAddresses: ['music-posting.eth'] as string[],
hasMore: false,
respectPostsPerPageForNewerThan: new Set<number>(),
@@ -136,6 +137,7 @@ vi.mock('@bitsocialnet/bitsocial-react-hooks', () => ({
return {
feed: getScopedFeed(options),
hasMore: testState.hasMore,
state: testState.feedState ?? (testState.hasMore ? 'fetching-ipns' : 'succeeded'),
expandTimeWindow: testState.expandTimeWindowMock,
loadMore: testState.loadMoreMock,
reset: testState.resetMock,
@@ -326,6 +328,7 @@ describe('Board', () => {
};
testState.feed = [];
testState.feedOptionsCalls = [];
testState.feedState = undefined;
testState.feedStateString = 'syncing';
testState.filteredDirectoryAddresses = ['music-posting.eth'];
testState.hasMore = false;
@@ -642,4 +645,50 @@ describe('Board', () => {
expect(container.querySelector('[data-testid="error-display"]')?.textContent).toBe('board failed');
expect(container.textContent).toContain('failed');
});
it('does not show no threads while a board is still loading', async () => {
testState.feedStateString = undefined;
testState.community = {
error: undefined,
shortAddress: 'music-posting.eth',
state: 'fetching-community-ipfs',
title: '/mu/ - Music',
};
await renderBoard({ initialEntry: '/mu', routePath: '/:boardIdentifier/*' });
expect(container.textContent).not.toContain('no_threads');
expect(container.querySelector('[data-testid="loading-ellipsis"]')?.textContent).toBe('loading_feed');
});
it('does not show no threads while an empty board feed is still loading', async () => {
testState.feedStateString = undefined;
testState.hasMore = true;
testState.community = {
error: undefined,
shortAddress: 'music-posting.eth',
state: 'succeeded',
title: '/mu/ - Music',
};
await renderBoard({ initialEntry: '/mu', routePath: '/:boardIdentifier/*' });
expect(container.textContent).not.toContain('no_threads');
expect(container.querySelector('[data-testid="loading-ellipsis"]')?.textContent).toBe('loading_feed');
});
it('shows no threads after an empty board feed finishes loading', async () => {
testState.feedStateString = undefined;
testState.community = {
error: undefined,
shortAddress: 'music-posting.eth',
state: 'succeeded',
title: '/mu/ - Music',
};
await renderBoard({ initialEntry: '/mu', routePath: '/:boardIdentifier/*' });
expect(container.textContent).toContain('no_threads');
expect(container.querySelector('[data-testid="loading-ellipsis"]')).toBeNull();
});
});