fix(embed): restore x status embeds

This commit is contained in:
Tommaso Casaburi
2026-05-08 16:51:18 +07:00
parent 0c0fd0b018
commit 5187938dc6
2 changed files with 34 additions and 9 deletions
@@ -39,10 +39,12 @@ describe('Embed', () => {
expect(container.querySelector<HTMLIFrameElement>('iframe')?.getAttribute('src')).toContain(`parent=${window.location.hostname}`); expect(container.querySelector<HTMLIFrameElement>('iframe')?.getAttribute('src')).toContain(`parent=${window.location.hostname}`);
}); });
it('renders x and reddit embeds through iframe markup and leaves unsupported urls empty', async () => { it('renders x as a direct tweet iframe, renders reddit through iframe markup, and leaves unsupported urls empty', async () => {
await renderEmbed('https://x.com/test/status/123'); await renderEmbed('https://x.com/test/status/123');
expect(container.querySelector<HTMLIFrameElement>('iframe')?.getAttribute('srcdoc')).toContain('twitter-tweet'); expect(container.querySelector<HTMLIFrameElement>('iframe')?.getAttribute('src')).toBe(
'https://platform.twitter.com/embed/Tweet.html?id=123&theme=dark&dnt=false&hideThread=false&hideCard=false&lang=en',
);
await renderEmbed('https://www.reddit.com/r/test/comments/abc123/example/'); await renderEmbed('https://www.reddit.com/r/test/comments/abc123/example/');
@@ -56,6 +58,8 @@ describe('Embed', () => {
it('reports embeddable hosts through canEmbed and rejects unsupported reddit pages', () => { it('reports embeddable hosts through canEmbed and rejects unsupported reddit pages', () => {
expect(canEmbed(new URL('https://www.youtube.com/watch?v=abc123'))).toBe(true); expect(canEmbed(new URL('https://www.youtube.com/watch?v=abc123'))).toBe(true);
expect(canEmbed(new URL('https://yt.example/watch?v=abc123'))).toBe(true); expect(canEmbed(new URL('https://yt.example/watch?v=abc123'))).toBe(true);
expect(canEmbed(new URL('https://x.com/test/status/123'))).toBe(true);
expect(canEmbed(new URL('https://x.com/test'))).toBe(false);
expect(canEmbed(new URL('https://www.reddit.com/r/test/comments/abc123/example/'))).toBe(true); expect(canEmbed(new URL('https://www.reddit.com/r/test/comments/abc123/example/'))).toBe(true);
expect(canEmbed(new URL('https://www.reddit.com/r/test/'))).toBe(false); expect(canEmbed(new URL('https://www.reddit.com/r/test/'))).toBe(false);
expect(canEmbed(new URL('https://example.com/plain-link'))).toBe(false); expect(canEmbed(new URL('https://example.com/plain-link'))).toBe(false);
+28 -7
View File
@@ -110,7 +110,29 @@ const YoutubeEmbed = ({ parsedUrl }: EmbedComponentProps) => {
const xHosts = new Set<string>(['twitter.com', 'www.twitter.com', 'x.com', 'www.x.com']); const xHosts = new Set<string>(['twitter.com', 'www.twitter.com', 'x.com', 'www.x.com']);
const getXTweetId = (parsedUrl: URL): string | undefined => {
const pathParts = parsedUrl.pathname.split('/').filter(Boolean);
const statusIndex = pathParts.findIndex((part) => part === 'status' || part === 'statuses');
const statusId = statusIndex === -1 ? undefined : pathParts[statusIndex + 1];
return statusId && /^\d+$/.test(statusId) ? statusId : undefined;
};
const XEmbed = ({ parsedUrl }: EmbedComponentProps) => { const XEmbed = ({ parsedUrl }: EmbedComponentProps) => {
const tweetId = getXTweetId(parsedUrl);
if (!tweetId) {
return null;
}
const searchParams = new URLSearchParams({
id: tweetId,
theme: 'dark',
dnt: 'false',
hideThread: 'false',
hideCard: 'false',
lang: 'en',
});
return ( return (
<iframe <iframe
className={styles.xEmbed} className={styles.xEmbed}
@@ -118,14 +140,9 @@ const XEmbed = ({ parsedUrl }: EmbedComponentProps) => {
width='100%' width='100%'
referrerPolicy='no-referrer' referrerPolicy='no-referrer'
allow='accelerometer; encrypted-media; gyroscope; picture-in-picture; web-share' allow='accelerometer; encrypted-media; gyroscope; picture-in-picture; web-share'
sandbox={srcDocSandbox} sandbox={`${srcDocSandbox} allow-same-origin`}
title={parsedUrl.href} title={parsedUrl.href}
srcDoc={` src={`https://platform.twitter.com/embed/Tweet.html?${searchParams.toString()}`}
<blockquote class="twitter-tweet" data-theme="dark">
<a href="${parsedUrl.href.replace('x.com', 'twitter.com')}"></a>
</blockquote>
<script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
`}
/> />
); );
}; };
@@ -335,6 +352,10 @@ const canEmbedHosts = new Set<string>([
]); ]);
export const canEmbed = (parsedUrl: URL): boolean => { export const canEmbed = (parsedUrl: URL): boolean => {
if (xHosts.has(parsedUrl.host)) {
return Boolean(getXTweetId(parsedUrl));
}
if (redditHosts.has(parsedUrl.host)) { if (redditHosts.has(parsedUrl.host)) {
// Reddit posts are not embeddable if the URL does not include '/comments/' // Reddit posts are not embeddable if the URL does not include '/comments/'
return parsedUrl.pathname.includes('/comments/'); return parsedUrl.pathname.includes('/comments/');