External/5chan
1
0
Fork 0
mirror of https://github.com/bitsocialnet/5chan.git synced 2026-08-03 07:41:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(board): subscribe to transient state and error fields separately

Browse Source
This commit is contained in:
plebeius
2026-01-03 16:04:33 +01:00
parent 647139c0ec
commit 4c4e1209aa
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/views/board/board.tsx
+8 -8
View File
@@ -1,7 +1,7 @@
import { useEffect, useMemo, useRef, useState } from 'react'; import { useEffect, useMemo, useRef, useState } from 'react';
import { Link, useLocation, useNavigationType, useParams } from 'react-router-dom'; import { Link, useLocation, useNavigationType, useParams } from 'react-router-dom';
import { Comment, useAccount, useAccountComments, useAccountSubplebbits, useBlock, useFeed } from '@plebbit/plebbit-react-hooks'; import { Comment, useAccount, useAccountComments, useAccountSubplebbits, useBlock, useFeed } from '@plebbit/plebbit-react-hooks';
import { useStableSubplebbit, useSubplebbitField } from '../../hooks/use-stable-subplebbit'; import { useSubplebbitField } from '../../hooks/use-stable-subplebbit';
import { Virtuoso, VirtuosoHandle, StateSnapshot } from 'react-virtuoso'; import { Virtuoso, VirtuosoHandle, StateSnapshot } from 'react-virtuoso';
import { Trans, useTranslation } from 'react-i18next'; import { Trans, useTranslation } from 'react-i18next';
import styles from './board.module.css'; import styles from './board.module.css';
@@ -157,9 +157,9 @@ const Board = ({ feedCacheKey, viewType, boardIdentifier: boardIdentifierProp, t
// Use stable subplebbit fields to avoid rerenders from updatingState // Use stable subplebbit fields to avoid rerenders from updatingState
const subplebbitTitle = useSubplebbitField(subplebbitAddress, (sub) => sub?.title); const subplebbitTitle = useSubplebbitField(subplebbitAddress, (sub) => sub?.title);
const shortAddress = useSubplebbitField(subplebbitAddress, (sub) => sub?.shortAddress); const shortAddress = useSubplebbitField(subplebbitAddress, (sub) => sub?.shortAddress);
// Only subscribe to state and error for footer display - these are needed // Subscribe to transient state/error separately from stable fields since useStableSubplebbit ignores them
const stableSubplebbit = useStableSubplebbit(subplebbitAddress); const subplebbitState = useSubplebbitField(subplebbitAddress, (sub) => sub?.state);
const { error, state } = stableSubplebbit || {}; const subplebbitError = useSubplebbitField(subplebbitAddress, (sub) => sub?.error);
const title = isInAllView ? t('all') : isInSubscriptionsView ? t('subscriptions') : isInModView ? t('mod') : subplebbitTitle; const title = isInAllView ? t('all') : isInSubscriptionsView ? t('subscriptions') : isInModView ? t('mod') : subplebbitTitle;
const { blocked, unblock } = useBlock({ address: subplebbitAddress }); const { blocked, unblock } = useBlock({ address: subplebbitAddress });
@@ -276,8 +276,8 @@ const Board = ({ feedCacheKey, viewType, boardIdentifier: boardIdentifierProp, t
<div className={styles.footer}> <div className={styles.footer}>
{footerContent} {footerContent}
<div> <div>
{state === 'failed' ? ( {subplebbitState === 'failed' ? (
<span className='red'>{state}</span> <span className='red'>{subplebbitState}</span>
) : isInSubscriptionsView && subscriptions?.length === 0 ? ( ) : isInSubscriptionsView && subscriptions?.length === 0 ? (
<span className='red'>{t('not_subscribed_to_any_board')}</span> <span className='red'>{t('not_subscribed_to_any_board')}</span>
) : isInModView && accountSubplebbitAddresses?.length === 0 ? ( ) : isInModView && accountSubplebbitAddresses?.length === 0 ? (
@@ -370,7 +370,7 @@ const Board = ({ feedCacheKey, viewType, boardIdentifier: boardIdentifierProp, t
t, t,
]); ]);
const shouldShowErrorToUser = error?.message && feed.length === 0; const shouldShowErrorToUser = subplebbitError?.message && feed.length === 0;
return ( return (
<> <>
@@ -378,7 +378,7 @@ const Board = ({ feedCacheKey, viewType, boardIdentifier: boardIdentifierProp, t
<div className={`${styles.content} ${shouldShowSnow() ? styles.garland : ''}`}> <div className={`${styles.content} ${shouldShowSnow() ? styles.garland : ''}`}>
{shouldShowErrorToUser && ( {shouldShowErrorToUser && (
<div className={styles.error}> <div className={styles.error}>
<ErrorDisplay error={error} /> <ErrorDisplay error={subplebbitError} />
</div> </div>
)} )}
<Virtuoso <Virtuoso