From 5cfcd8ba04dfd3c8cc1e894fcda478c40690482d Mon Sep 17 00:00:00 2001 From: Tommaso Casaburi Date: Sat, 16 May 2026 00:53:41 +0700 Subject: [PATCH] fix(challenge modal): rename iframe completion button --- .../challenge-modal/__tests__/challenge-modal.test.tsx | 5 ++++- src/components/challenge-modal/challenge-modal.tsx | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/components/challenge-modal/__tests__/challenge-modal.test.tsx b/src/components/challenge-modal/__tests__/challenge-modal.test.tsx index e0e5fd4e..9fc3245e 100644 --- a/src/components/challenge-modal/__tests__/challenge-modal.test.tsx +++ b/src/components/challenge-modal/__tests__/challenge-modal.test.tsx @@ -318,7 +318,10 @@ describe('ChallengeModal', () => { 'https://mintpass.org', ); - await clickButton('Close challenge'); + const doneButton = Array.from(container.querySelectorAll('button')).find((candidate) => candidate.textContent === 'Done'); + expect(doneButton?.getAttribute('aria-label')).toBe('Finish challenge'); + + await clickButton('Done'); expect(publication.publishChallengeAnswers).toHaveBeenCalledWith(['']); expect(testState.removeChallengeMock).toHaveBeenCalledOnce(); }); diff --git a/src/components/challenge-modal/challenge-modal.tsx b/src/components/challenge-modal/challenge-modal.tsx index 03bc9390..a135991e 100644 --- a/src/components/challenge-modal/challenge-modal.tsx +++ b/src/components/challenge-modal/challenge-modal.tsx @@ -291,7 +291,9 @@ const IframeChallenge = ({
- +