From 341e72ad5b5a03152273c0060363579cbffc8cd3 Mon Sep 17 00:00:00 2001
From: plebeius <tom@plebbit.com>
Date: Wed, 31 Dec 2025 16:00:58 +0100
Subject: [PATCH] fix(error-display): add delay to prevent false positive error
 displays

---
 .../error-display/error-display.tsx           | 47 +++++++++++++------
 src/views/catalog/catalog.tsx                 |  8 +---
 2 files changed, 34 insertions(+), 21 deletions(-)

diff --git a/src/components/error-display/error-display.tsx b/src/components/error-display/error-display.tsx
index f1ec63c7..4eec153b 100644
--- a/src/components/error-display/error-display.tsx
+++ b/src/components/error-display/error-display.tsx
@@ -1,4 +1,4 @@
-import { useState } from 'react';
+import { useState, useEffect } from 'react';
 import { useTranslation } from 'react-i18next';
 import { copyToClipboard } from '../../lib/utils/clipboard-utils';
 import styles from './error-display.module.css';
@@ -6,8 +6,27 @@ import styles from './error-display.module.css';
 const ErrorDisplay = ({ error }: { error: any }) => {
   const { t } = useTranslation();
   const [feedbackMessageKey, setFeedbackMessageKey] = useState<string | null>(null);
+  const [shouldShow, setShouldShow] = useState(false);
 
-  const originalDisplayMessage = error?.message ? `${t('error')}: ${error.message}` : null;
+  useEffect(() => {
+    const hasError = !!(error?.message || error?.stack || error?.details || error);
+    if (!hasError) {
+      setShouldShow(false);
+      return;
+    }
+
+    const timer = setTimeout(() => {
+      setShouldShow(true);
+    }, 1000); // delay to avoid false positives, for example when accessing cached feeds that may appear offline for a second or so
+
+    return () => clearTimeout(timer);
+  }, [error]);
+
+  if (!shouldShow) {
+    return null;
+  }
+
+  const originalDisplayMessage = error?.message ? `${t('error')}: ${error.message}` : typeof error === 'string' ? error : null;
 
   const handleMessageClick = async () => {
     if (!error || !error.message || feedbackMessageKey) return;
@@ -45,19 +64,17 @@ const ErrorDisplay = ({ error }: { error: any }) => {
   }
 
   return (
-    (error?.message || error?.stack || error?.details || error) && (
-      <div className={styles.error}>
-        {currentDisplayMessage && (
-          <span
-            className={classNames.join(' ')}
-            onClick={isClickable ? handleMessageClick : undefined}
-            title={isClickable ? t('clickToCopyFullError', 'Click to copy full error') : undefined}
-          >
-            {currentDisplayMessage}
-          </span>
-        )}
-      </div>
-    )
+    <div className={styles.error}>
+      {currentDisplayMessage && (
+        <span
+          className={classNames.join(' ')}
+          onClick={isClickable ? handleMessageClick : undefined}
+          title={isClickable ? t('clickToCopyFullError', 'Click to copy full error') : undefined}
+        >
+          {currentDisplayMessage}
+        </span>
+      )}
+    </div>
   );
 };
 
diff --git a/src/views/catalog/catalog.tsx b/src/views/catalog/catalog.tsx
index a4612ff0..b4ba558b 100644
--- a/src/views/catalog/catalog.tsx
+++ b/src/views/catalog/catalog.tsx
@@ -18,6 +18,7 @@ import useCatalogFiltersStore from '../../stores/use-catalog-filters-store';
 import { getSubplebbitAddress, isDirectoryBoard } from '../../lib/utils/route-utils';
 import CatalogRow from '../../components/catalog-row';
 import LoadingEllipsis from '../../components/loading-ellipsis';
+import ErrorDisplay from '../../components/error-display/error-display';
 import styles from './catalog.module.css';
 import { commentMatchesPattern } from '../../lib/utils/pattern-utils';
 
@@ -345,12 +346,7 @@ const Catalog = ({ feedCacheKey, viewType, boardIdentifier: boardIdentifierProp,
       ) : (
         hasMore && <LoadingEllipsis string={loadingStateString} />
       )}
-      {error && (
-        <div className='red'>
-          <br />
-          {error.message}
-        </div>
-      )}
+      <ErrorDisplay error={error} />
     </div>
   );