fix(catalog): use alias-aware media link labels (#1056)

* fix(catalog): use alias-aware media link labels

* fix(settings): align advanced settings tests with save label

src/components/catalog-row/__tests__/catalog-row.test.tsx

@@ -111,8 +111,16 @@ vi.mock('../../../lib/utils/post-menu-props', () => ({
 }));
 
 vi.mock('../../../hooks/use-directories', () => ({
-  findDirectoryByAddress: (directories: typeof testState.directories, address?: string) => directories.find((entry) => entry.address === address),
-  normalizeBoardAddress: (address: string) => address,
+  findDirectoryByAddress: (directories: typeof testState.directories, address?: string) => {
+    if (!address) {
+      return undefined;
+    }
+
+    const normalizeBoardAddress = (value: string) => value.replace(/\.(bso|eth)$/, '');
+
+    return directories.find((entry) => entry.address === address) ?? directories.find((entry) => normalizeBoardAddress(entry.address) === normalizeBoardAddress(address));
+  },
+  normalizeBoardAddress: (address: string) => address.replace(/\.(bso|eth)$/, ''),
   useDirectories: () => testState.directories,
 }));
 
@@ -316,6 +324,30 @@ describe('CatalogRow', () => {
     expect(document.body.textContent).toContain('ago:200');
   });
 
+  it('uses alias-aware board features when deciding whether reply links are media', async () => {
+    testState.directories = [{ address: 'music-posting.bso', features: { requirePostLinkIsMedia: true }, title: '/mu/ - Music' }];
+    testState.linkCount = 3;
+    testState.mediaInfoByLink['https://example.com/media.png'] = { type: 'image', url: 'https://example.com/media.png' };
+
+    const post: TestComment = {
+      author: { address: 'author-1', displayName: 'Alice' },
+      cid: 'post-alias',
+      content: 'Alias test',
+      link: 'https://example.com/media.png',
+      replyCount: 4,
+      subplebbitAddress: 'music-posting.eth',
+      title: 'Alias title',
+    };
+
+    await renderWithRouter(createElement(CatalogRow, { row: [post] }), '/mu/catalog');
+
+    expect(container.textContent).toContain('R: 4');
+    expect(container.textContent).toContain('/ I: 3');
+    expect(container.textContent).not.toContain('/ L: 3');
+    expect(document.body.querySelector('a[href="/mu/thread/post-alias"]')).toBeTruthy();
+    expect(container.querySelector('[title=\"(R)eplies / (I)mage Replies\"]')).toBeTruthy();
+  });
+
   it('renders hidden and text-only threads with canonical board thread links', async () => {
     testState.hiddenCids = new Set(['hidden-1']);
     testState.showOPComment = false;

src/components/catalog-row/catalog-row.tsx

@@ -9,7 +9,7 @@ import { shouldShowSnow } from '../../lib/snow';
 import { getHasThumbnail } from '../../lib/utils/media-utils';
 import { getFormattedTimeAgo } from '../../lib/utils/time-utils';
 import { isAllView, isSubscriptionsView } from '../../lib/utils/view-utils';
-import { useDirectories } from '../../hooks/use-directories';
+import { findDirectoryByAddress, useDirectories } from '../../hooks/use-directories';
 import { getBoardPath } from '../../lib/utils/route-utils';
 import useCatalogFiltersStore from '../../stores/use-catalog-filters-store';
 import useCatalogStyleStore from '../../stores/use-catalog-style-store';
@@ -130,7 +130,7 @@ const CatalogPost = memo(
     const isInAllView = isAllView(location.pathname);
     const isInSubscriptionsView = isSubscriptionsView(location.pathname, params);
     const directories = useDirectories();
-    const directoryEntry = directories?.find((c) => c.address === subplebbitAddress);
+    const directoryEntry = findDirectoryByAddress(directories, subplebbitAddress);
     const requirePostLinkIsMedia = directoryEntry?.features?.requirePostLinkIsMedia === true;
     const boardPath = subplebbitAddress ? getBoardPath(subplebbitAddress, directories) : '';
     const postMenuProps = useMemo(() => selectPostMenuProps(post), [post]);