External/5chan
1
0
Fork 0
mirror of https://github.com/bitsocialnet/5chan.git synced 2026-08-03 07:41:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(favicon): harden sfw board icon swapping

Browse Source
This commit is contained in:
Tommaso Casaburi
2026-03-24 16:03:31 +07:00
parent fae4bcfe7f
commit 0b844e6060
3 changed files with 34 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/__tests__/update-favicon.test.ts
+11 -7
View File
@@ -7,19 +7,23 @@ describe('update-favicon', () => {
vi.resetModules();
});
it('creates a favicon link and replaces it only when the target icon changes', async () => {
it('replaces managed icon links and keeps both icon rel variants in sync', async () => {
const { updateFavicon } = await import('../update-favicon');
updateFavicon(false);
expect(document.querySelectorAll('link[rel="icon"]')).toHaveLength(1);
expect(document.querySelector('link[rel="icon"]')?.getAttribute('href')).toBe('/favicon.ico');
document.head.innerHTML = '<link rel="icon" href="/favicon.ico"><link rel="shortcut icon" href="/favicon.ico">';
updateFavicon(false);
expect(document.querySelectorAll('link[rel="icon"]')).toHaveLength(1);
expect(document.querySelectorAll('link[rel="icon"], link[rel="shortcut icon"]')).toHaveLength(2);
expect(document.querySelector('link[rel="icon"]')?.getAttribute('href')).toBe('/favicon.ico?variant=nsfw');
expect(document.querySelector('link[rel="shortcut icon"]')?.getAttribute('href')).toBe('/favicon.ico?variant=nsfw');
updateFavicon(false);
expect(document.querySelectorAll('link[rel="icon"], link[rel="shortcut icon"]')).toHaveLength(2);
updateFavicon(true);
expect(document.querySelectorAll('link[rel="icon"]')).toHaveLength(1);
expect(document.querySelector('link[rel="icon"]')?.getAttribute('href')).toBe('/favicon2.ico');
expect(document.querySelectorAll('link[rel="icon"], link[rel="shortcut icon"]')).toHaveLength(2);
expect(document.querySelector('link[rel="icon"]')?.getAttribute('href')).toBe('/favicon2.ico?variant=sfw');
expect(document.querySelector('link[rel="shortcut icon"]')?.getAttribute('href')).toBe('/favicon2.ico?variant=sfw');
});
it('marks only non-special, non-routing aggregate sfw boards as sfw', async () => {