From f7897061fc687805babd674a7a47f015855d8917 Mon Sep 17 00:00:00 2001
From: David <info@thedaviddelta.com>
Date: Thu, 11 Mar 2021 13:29:22 +0100
Subject: [PATCH] Refactor using hooks rules

---
 pages/[[...slug]].tsx | 28 ++++++++++++----------------
 utils/translate.ts    |  2 +-
 2 files changed, 13 insertions(+), 17 deletions(-)

diff --git a/pages/[[...slug]].tsx b/pages/[[...slug]].tsx
index 653e20d..db34ccd 100644
--- a/pages/[[...slug]].tsx
+++ b/pages/[[...slug]].tsx
@@ -1,6 +1,6 @@
-import { useEffect, useReducer, FC, ChangeEvent } from "react";
+import { useState, useEffect, useReducer, FC, ChangeEvent } from "react";
 import { GetStaticPaths, GetStaticProps, InferGetStaticPropsType } from "next";
-import { useRouter } from "next/router";
+import Router from "next/router";
 import Error from "next/error";
 import { googleScrape, extractSlug } from "../utils/translate";
 import Languages from "../components/Languages";
@@ -8,10 +8,8 @@ import { retrieveFiltered } from "../utils/language";
 import langReducer, { Actions, initialState } from "../utils/reducer";
 
 const Page: FC<InferGetStaticPropsType<typeof getStaticProps>> = ({ translation, error, initial }) => {
-    if (error)
-        return <Error statusCode={error} />
-
     const [{ source, target, query }, dispatch] = useReducer(langReducer, initialState);
+    const [encodedQuery, setEncodedQuery] = useState("");
 
     const handleChange = (e: ChangeEvent<HTMLInputElement | HTMLSelectElement>) => {
         dispatch({
@@ -23,12 +21,6 @@ const Page: FC<InferGetStaticPropsType<typeof getStaticProps>> = ({ translation,
         });
     };
 
-    const router = useRouter();
-
-    const updateTranslation = () => {
-        query && router.push(`/${source}/${target}/${query}`);
-    };
-
     useEffect(() => {
         initial && dispatch({ type: Actions.SET_ALL, payload: { state: initial }});
     }, [initial]);
@@ -37,15 +29,19 @@ const Page: FC<InferGetStaticPropsType<typeof getStaticProps>> = ({ translation,
         if (!query || query === initial?.query)
             return;
 
-        const timeout = setTimeout(updateTranslation, 1000);
+        const timeout = setTimeout(() => setEncodedQuery(encodeURIComponent(query)), 1000);
         return () => clearTimeout(timeout);
-    }, [query]);
+    }, [query, initial?.query]);
 
-    useEffect(updateTranslation, [source, target]);
+    useEffect(() => {
+        encodedQuery && Router.push(`/${source}/${target}/${encodedQuery}`);
+    }, [source, target, encodedQuery]);
 
     const { sourceLangs, targetLangs } = retrieveFiltered(source, target);
 
-    return (
+    return error ? (
+        <Error statusCode={error} />
+    ) : (
         <div>
             <div>
                 <button onClick={() => dispatch({ type: Actions.SWITCH_LANGS })} disabled={source === "auto"}>
@@ -92,7 +88,7 @@ export const getStaticPaths: GetStaticPaths = async () => ({
     fallback: true
 });
 
-export const getStaticProps: GetStaticProps = async ({ params, locale }) => {
+export const getStaticProps: GetStaticProps = async ({ params }) => {
     if (!params?.slug || !Array.isArray(params.slug))
         return {
             props: {}
diff --git a/utils/translate.ts b/utils/translate.ts
index a1516df..ecfdde1 100644
--- a/utils/translate.ts
+++ b/utils/translate.ts
@@ -10,7 +10,7 @@ export async function googleScrape(
     error?: number
 }> {
     const parsed = replaceBoth("mapping", { source, target });
-    const res = await fetch(`https://translate.google.com/m?sl=${parsed.source}&tl=${parsed.target}&q=${encodeURI(query)}`);
+    const res = await fetch(`https://translate.google.com/m?sl=${parsed.source}&tl=${parsed.target}&q=${encodeURIComponent(query)}`);
 
     if (!res.ok)
         return {